From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: alsa-devel@alsa-project.org, clemens@ladisch.de
Subject: Re: [PATCH 1/2] ALSA: firewire-lib: cache next data_block_counter after probing tracepoints event for IR context
Date: Fri, 28 Jun 2019 10:50:21 +0200 [thread overview]
Message-ID: <s5hr27e6qlu.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190628055331.1427-2-o-takashi@sakamocchi.jp>
On Fri, 28 Jun 2019 07:53:30 +0200,
Takashi Sakamoto wrote:
>
> For debugging purpose, ALSA IEC 61883-1/6 engine has tracepoints event.
> In current implementation, next data block counter is stored as current
> data block counter before probing the event for IR isoc context. It's not
> good to check current packet parameter.
>
> This commit changes to assign the next data block counter after probing
> the event.
>
> Besides, Fireworks devices has a quirk to transfer isoc packet with
> data block counter for the last data block. For this quirk, the
> assignment is done before calling data block processing layer.
>
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Thanks, applied now.
Takashi
next prev parent reply other threads:[~2019-06-28 8:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 5:53 [PATCH 0/2] ALSA: firewire-lib: fix miss detection from MIDI conformant data channel in AM824 format for IR context Takashi Sakamoto
2019-06-28 5:53 ` [PATCH 1/2] ALSA: firewire-lib: cache next data_block_counter after probing tracepoints event " Takashi Sakamoto
2019-06-28 8:50 ` Takashi Iwai [this message]
2019-06-28 5:53 ` [PATCH 2/2] ALSA: firewire-lib: fix to process MIDI conformant data channel for AM824 format Takashi Sakamoto
2019-06-28 8:50 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hr27e6qlu.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=o-takashi@sakamocchi.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox