ALSA 1.0.0pre3 release

ALSA 1.0.0pre3 release

[Takashi Iwai]

Hi,

right now the ALSA 1.0.0pre3 packages are released.

In this version, alsa-tools package was divided to two several ones,
alsa-tools and alsa-firmware.  The latter contains only the firmware
binary files required by loader programs in alsa-tools package.
Please test them if you have a board requiring the loader (hdsp,
mixart, vx, usx2y).

Especially, HDSP users, please test and report whether it works, since
the hdsploader was modified to load the files dynamically.


Changes

- usb-audio driver supports async unlinking.
  On 2.6 kernels, it's enabled as default, but on older kenrels, it's
  disabled to avoid a serious usb-uhci bug.  If you have another
  controller, please try the module option async_unlink=1.

- hdsp driver update (including H9652 bugfixes).

- support of more Tascam USxxx devices.

- Audiotrak Prodigy bugfixes.

- fixed noise on vx222 with 24bit mode.
   
- complation fixes on alsa-drivers.
  The 2.2 kernel is still not tested well.  If you can test it, please
  let us know.

- fixed CM8738-MC6 5.1 alias.

- alsaconf fix for RH, Fedora and Mandrake.

- hdsp* tools updates.  compilation fixes.


--
Takashi Iwai <tiwai@suse.de>		ALSA Developer - www.alsa-project.org


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: ALSA 1.0.0pre3 release

[Ronny V. Vindenes]

On Tue, 2003-11-25 at 20:04, Takashi Iwai wrote:
> Hi,
> 
> right now the ALSA 1.0.0pre3 packages are released.
> 
> In this version, alsa-tools package was divided to two several ones,
> alsa-tools and alsa-firmware.  The latter contains only the firmware
> binary files required by loader programs in alsa-tools package.
> Please test them if you have a board requiring the loader (hdsp,
> mixart, vx, usx2y).
> 
> Especially, HDSP users, please test and report whether it works, since
> the hdsploader was modified to load the files dynamically.
> 
> 

mmap'ed sound with the cs46xx driver seems to be broken, every other
half second the sound is muted. Non-mmap'ed sound plays normally. This
is under 2.6.0-test9-mm5. The version included in test9-mm5 works as
expected (there was some patches in mm5 against ALSA, but applying those
to 1.0.0pre3 made no difference for this particular problem).

-- 
Ronny V. Vindenes <s864@ii.uib.no>



-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: [Alsa-user] Re: ALSA 1.0.0pre3 release

[Takashi Iwai]

At Wed, 26 Nov 2003 01:11:07 +0100,
Ronny V. Vindenes wrote:
> 
> On Tue, 2003-11-25 at 20:04, Takashi Iwai wrote:
> > Hi,
> > 
> > right now the ALSA 1.0.0pre3 packages are released.
> > 
> > In this version, alsa-tools package was divided to two several ones,
> > alsa-tools and alsa-firmware.  The latter contains only the firmware
> > binary files required by loader programs in alsa-tools package.
> > Please test them if you have a board requiring the loader (hdsp,
> > mixart, vx, usx2y).
> > 
> > Especially, HDSP users, please test and report whether it works, since
> > the hdsploader was modified to load the files dynamically.
> > 
> > 
> 
> mmap'ed sound with the cs46xx driver seems to be broken, every other
> half second the sound is muted. Non-mmap'ed sound plays normally. This
> is under 2.6.0-test9-mm5. The version included in test9-mm5 works as
> expected (there was some patches in mm5 against ALSA, but applying those
> to 1.0.0pre3 made no difference for this particular problem).

there is no big change in cs46xx driver itself, so the change is
either in kernel core or in the config.
do you use CONFIG_SND_CS46XX_NEW_DSP ?


Takashi


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: [Alsa-user] Re: ALSA 1.0.0pre3 release

[Ronny V. Vindenes]

On Wed, 2003-11-26 at 11:44, Takashi Iwai wrote: 
> At Wed, 26 Nov 2003 01:11:07 +0100,
> Ronny V. Vindenes wrote:
> > 
> > On Tue, 2003-11-25 at 20:04, Takashi Iwai wrote:
> > > Hi,
> > > 
> > > right now the ALSA 1.0.0pre3 packages are released.
> > > 
> > > In this version, alsa-tools package was divided to two several ones,
> > > alsa-tools and alsa-firmware.  The latter contains only the firmware
> > > binary files required by loader programs in alsa-tools package.
> > > Please test them if you have a board requiring the loader (hdsp,
> > > mixart, vx, usx2y).
> > > 
> > > Especially, HDSP users, please test and report whether it works, since
> > > the hdsploader was modified to load the files dynamically.
> > > 
> > > 
> > 
> > mmap'ed sound with the cs46xx driver seems to be broken, every other
> > half second the sound is muted. Non-mmap'ed sound plays normally. This
> > is under 2.6.0-test9-mm5. The version included in test9-mm5 works as
> > expected (there was some patches in mm5 against ALSA, but applying those
> > to 1.0.0pre3 made no difference for this particular problem).
> 
> there is no big change in cs46xx driver itself, so the change is
> either in kernel core or in the config.
> do you use CONFIG_SND_CS46XX_NEW_DSP ?

Yes.

I've tested it with 2.6.0-test10 too now, and I've narrowed it down a
bit: native alsa mmap'ed or not works, but oss emulation only works
correctly when not using mmap.

Things like wine, quake3, Enemy Territory all sound awful. Plain
2.6.0-test10 works fine in all cases.

-- 

Ronny V. Vindenes <s864@ii.uib.no>



-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: Re: [Alsa-devel] ALSA 1.0.0pre3 release

[Takashi Iwai]

At Wed, 26 Nov 2003 13:10:11 +0100,
Ronny V. Vindenes wrote:
> 
> On Wed, 2003-11-26 at 11:44, Takashi Iwai wrote: 
> > At Wed, 26 Nov 2003 01:11:07 +0100,
> > Ronny V. Vindenes wrote:
> > > 
> > > On Tue, 2003-11-25 at 20:04, Takashi Iwai wrote:
> > > > Hi,
> > > > 
> > > > right now the ALSA 1.0.0pre3 packages are released.
> > > > 
> > > > In this version, alsa-tools package was divided to two several ones,
> > > > alsa-tools and alsa-firmware.  The latter contains only the firmware
> > > > binary files required by loader programs in alsa-tools package.
> > > > Please test them if you have a board requiring the loader (hdsp,
> > > > mixart, vx, usx2y).
> > > > 
> > > > Especially, HDSP users, please test and report whether it works, since
> > > > the hdsploader was modified to load the files dynamically.
> > > > 
> > > > 
> > > 
> > > mmap'ed sound with the cs46xx driver seems to be broken, every other
> > > half second the sound is muted. Non-mmap'ed sound plays normally. This
> > > is under 2.6.0-test9-mm5. The version included in test9-mm5 works as
> > > expected (there was some patches in mm5 against ALSA, but applying those
> > > to 1.0.0pre3 made no difference for this particular problem).
> > 
> > there is no big change in cs46xx driver itself, so the change is
> > either in kernel core or in the config.
> > do you use CONFIG_SND_CS46XX_NEW_DSP ?
> 
> Yes.
> 
> I've tested it with 2.6.0-test10 too now, and I've narrowed it down a
> bit: native alsa mmap'ed or not works, but oss emulation only works
> correctly when not using mmap.
> 
> Things like wine, quake3, Enemy Territory all sound awful. Plain
> 2.6.0-test10 works fine in all cases.

to be sure, try to set direct mode for oss-emulation via writing to
the proc file.  see alsa-kernel/Documentation/OSS-Emulation.txt.

also, please check /proc/asound/card0/pcm0p/sub0/* files in both
cases.


Takashi


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: [Alsa-user] Re: ALSA 1.0.0pre3 release

[Ronny V. Vindenes]

[-- Attachment #1: Type: text/plain, Size: 2175 bytes --]

On Wed, 2003-11-26 at 13:32, Takashi Iwai wrote:
> At Wed, 26 Nov 2003 13:10:11 +0100,
> Ronny V. Vindenes wrote:
> > 
> > On Wed, 2003-11-26 at 11:44, Takashi Iwai wrote: 
> > > At Wed, 26 Nov 2003 01:11:07 +0100,
> > > Ronny V. Vindenes wrote:
> > > > 
> > > > On Tue, 2003-11-25 at 20:04, Takashi Iwai wrote:
> > > > > Hi,
> > > > > 
> > > > > right now the ALSA 1.0.0pre3 packages are released.
> > > > > 
> > > > > In this version, alsa-tools package was divided to two several ones,
> > > > > alsa-tools and alsa-firmware.  The latter contains only the firmware
> > > > > binary files required by loader programs in alsa-tools package.
> > > > > Please test them if you have a board requiring the loader (hdsp,
> > > > > mixart, vx, usx2y).
> > > > > 
> > > > > Especially, HDSP users, please test and report whether it works, since
> > > > > the hdsploader was modified to load the files dynamically.
> > > > > 
> > > > > 
> > > > 
> > > > mmap'ed sound with the cs46xx driver seems to be broken, every other
> > > > half second the sound is muted. Non-mmap'ed sound plays normally. This
> > > > is under 2.6.0-test9-mm5. The version included in test9-mm5 works as
> > > > expected (there was some patches in mm5 against ALSA, but applying those
> > > > to 1.0.0pre3 made no difference for this particular problem).
> > > 
> > > there is no big change in cs46xx driver itself, so the change is
> > > either in kernel core or in the config.
> > > do you use CONFIG_SND_CS46XX_NEW_DSP ?
> > 
> > Yes.
> > 
> > I've tested it with 2.6.0-test10 too now, and I've narrowed it down a
> > bit: native alsa mmap'ed or not works, but oss emulation only works
> > correctly when not using mmap.
> > 
> > Things like wine, quake3, Enemy Territory all sound awful. Plain
> > 2.6.0-test10 works fine in all cases.
> 
> to be sure, try to set direct mode for oss-emulation via writing to
> the proc file.  see alsa-kernel/Documentation/OSS-Emulation.txt.

Setting direct mode made no difference.

> 
> also, please check /proc/asound/card0/pcm0p/sub0/* files in both
> cases.

I've attached cat /proc/asound/card0/pcm0p/sub0/* for both cases

-- 
Ronny V. Vindenes <s864@ii.uib.no>

[-- Attachment #2: oss-emu-mmap --]
[-- Type: text/plain, Size: 763 bytes --]

access: MMAP_INTERLEAVED
format: S16_LE
subformat: STD
channels: 2
rate: 22050 (22050/1)
period_size: 512
buffer_size: 16384
tick_time: 1000
OSS format: S16_LE
OSS channels: 2
OSS rate: 22050
OSS period bytes: 2048
OSS periods: 32
card: 0
device: 0
subdevice: 0
stream: PLAYBACK
id: CS46xx
name: CS46xx
subname: subdevice #0
class: 0
subclass: 0
subdevices_count: 31
subdevices_avail: 30
64
state: RUNNING
trigger_time: 1069855349.000085703
tstamp      : 1069855357.000765834
delay       : 15968
avail       : 416
avail_max   : 32912
-----
hw_ptr      : 191392
appl_ptr    : 207360
tstamp_mode: NONE
period_step: 1
sleep_min: 0
avail_min: 1
xfer_align: 1
start_threshold: 1
stop_threshold: 1073741824
silence_threshold: 528
silence_size: 528
boundary: 1073741824

[-- Attachment #3: oss-emu-nonmmap --]
[-- Type: text/plain, Size: 756 bytes --]

access: RW_INTERLEAVED
format: S16_LE
subformat: STD
channels: 2
rate: 44100 (44100/1)
period_size: 512
buffer_size: 16384
tick_time: 1000
OSS format: S16_LE
OSS channels: 2
OSS rate: 44100
OSS period bytes: 2048
OSS periods: 32
card: 0
device: 0
subdevice: 0
stream: PLAYBACK
id: CS46xx
name: CS46xx
subname: subdevice #0
class: 0
subclass: 0
subdevices_count: 31
subdevices_avail: 30
64
state: RUNNING
trigger_time: 1069855565.000290916
tstamp      : 1069855577.000743808
delay       : 9392
avail       : 6992
avail_max   : 15872
-----
hw_ptr      : 549200
appl_ptr    : 558592
tstamp_mode: NONE
period_step: 1
sleep_min: 0
avail_min: 1
xfer_align: 1
start_threshold: 1
stop_threshold: 16384
silence_threshold: 528
silence_size: 528
boundary: 1073741824

Re: [Alsa-user] Re: ALSA 1.0.0pre3 release

[Takashi Iwai]

At Wed, 26 Nov 2003 15:10:06 +0100,
Ronny V. Vindenes wrote:
> 
> On Wed, 2003-11-26 at 13:32, Takashi Iwai wrote:
> > At Wed, 26 Nov 2003 13:10:11 +0100,
> > Ronny V. Vindenes wrote:
> > > 
> > > On Wed, 2003-11-26 at 11:44, Takashi Iwai wrote: 
> > > > At Wed, 26 Nov 2003 01:11:07 +0100,
> > > > Ronny V. Vindenes wrote:
> > > > > 
> > > > > On Tue, 2003-11-25 at 20:04, Takashi Iwai wrote:
> > > > > > Hi,
> > > > > > 
> > > > > > right now the ALSA 1.0.0pre3 packages are released.
> > > > > > 
> > > > > > In this version, alsa-tools package was divided to two several ones,
> > > > > > alsa-tools and alsa-firmware.  The latter contains only the firmware
> > > > > > binary files required by loader programs in alsa-tools package.
> > > > > > Please test them if you have a board requiring the loader (hdsp,
> > > > > > mixart, vx, usx2y).
> > > > > > 
> > > > > > Especially, HDSP users, please test and report whether it works, since
> > > > > > the hdsploader was modified to load the files dynamically.
> > > > > > 
> > > > > > 
> > > > > 
> > > > > mmap'ed sound with the cs46xx driver seems to be broken, every other
> > > > > half second the sound is muted. Non-mmap'ed sound plays normally. This
> > > > > is under 2.6.0-test9-mm5. The version included in test9-mm5 works as
> > > > > expected (there was some patches in mm5 against ALSA, but applying those
> > > > > to 1.0.0pre3 made no difference for this particular problem).
> > > > 
> > > > there is no big change in cs46xx driver itself, so the change is
> > > > either in kernel core or in the config.
> > > > do you use CONFIG_SND_CS46XX_NEW_DSP ?
> > > 
> > > Yes.
> > > 
> > > I've tested it with 2.6.0-test10 too now, and I've narrowed it down a
> > > bit: native alsa mmap'ed or not works, but oss emulation only works
> > > correctly when not using mmap.
> > > 
> > > Things like wine, quake3, Enemy Territory all sound awful. Plain
> > > 2.6.0-test10 works fine in all cases.
> > 
> > to be sure, try to set direct mode for oss-emulation via writing to
> > the proc file.  see alsa-kernel/Documentation/OSS-Emulation.txt.
> 
> Setting direct mode made no difference.
> 
> > 
> > also, please check /proc/asound/card0/pcm0p/sub0/* files in both
> > cases.
> 
> I've attached cat /proc/asound/card0/pcm0p/sub0/* for both cases

sorry, i meant the ALSA 1.0.0pre3 and the 2.6.0-test10 (oss-emu with
mmap).  it's known that the mmap support of this chip is not perfect.
but i still suspect that the base oss-emu code change affected this.


Takashi


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: [Alsa-user] Re: ALSA 1.0.0pre3 release

[Ronny V. Vindenes]

[-- Attachment #1: Type: text/plain, Size: 2772 bytes --]

On Wed, 2003-11-26 at 15:15, Takashi Iwai wrote:
> At Wed, 26 Nov 2003 15:10:06 +0100,
> Ronny V. Vindenes wrote:
> > 
> > On Wed, 2003-11-26 at 13:32, Takashi Iwai wrote:
> > > At Wed, 26 Nov 2003 13:10:11 +0100,
> > > Ronny V. Vindenes wrote:
> > > > 
> > > > On Wed, 2003-11-26 at 11:44, Takashi Iwai wrote: 
> > > > > At Wed, 26 Nov 2003 01:11:07 +0100,
> > > > > Ronny V. Vindenes wrote:
> > > > > > 
> > > > > > On Tue, 2003-11-25 at 20:04, Takashi Iwai wrote:
> > > > > > > Hi,
> > > > > > > 
> > > > > > > right now the ALSA 1.0.0pre3 packages are released.
> > > > > > > 
> > > > > > > In this version, alsa-tools package was divided to two several ones,
> > > > > > > alsa-tools and alsa-firmware.  The latter contains only the firmware
> > > > > > > binary files required by loader programs in alsa-tools package.
> > > > > > > Please test them if you have a board requiring the loader (hdsp,
> > > > > > > mixart, vx, usx2y).
> > > > > > > 
> > > > > > > Especially, HDSP users, please test and report whether it works, since
> > > > > > > the hdsploader was modified to load the files dynamically.
> > > > > > > 
> > > > > > > 
> > > > > > 
> > > > > > mmap'ed sound with the cs46xx driver seems to be broken, every other
> > > > > > half second the sound is muted. Non-mmap'ed sound plays normally. This
> > > > > > is under 2.6.0-test9-mm5. The version included in test9-mm5 works as
> > > > > > expected (there was some patches in mm5 against ALSA, but applying those
> > > > > > to 1.0.0pre3 made no difference for this particular problem).
> > > > > 
> > > > > there is no big change in cs46xx driver itself, so the change is
> > > > > either in kernel core or in the config.
> > > > > do you use CONFIG_SND_CS46XX_NEW_DSP ?
> > > > 
> > > > Yes.
> > > > 
> > > > I've tested it with 2.6.0-test10 too now, and I've narrowed it down a
> > > > bit: native alsa mmap'ed or not works, but oss emulation only works
> > > > correctly when not using mmap.
> > > > 
> > > > Things like wine, quake3, Enemy Territory all sound awful. Plain
> > > > 2.6.0-test10 works fine in all cases.
> > > 
> > > to be sure, try to set direct mode for oss-emulation via writing to
> > > the proc file.  see alsa-kernel/Documentation/OSS-Emulation.txt.
> > 
> > Setting direct mode made no difference.
> > 
> > > 
> > > also, please check /proc/asound/card0/pcm0p/sub0/* files in both
> > > cases.
> > 
> > I've attached cat /proc/asound/card0/pcm0p/sub0/* for both cases
> 
> sorry, i meant the ALSA 1.0.0pre3 and the 2.6.0-test10 (oss-emu with
> mmap).  it's known that the mmap support of this chip is not perfect.
> but i still suspect that the base oss-emu code change affected this.
> 
> 
> Takashi
> 

ok, here's from plain test10

-- 
Ronny V. Vindenes <s864@ii.uib.no>

[-- Attachment #2: 2.6.0-test10 --]
[-- Type: text/plain, Size: 764 bytes --]

access: MMAP_INTERLEAVED
format: S16_LE
subformat: STD
channels: 2
rate: 22050 (22050/1)
period_size: 512
buffer_size: 16384
tick_time: 1000
OSS format: S16_LE
OSS channels: 2
OSS rate: 22050
OSS period bytes: 2048
OSS periods: 32
card: 0
device: 0
subdevice: 0
stream: PLAYBACK
id: CS46xx
name: CS46xx
subname: subdevice #0
class: 0
subclass: 0
subdevices_count: 31
subdevices_avail: 30
64
state: RUNNING
trigger_time: 1069856885.000853207
tstamp      : 1069856889.000718741
delay       : 16144
avail       : 240
avail_max   : 33200
-----
hw_ptr      : 85232
appl_ptr    : 101376
tstamp_mode: NONE
period_step: 1
sleep_min: 0
avail_min: 512
xfer_align: 1
start_threshold: 1
stop_threshold: 1073741824
silence_threshold: 528
silence_size: 528
boundary: 1073741824

Re: [Alsa-devel] ALSA 1.0.0pre3 release

[Thomas Charbonnel]

Takashi Iwai wrote :
> Hi,
> 
> right now the ALSA 1.0.0pre3 packages are released.
> 
> In this version, alsa-tools package was divided to two several ones,
> alsa-tools and alsa-firmware.  The latter contains only the firmware
> binary files required by loader programs in alsa-tools package.
> Please test them if you have a board requiring the loader (hdsp,
> mixart, vx, usx2y).
> 
> Especially, HDSP users, please test and report whether it works, since
> the hdsploader was modified to load the files dynamically.
> 
> 
> Changes
> 
> - usb-audio driver supports async unlinking.
>   On 2.6 kernels, it's enabled as default, but on older kenrels, it's
>   disabled to avoid a serious usb-uhci bug.  If you have another
>   controller, please try the module option async_unlink=1.
> 
> - hdsp driver update (including H9652 bugfixes).
> 
> - support of more Tascam USxxx devices.
> 
> - Audiotrak Prodigy bugfixes.
> 
> - fixed noise on vx222 with 24bit mode.
>    
> - complation fixes on alsa-drivers.
>   The 2.2 kernel is still not tested well.  If you can test it, please
>   let us know.
> 
> - fixed CM8738-MC6 5.1 alias.
> 
> - alsaconf fix for RH, Fedora and Mandrake.
> 
> - hdsp* tools updates.  compilation fixes.
> 
> 
> --
> Takashi Iwai <tiwai@suse.de>		ALSA Developer - www.alsa-project.org

Takashi it seems that at least for hdsploader (I didn't check the other 
tools) you forgot the trailing / in DATAPATH in Makefile.am, so the 
program fails to find the firmware file :
Unable to open file 
'/usr/local/share/alsa/firmware/hdsploadermultiface_firmware.bin' for 
reading

Thomas




-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: ALSA 1.0.0pre3 release

[Takashi Iwai]

[-- Attachment #1: Type: text/plain, Size: 1839 bytes --]

At Wed, 26 Nov 2003 17:38:04 +0100,
Thomas Charbonnel wrote:
> 
> Takashi Iwai wrote :
> > Hi,
> > 
> > right now the ALSA 1.0.0pre3 packages are released.
> > 
> > In this version, alsa-tools package was divided to two several ones,
> > alsa-tools and alsa-firmware.  The latter contains only the firmware
> > binary files required by loader programs in alsa-tools package.
> > Please test them if you have a board requiring the loader (hdsp,
> > mixart, vx, usx2y).
> > 
> > Especially, HDSP users, please test and report whether it works, since
> > the hdsploader was modified to load the files dynamically.
> > 
> > 
> > Changes
> > 
> > - usb-audio driver supports async unlinking.
> >   On 2.6 kernels, it's enabled as default, but on older kenrels, it's
> >   disabled to avoid a serious usb-uhci bug.  If you have another
> >   controller, please try the module option async_unlink=1.
> > 
> > - hdsp driver update (including H9652 bugfixes).
> > 
> > - support of more Tascam USxxx devices.
> > 
> > - Audiotrak Prodigy bugfixes.
> > 
> > - fixed noise on vx222 with 24bit mode.
> >    
> > - complation fixes on alsa-drivers.
> >   The 2.2 kernel is still not tested well.  If you can test it, please
> >   let us know.
> > 
> > - fixed CM8738-MC6 5.1 alias.
> > 
> > - alsaconf fix for RH, Fedora and Mandrake.
> > 
> > - hdsp* tools updates.  compilation fixes.
> > 
> > 
> > --
> > Takashi Iwai <tiwai@suse.de>		ALSA Developer - www.alsa-project.org
> 
> Takashi it seems that at least for hdsploader (I didn't check the other 
> tools) you forgot the trailing / in DATAPATH in Makefile.am, so the 
> program fails to find the firmware file :
> Unable to open file 
> '/usr/local/share/alsa/firmware/hdsploadermultiface_firmware.bin' for 
> reading

oh yes, you're right.
is the attached patch ok?
i'll check it in.


Takashi

[-- Attachment #2: Type: text/plain, Size: 1163 bytes --]

Index: alsa-tools/hdsploader/hdsploader.c
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-tools/hdsploader/hdsploader.c,v
retrieving revision 1.6
diff -u -r1.6 hdsploader.c
--- alsa-tools/hdsploader/hdsploader.c	25 Nov 2003 16:39:25 -0000	1.6
+++ alsa-tools/hdsploader/hdsploader.c	26 Nov 2003 17:06:40 -0000
@@ -83,16 +83,16 @@
     switch (version.io_type) {
     case Multiface:
 	if (version.firmware_rev == 0xa) {
-	    err = read_bin_file(code, DATAPATH "multiface_firmware.bin");
+	    err = read_bin_file(code, DATAPATH "/multiface_firmware.bin");
 	} else {
-	    err = read_bin_file(code, DATAPATH "multiface_firmware_rev11.bin");
+	    err = read_bin_file(code, DATAPATH "/multiface_firmware_rev11.bin");
 	}
 	break;
     case Digiface:
 	if (version.firmware_rev == 0xa) {
-	    err = read_bin_file(code, DATAPATH "digiface_firmware.bin");
+	    err = read_bin_file(code, DATAPATH "/digiface_firmware.bin");
 	} else {
-	    err = read_bin_file(code, DATAPATH "digiface_firmware_rev11.bin");
+	    err = read_bin_file(code, DATAPATH "/digiface_firmware_rev11.bin");
 	}
 	break;
     default:

Re: ALSA 1.0.0pre3 release

[Thomas Charbonnel]

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

Takashi Iwai wrote :

>>Takashi it seems that at least for hdsploader (I didn't check the other 
>>tools) you forgot the trailing / in DATAPATH in Makefile.am, so the 
>>program fails to find the firmware file :
>>Unable to open file 
>>'/usr/local/share/alsa/firmware/hdsploadermultiface_firmware.bin' for 
>>reading
> 
> 
> oh yes, you're right.
> is the attached patch ok?
> i'll check it in.
> 

Good for me, thanks.
Please also apply the attached patch to hdspmixer, it fixes some 
problems with default presets file handling.

Thomas.

[-- Attachment #2: hdspmixer.diff --]
[-- Type: text/plain, Size: 1964 bytes --]

diff -Naur hdspmixer.orig/src/HDSPMixerWindow.cxx hdspmixer/src/HDSPMixerWindow.cxx
--- hdspmixer.orig/src/HDSPMixerWindow.cxx	2003-11-27 01:36:29.000000000 +0100
+++ hdspmixer/src/HDSPMixerWindow.cxx	2003-11-27 01:35:01.000000000 +0100
@@ -397,7 +397,13 @@
 {
     FILE *file;
     if ((file = fopen(file_name, "r")) == NULL) {
+	int i = 0;
 	fl_alert("Error opening file %s for reading", file_name);
+	while (cards[i] != NULL) {
+	    restoreDefaults(i++);
+	}
+	inputs->buttons->presets->preset_change(1);	
+	return;
     }
     for (int speed = 0; speed < 3; ++speed) {
 	for (int card = 0; card < 3; ++card) {
@@ -533,6 +539,7 @@
 	h9632_an12_submix[2] = 1;
 	num_modes = 3;
 	phones = 0;
+	break;
     default:
 	/* should never happen */
 	return;
@@ -624,8 +631,18 @@
     cards[2] = hdsp_card3;
     current_card = current_preset = 0;
     prefs = new Fl_Preferences(Fl_Preferences::USER, "thomasATundata.org", "HDSPMixer");
-    if (!prefs->get("default_file", file_name_buffer, NULL, FL_PATH_MAX-1)) file_name = NULL;
-    else file_name = file_name_buffer;
+    if (!prefs->get("default_file", file_name_buffer, NULL, FL_PATH_MAX-1)) {
+	file_name = NULL;
+    } else {
+	struct stat buf;
+	if (!stat(file_name_buffer, &buf)) {
+	    file_name = file_name_buffer;
+	} else {
+	    file_name = NULL;
+	    prefs->deleteEntry("default_file");
+	    prefs->flush();
+	}	
+    }
     for (int j = 0; j < 3; ++j) {
 	for (int i = 0; i < 8; ++i) {
 	    data[j][0][i] = new HDSPMixerPresetData();
diff -Naur hdspmixer.orig/src/HDSPMixerWindow.h hdspmixer/src/HDSPMixerWindow.h
--- hdspmixer.orig/src/HDSPMixerWindow.h	2003-11-27 01:36:29.000000000 +0100
+++ hdspmixer/src/HDSPMixerWindow.h	2003-11-27 01:25:03.000000000 +0100
@@ -35,6 +35,9 @@
 #include <stdlib.h>
 #include <math.h>
 #include <sys/ioctl.h>
+#include <sys/types.h>
+#include <sys/stat.h>
+#include <unistd.h>
 #include <alsa/asoundlib.h>
 #include <sound/hdsp.h>
 #include "HDSPMixerCard.h"

Re: [Alsa-devel] ALSA 1.0.0pre3 release

[Takashi Iwai]

At Thu, 27 Nov 2003 01:46:19 +0100,
Thomas Charbonnel wrote:
> 
> Takashi Iwai wrote :
> 
> >>Takashi it seems that at least for hdsploader (I didn't check the other 
> >>tools) you forgot the trailing / in DATAPATH in Makefile.am, so the 
> >>program fails to find the firmware file :
> >>Unable to open file 
> >>'/usr/local/share/alsa/firmware/hdsploadermultiface_firmware.bin' for 
> >>reading
> > 
> > 
> > oh yes, you're right.
> > is the attached patch ok?
> > i'll check it in.
> > 
> 
> Good for me, thanks.
> Please also apply the attached patch to hdspmixer, it fixes some 
> problems with default presets file handling.

applied.

thanks,

Takashi


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/