From: Takashi Iwai <tiwai@suse.de>
To: Thomas Klausner <tk@giga.or.at>
Cc: alsa-devel@alsa-project.org
Subject: Re: byteswap.h
Date: Thu, 03 Mar 2016 12:37:25 +0100 [thread overview]
Message-ID: <s5hsi076bd6.wl-tiwai@suse.de> (raw)
In-Reply-To: <20160303111840.GJ8492@danbala.tuwien.ac.at>
On Thu, 03 Mar 2016 12:18:40 +0100,
Thomas Klausner wrote:
>
> On Thu, Mar 03, 2016 at 11:21:05AM +0100, Takashi Iwai wrote:
> > On Thu, 03 Mar 2016 11:10:05 +0100,
> > Thomas Klausner wrote:
> > >
> > > On Thu, Mar 03, 2016 at 11:01:23AM +0100, Takashi Iwai wrote:
> > > > Applied now. Thanks.
> > >
> > > Thank you!
> > >
> > > Next big issue: Many places include byteswap.h to get bswap_16,
> > > bswap_32, bswap_64.
> > >
> > > This header does not exist on *BSD or Solaris.
> > >
> > > However, all of these provide similar macros under different names,
> > > from different header files (bswap16 etc, or BSWAP_16).
> > >
> > > Do you want a compat header, e.g. include/bswap.h that takes care of
> > > this and is included by local.h, or do you prefer a different
> > > solution?
> >
> > bswap.h looks better ATM. Let's see.
>
> Ok, here's my try for a version of bswap.h. Does it look ok?
Looks good to me -- supposing you tested it actually :)
Takashi
next prev parent reply other threads:[~2016-03-03 11:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 15:47 feeding back pkgsrc changs Thomas Klausner
2016-02-18 15:51 ` Takashi Iwai
2016-02-23 14:09 ` portability patch: EBADF [was Re: feeding back pkgsrc changs] Thomas Klausner
2016-02-23 15:53 ` Takashi Iwai
2016-02-24 13:16 ` Thomas Klausner
2016-02-24 15:36 ` Takashi Iwai
2016-02-25 23:31 ` portability: types Thomas Klausner
2016-02-26 8:45 ` Clemens Ladisch
2016-02-29 15:05 ` [PATCH 1/3] Use POSIX uint*_t instead of u_int*_t Thomas Klausner
2016-02-29 15:05 ` [PATCH 2/3] Use pid_t, off_t instead of __kernel_*_t for better portability Thomas Klausner
2016-02-29 16:10 ` Takashi Iwai
2016-03-02 22:14 ` [PATCH] define more missing types for non-Linux Thomas Klausner
2016-03-03 9:32 ` Takashi Iwai
2016-03-03 9:50 ` Thomas Klausner
2016-03-03 9:53 ` Takashi Iwai
2016-03-03 9:55 ` Takashi Iwai
2016-03-03 9:58 ` Thomas Klausner
2016-03-03 10:01 ` Takashi Iwai
2016-03-03 10:10 ` byteswap.h Thomas Klausner
2016-03-03 10:21 ` byteswap.h Takashi Iwai
2016-03-03 11:18 ` byteswap.h Thomas Klausner
2016-03-03 11:37 ` Takashi Iwai [this message]
2016-03-03 11:39 ` byteswap.h Thomas Klausner
2016-03-03 12:02 ` Remaining compatibility patches for NetBSD Thomas Klausner
2016-03-03 13:35 ` Takashi Iwai
2016-03-03 13:46 ` Thomas Klausner
2016-03-03 13:54 ` Takashi Iwai
2016-03-03 14:23 ` Thomas Klausner
2016-02-29 15:05 ` [PATCH 3/3] Use uint*_t instead of __le* Thomas Klausner
2016-02-29 15:10 ` [PATCH 4/4] Replace __u* with uint*_t Thomas Klausner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hsi076bd6.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=tk@giga.or.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox