From: Takashi Iwai <tiwai@suse.de>
To: Thomas Klausner <tk@giga.or.at>
Cc: alsa-devel@alsa-project.org
Subject: Re: portability patch: EBADF [was Re: feeding back pkgsrc changs]
Date: Wed, 24 Feb 2016 16:36:36 +0100 [thread overview]
Message-ID: <s5h8u2adssb.wl-tiwai@suse.de> (raw)
In-Reply-To: <20160224131655.GA22682@danbala.tuwien.ac.at>
On Wed, 24 Feb 2016 14:16:55 +0100,
Thomas Klausner wrote:
>
> On Tue, Feb 23, 2016 at 04:53:51PM +0100, Takashi Iwai wrote:
> > On Tue, 23 Feb 2016 15:09:06 +0100,
> > Thomas Klausner wrote:
> > > Thanks for the answer.
> > >
> > > On Thu, Feb 18, 2016 at 04:51:15PM +0100, Takashi Iwai wrote:
> > > > On Thu, 18 Feb 2016 16:47:44 +0100,
> > > > Thomas Klausner wrote:
> > > > > I've just updated the pkgsrc packages for alsa-lib, alsa-utils and
> > > > > alsa-plugins to 1.1.0 and noticed that there are quite a number of
> > > > > local patches we have. I'd like to get them integrated.
> > > > >
> > > > > When I visited the alsa-projects web page, I noticed that the link to
> > > > > the bug tracker is dead.
> > > > >
> > > > > What is the recommended method to provide the patches?
> > > >
> > > > Just submit your patches to alsa-devel ML. That's the best way to
> > > > review and get merged.
> > >
> > > I'll start with a straightforward one. Some operating systems don't
> > > provide an errno 'EBADFD'; let's use EBADF there instead.
> > >
> > > This patch adds the define in all files that need it, but if you
> > > prefer to add it to a central place instead, please suggest one.
> >
> > How about put this in include/local.h instead? Then we need to put it
> > only in one place, as this is supposed to be included by all codes.
>
> Sounds good and works. New patch attached.
Applied now. Thanks.
Takashi
next prev parent reply other threads:[~2016-02-24 15:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 15:47 feeding back pkgsrc changs Thomas Klausner
2016-02-18 15:51 ` Takashi Iwai
2016-02-23 14:09 ` portability patch: EBADF [was Re: feeding back pkgsrc changs] Thomas Klausner
2016-02-23 15:53 ` Takashi Iwai
2016-02-24 13:16 ` Thomas Klausner
2016-02-24 15:36 ` Takashi Iwai [this message]
2016-02-25 23:31 ` portability: types Thomas Klausner
2016-02-26 8:45 ` Clemens Ladisch
2016-02-29 15:05 ` [PATCH 1/3] Use POSIX uint*_t instead of u_int*_t Thomas Klausner
2016-02-29 15:05 ` [PATCH 2/3] Use pid_t, off_t instead of __kernel_*_t for better portability Thomas Klausner
2016-02-29 16:10 ` Takashi Iwai
2016-03-02 22:14 ` [PATCH] define more missing types for non-Linux Thomas Klausner
2016-03-03 9:32 ` Takashi Iwai
2016-03-03 9:50 ` Thomas Klausner
2016-03-03 9:53 ` Takashi Iwai
2016-03-03 9:55 ` Takashi Iwai
2016-03-03 9:58 ` Thomas Klausner
2016-03-03 10:01 ` Takashi Iwai
2016-03-03 10:10 ` byteswap.h Thomas Klausner
2016-03-03 10:21 ` byteswap.h Takashi Iwai
2016-03-03 11:18 ` byteswap.h Thomas Klausner
2016-03-03 11:37 ` byteswap.h Takashi Iwai
2016-03-03 11:39 ` byteswap.h Thomas Klausner
2016-03-03 12:02 ` Remaining compatibility patches for NetBSD Thomas Klausner
2016-03-03 13:35 ` Takashi Iwai
2016-03-03 13:46 ` Thomas Klausner
2016-03-03 13:54 ` Takashi Iwai
2016-03-03 14:23 ` Thomas Klausner
2016-02-29 15:05 ` [PATCH 3/3] Use uint*_t instead of __le* Thomas Klausner
2016-02-29 15:10 ` [PATCH 4/4] Replace __u* with uint*_t Thomas Klausner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h8u2adssb.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=tk@giga.or.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox