Re: [PATCH] define more missing types for non-Linux

[Takashi Iwai <tiwai@suse.de>]

On Thu, 03 Mar 2016 10:53:46 +0100,
Takashi Iwai wrote:
> 
> On Thu, 03 Mar 2016 10:50:41 +0100,
> Thomas Klausner wrote:
> > 
> > On Thu, Mar 03, 2016 at 10:32:04AM +0100, Takashi Iwai wrote:
> > > Can we put this in include/type_compat.h or something like that, and
> > > include it in #else block of #ifdef __linux__?
> > > 
> > > As a bonus, the EBADFD definition can also go to there, too.
> > 
> > Sure, see attached.
> >  Thomas
> > >From c68bfda4e5198b50b32937de669155afb423d726 Mon Sep 17 00:00:00 2001
> > From: Thomas Klausner <wiz@NetBSD.org>
> > Date: Wed, 2 Mar 2016 23:11:54 +0100
> > Subject: [PATCH] Define some types if missing.
> > 
> > For portability with non-Linux.
> > 
> > Include Linux headers on Linux only.
> > ---
> >  include/local.h       |  6 ++---
> >  include/type_compat.h | 66 +++++++++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 69 insertions(+), 3 deletions(-)
> >  create mode 100644 include/type_compat.h
> 
> You need to add it in include/Makefile.am, too.
> Otherwise it'll slip from the tarball.

Oh, also it'd be good if you give your sign-off, too.
For user-space, I accept the patches without sign-off as long as they
are trivial enough.  But this kind of change is preferred with a
proper sign off, of course.


thanks,

Takashi