Re: [2.6 patch] ALSA PCI drivers: misc cleanups

Re: [2.6 patch] ALSA PCI drivers: misc cleanups

[Lee Revell]

On Mon, 2004-11-22 at 00:58 +0100, Adrian Bunk wrote:
>   - emu10k1/io.c: snd_emu10k1_voice_set_loop_stop

Please do not remove this function.  I am working on an enhancement to
the emu10k1 driver that uses it.

Thanks,

Lee



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/

Re: Re: [2.6 patch] ALSA PCI drivers: misc cleanups

[Takashi Iwai]

At Sun, 21 Nov 2004 20:57:12 -0500,
Lee Revell wrote:
> 
> On Mon, 2004-11-22 at 00:58 +0100, Adrian Bunk wrote:
> >   - emu10k1/io.c: snd_emu10k1_voice_set_loop_stop
> 
> Please do not remove this function.  I am working on an enhancement to
> the emu10k1 driver that uses it.

Do you need snd_emu10k1_sum_vol_attn, too?


Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/

Re: [2.6 patch] ALSA PCI drivers: misc cleanups

[Takashi Iwai]

At Mon, 22 Nov 2004 00:58:55 +0100,
Adrian Bunk wrote:
> 
> The patch below does the following cleanups under sound/pci/ :
>   - cs46xx/dsp_spos_scb_lib.c: cs46xx_dsp_create_filter_scb
>   - cs46xx/dsp_spos_scb_lib.c: cs46xx_dsp_create_output_snoop_scb

I'd rather like to keep them with #if 0.
These functions will be needed when someone extends the DSP code.

> --- linux-2.6.10-rc2-mm2-full/sound/pci/ac97/ac97_local.h.old	2004-11-22 00:00:07.000000000 +0100
> +++ linux-2.6.10-rc2-mm2-full/sound/pci/ac97/ac97_local.h	2004-11-22 00:00:27.000000000 +0100
> @@ -45,9 +45,6 @@
>  int snd_ac97_page_get_single(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol);
>  int snd_ac97_page_put_single(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol);
>  int snd_ac97_try_bit(ac97_t * ac97, int reg, int bit);
> -int snd_ac97_remove_ctl(ac97_t *ac97, const char *name, const char *suffix);
> -int snd_ac97_rename_ctl(ac97_t *ac97, const char *src, const char *dst, const char *suffix);
> -int snd_ac97_swap_ctl(ac97_t *ac97, const char *s1, const char *s2, const char *suffix);

They are intentionally non-static to allow ac97_patch.c functions to
access them (in future).  Please keep them so.


Otherwise the patch looks fine.
Thanks!


Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/

Re: Re: [2.6 patch] ALSA PCI drivers: misc cleanups

[Lee Revell]

On Mon, 2004-11-22 at 18:25 +0100, Takashi Iwai wrote:
> At Sun, 21 Nov 2004 20:57:12 -0500,
> Lee Revell wrote:
> > 
> > On Mon, 2004-11-22 at 00:58 +0100, Adrian Bunk wrote:
> > >   - emu10k1/io.c: snd_emu10k1_voice_set_loop_stop
> > 
> > Please do not remove this function.  I am working on an enhancement to
> > the emu10k1 driver that uses it.
> 
> Do you need snd_emu10k1_sum_vol_attn, too?
> 

Nope.  Any idea what this is/was for?  I poked around the OSS driver and
could not find a similar function.

Lee



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/

Re: Re: [2.6 patch] ALSA PCI drivers: misc cleanups

[Takashi Iwai]

At Mon, 22 Nov 2004 12:43:05 -0500,
Lee Revell wrote:
> 
> On Mon, 2004-11-22 at 18:25 +0100, Takashi Iwai wrote:
> > At Sun, 21 Nov 2004 20:57:12 -0500,
> > Lee Revell wrote:
> > > 
> > > On Mon, 2004-11-22 at 00:58 +0100, Adrian Bunk wrote:
> > > >   - emu10k1/io.c: snd_emu10k1_voice_set_loop_stop
> > > 
> > > Please do not remove this function.  I am working on an enhancement to
> > > the emu10k1 driver that uses it.
> > 
> > Do you need snd_emu10k1_sum_vol_attn, too?
> > 
> 
> Nope.  Any idea what this is/was for?  I poked around the OSS driver and
> could not find a similar function.

IIRC, it came from the very old version of OSS emu10k1 driver.


Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/

Re: Re: [2.6 patch] ALSA PCI drivers: misc cleanups

[Lee Revell]

On Mon, 2004-11-22 at 18:55 +0100, Takashi Iwai wrote:
> At Mon, 22 Nov 2004 12:43:05 -0500,
> Lee Revell wrote:
> > 
> > On Mon, 2004-11-22 at 18:25 +0100, Takashi Iwai wrote:
> > > At Sun, 21 Nov 2004 20:57:12 -0500,
> > > Lee Revell wrote:
> > > > 
> > > > On Mon, 2004-11-22 at 00:58 +0100, Adrian Bunk wrote:
> > > > >   - emu10k1/io.c: snd_emu10k1_voice_set_loop_stop
> > > > 
> > > > Please do not remove this function.  I am working on an enhancement to
> > > > the emu10k1 driver that uses it.
> > > 
> > > Do you need snd_emu10k1_sum_vol_attn, too?
> > > 
> > 
> > Nope.  Any idea what this is/was for?  I poked around the OSS driver and
> > could not find a similar function.
> 
> IIRC, it came from the very old version of OSS emu10k1 driver.
> 

OK.  I have added James to the cc.

Lee



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/

Re: Re: [2.6 patch] ALSA PCI drivers: misc cleanups

[Lee Revell]

On Mon, 2004-11-22 at 18:55 +0100, Takashi Iwai wrote:
> > Nope.  Any idea what this is/was for?  I poked around the OSS driver and
> > could not find a similar function.
> 
> IIRC, it came from the very old version of OSS emu10k1 driver.
> 

OK.  If this code was in the original opensource.creative.com driver
then there is always the chance it embodies some knowledge of the
hardware that we don't have.  For example set_loop_stop, which was also
in the OSS driver but unused, can be used to start multiple channels in
sync.  But as long as the CVS history is available this should not be a
problem.

Lee



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/

Re: Re: [2.6 patch] ALSA PCI drivers: misc cleanups

[Takashi Iwai]

At Mon, 22 Nov 2004 13:14:01 -0500,
Lee Revell wrote:
> 
> On Mon, 2004-11-22 at 18:55 +0100, Takashi Iwai wrote:
> > > Nope.  Any idea what this is/was for?  I poked around the OSS driver and
> > > could not find a similar function.
> > 
> > IIRC, it came from the very old version of OSS emu10k1 driver.
> > 
> 
> OK.  If this code was in the original opensource.creative.com driver
> then there is always the chance it embodies some knowledge of the
> hardware that we don't have.  For example set_loop_stop, which was also
> in the OSS driver but unused, can be used to start multiple channels in
> sync.  But as long as the CVS history is available this should not be a
> problem.

Yep.  The code is just to calculate X * ln2(Y) (or something like
that), so anyway it's not important for the hardware control.


Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/

Re: [2.6 patch] ALSA PCI drivers: misc cleanups

[Takashi Iwai]

At Mon, 22 Nov 2004 18:28:34 +0100,
I wrote:
> 
> Otherwise the patch looks fine.

Applied to ALSA CVS now.
(Will be propagated to BK later...)


thanks,

Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/