From: Takashi Iwai <tiwai@suse.de>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>, Simon <horms@verge.net.au>
Subject: Re: [PATCH] ASoC: rsnd: stop all working stream when .remove
Date: Fri, 01 Sep 2017 09:29:55 +0200 [thread overview]
Message-ID: <s5htw0mx4ek.wl-tiwai@suse.de> (raw)
In-Reply-To: <874lsnniv3.wl%kuninori.morimoto.gx@renesas.com>
On Fri, 01 Sep 2017 06:34:48 +0200,
Kuninori Morimoto wrote:
>
>
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Driver should stop all working stream when .remove timing.
> Current Renesas sound driver is assuming that all stream was
> stopped when .remove but it was wrong.
> This patch stops all working stream when .remove, otherwise
> kernel will get damage for example in below case.
> Special thanks to Truong, Hiep
>
> > cd /sys/bus/platform/drivers/rcar_sound
> > aplay xxx.wav &
> > echo ec500000.sound > unbind
>
> Reported-by: Hiep Cao Minh <cm-hiep@jinso.co.jp>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
The lack of stop sync is a known problem in the ALSA PCM
infrastructure. The standard idiom is to do sync at both prepare and
hw_free (or close) callbacks.
Takashi
next prev parent reply other threads:[~2017-09-01 7:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 4:34 [PATCH] ASoC: rsnd: stop all working stream when .remove Kuninori Morimoto
2017-09-01 7:29 ` Takashi Iwai [this message]
2017-09-01 7:48 ` Kuninori Morimoto
2017-09-01 8:17 ` Takashi Iwai
2017-09-04 17:44 ` Kuninori Morimoto
2017-09-04 18:43 ` Takashi Iwai
2017-09-04 18:46 ` Takashi Iwai
2017-09-05 7:40 ` Kuninori Morimoto
2017-09-05 8:09 ` Takashi Iwai
2017-09-05 8:58 ` Kuninori Morimoto
2017-09-05 9:33 ` Takashi Iwai
2017-09-05 10:07 ` Kuninori Morimoto
2017-09-05 10:12 ` Mark Brown
2017-09-05 11:35 ` Takashi Iwai
2017-09-05 12:58 ` Takashi Iwai
2017-09-26 8:21 ` Kuninori Morimoto
2017-09-27 5:14 ` Kuninori Morimoto
2017-10-06 13:19 ` Takashi Iwai
2017-10-10 8:00 ` Kuninori Morimoto
2017-10-11 6:52 ` Kuninori Morimoto
2017-09-05 14:04 ` Mark Brown
2017-09-05 14:08 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5htw0mx4ek.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox