From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Simon <horms@verge.net.au>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH] ASoC: rsnd: stop all working stream when .remove
Date: Tue, 05 Sep 2017 16:08:31 +0200 [thread overview]
Message-ID: <s5hr2vlme5c.wl-tiwai@suse.de> (raw)
In-Reply-To: <20170905140400.kiz4hlksdz25f7cu@sirena.org.uk>
On Tue, 05 Sep 2017 16:04:00 +0200,
Mark Brown wrote:
>
> On Tue, Sep 05, 2017 at 01:35:58PM +0200, Takashi Iwai wrote:
>
> > So my idea is something like below (totally untested): call
> > snd_card_disconnect_sync() at the remove call of each component at the
> > beginning.
> > That assures stopping all pending operations and syncs with the file
> > releases. For ASoC, we may want to wrap it with ASoC structs, but you
> > can have an idea by this patch.
>
> I'd say that in ASoC we'd have the call to this in the core rather than
> wrapping it, I'd expect the first thing the drivers do is to unregister
> the component.
Yes, that makes sense.
Takashi
prev parent reply other threads:[~2017-09-05 14:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 4:34 [PATCH] ASoC: rsnd: stop all working stream when .remove Kuninori Morimoto
2017-09-01 7:29 ` Takashi Iwai
2017-09-01 7:48 ` Kuninori Morimoto
2017-09-01 8:17 ` Takashi Iwai
2017-09-04 17:44 ` Kuninori Morimoto
2017-09-04 18:43 ` Takashi Iwai
2017-09-04 18:46 ` Takashi Iwai
2017-09-05 7:40 ` Kuninori Morimoto
2017-09-05 8:09 ` Takashi Iwai
2017-09-05 8:58 ` Kuninori Morimoto
2017-09-05 9:33 ` Takashi Iwai
2017-09-05 10:07 ` Kuninori Morimoto
2017-09-05 10:12 ` Mark Brown
2017-09-05 11:35 ` Takashi Iwai
2017-09-05 12:58 ` Takashi Iwai
2017-09-26 8:21 ` Kuninori Morimoto
2017-09-27 5:14 ` Kuninori Morimoto
2017-10-06 13:19 ` Takashi Iwai
2017-10-10 8:00 ` Kuninori Morimoto
2017-10-11 6:52 ` Kuninori Morimoto
2017-09-05 14:04 ` Mark Brown
2017-09-05 14:08 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hr2vlme5c.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox