From: Takashi Iwai <tiwai@suse.de>
To: Kailang <kailang@realtek.com>
Cc: " (alsa-devel@alsa-project.org)" <alsa-devel@alsa-project.org>
Subject: Re: HP mute led for ALC286
Date: Thu, 20 Nov 2014 11:05:50 +0100 [thread overview]
Message-ID: <s5htx1uxk3l.wl-tiwai@suse.de> (raw)
In-Reply-To: <6FAB7C47BCF00940BB0999A99BE3547A179FB92A@RTITMBSV09.realtek.com.tw>
At Thu, 20 Nov 2014 07:04:01 +0000,
Kailang wrote:
>
>
>
> > -----Original Message-----
> > From: Takashi Iwai [mailto:tiwai@suse.de]
> > Sent: Wednesday, November 19, 2014 7:28 PM
> > To: Kailang
> > Cc: (alsa-devel@alsa-project.org)
> > Subject: Re: HP mute led for ALC286
> >
> > At Wed, 19 Nov 2014 07:13:16 +0000,
> > Kailang wrote:
> > >
> > > Hi Takashi,
> > >
> > > I had sent the discussion mail about the DMI string for HP.
> > > But no body response.
> > > So, I just send the patch to fix this issue.
> >
> > I'd like to avoid the duplicated open codes, so could you try
> > the patch below and rewrite your patch to follow this? You'd
> > just need to set like:
> > spec->gpio_mute_led_mask = 0x02;
> > spec->gpio_mic_led_mask = 0x20;
> > pec->mute_led_polarity = 0;
> > then you can use the existing alc_fixup_gpio_mute_hook and
> > alc_fixup_gpio_mic_mute_hook.
>
> I modified as attach patch. ^^
Oh, no, I meant an additional patch on top of my previous patch, not
folding into that one.
For your ease, I applied my patch to for-next branch now, so that you
can rewrite the patch to be applicable to there.
thanks,
Takashi
next prev parent reply other threads:[~2014-11-20 10:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <s5hr3x9qz5j.wl-tiwai@suse.de>
[not found] ` <6FAB7C47BCF00940BB0999A99BE3547A179FB004@RTITMBSV09.realtek.com.tw>
[not found] ` <s5h8ujgrext.wl-tiwai@suse.de>
2014-11-12 10:02 ` ALC1150 COEF Kailang
2014-11-12 10:32 ` Takashi Iwai
2014-11-19 7:13 ` HP mute led for ALC286 Kailang
2014-11-19 11:27 ` Takashi Iwai
2014-11-20 7:04 ` Kailang
2014-11-20 10:05 ` Takashi Iwai [this message]
2014-11-21 7:56 ` Kailang
2014-11-21 9:59 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5htx1uxk3l.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=kailang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox