From: Nirmoy <nirmodas@amd.com>
To: Alex Deucher <alexdeucher@gmail.com>, Nirmoy Das <nirmoy.das@amd.com>
Cc: "Deucher, Alexander" <alexander.deucher@amd.com>,
tiancyin <Tianci.Yin@amd.com>, Leo Liu <Leo.Liu@amd.com>,
Christian Koenig <christian.koenig@amd.com>,
amd-gfx list <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/1] drm/amdgpu: disable gpu-sched load balance for uvd
Date: Mon, 31 Aug 2020 16:59:56 +0200 [thread overview]
Message-ID: <0162c712-a0cd-78ee-0e87-6a612a1e81cb@amd.com> (raw)
In-Reply-To: <CADnq5_P=LUjg4GubYdFFSBM+aXpkxOJ6yoD_2iNLNMSe_Vyzrg@mail.gmail.com>
Hi Alex,
On 8/31/20 4:17 PM, Alex Deucher wrote:
> On Mon, Aug 31, 2020 at 6:41 AM Nirmoy Das <nirmoy.das@amd.com> wrote:
>> UVD dependent jobs should run on the same udv instance.
>> This patch disables gpu scheduler's load balancer for
>> a context which binds jobs from same the context to a udv
>> instance.
> typos: udv -> uvd
> With that fixed:
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>
> Does VCE need a similar fix? What about UVD_ENC?
I am not sure, can you please confirm this.
Nirmoy
>
> Alex
>
>
>> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
>> index 59032c26fc82..7cd398d25498 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
>> @@ -114,7 +114,9 @@ static int amdgpu_ctx_init_entity(struct amdgpu_ctx *ctx, u32 hw_ip,
>> scheds = adev->gpu_sched[hw_ip][hw_prio].sched;
>> num_scheds = adev->gpu_sched[hw_ip][hw_prio].num_scheds;
>>
>> - if (hw_ip == AMDGPU_HW_IP_VCN_ENC || hw_ip == AMDGPU_HW_IP_VCN_DEC) {
>> + if (hw_ip == AMDGPU_HW_IP_VCN_ENC ||
>> + hw_ip == AMDGPU_HW_IP_VCN_DEC ||
>> + hw_ip == AMDGPU_HW_IP_UVD) {
>> sched = drm_sched_pick_best(scheds, num_scheds);
>> scheds = &sched;
>> num_scheds = 1;
>> --
>> 2.28.0
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cnirmoy.das%40amd.com%7C6a3e9061d2f043783ea408d84db8a04e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637344802648079859&sdata=C7lkg97j7F6Kq1Vz7L79TbEDvfQm8QS3PUhdHfQ3Rcs%3D&reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-08-31 14:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 10:45 [PATCH 1/1] drm/amdgpu: disable gpu-sched load balance for uvd Nirmoy Das
2020-08-31 11:39 ` Christian König
2020-08-31 14:17 ` Alex Deucher
2020-08-31 14:59 ` Nirmoy [this message]
2020-08-31 17:39 ` Alex Deucher
2020-08-31 21:50 ` Leo Liu
2020-08-31 21:53 ` Alex Deucher
2020-08-31 22:17 ` Leo Liu
2020-09-01 7:07 ` Paul Menzel
2020-09-01 7:50 ` Nirmoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0162c712-a0cd-78ee-0e87-6a612a1e81cb@amd.com \
--to=nirmodas@amd.com \
--cc=Leo.Liu@amd.com \
--cc=Tianci.Yin@amd.com \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=nirmoy.das@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox