From: Leo Liu <leo.liu@amd.com>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Nirmoy <nirmodas@amd.com>, tiancyin <Tianci.Yin@amd.com>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
Nirmoy Das <nirmoy.das@amd.com>,
"Deucher, Alexander" <alexander.deucher@amd.com>,
Christian Koenig <christian.koenig@amd.com>
Subject: Re: [PATCH 1/1] drm/amdgpu: disable gpu-sched load balance for uvd
Date: Mon, 31 Aug 2020 18:17:55 -0400 [thread overview]
Message-ID: <e66fad81-8de5-75ec-f2fb-bdc36282d422@amd.com> (raw)
In-Reply-To: <CADnq5_NR8zY_aHPcZ39fGk_4-TFfWOPcHiT8wUCuxfjxYN=YNw@mail.gmail.com>
On 2020-08-31 5:53 p.m., Alex Deucher wrote:
> On Mon, Aug 31, 2020 at 5:50 PM Leo Liu <leo.liu@amd.com> wrote:
>>
>> On 2020-08-31 1:39 p.m., Alex Deucher wrote:
>>> On Mon, Aug 31, 2020 at 10:55 AM Nirmoy <nirmodas@amd.com> wrote:
>>>> Hi Alex,
>>>>
>>>> On 8/31/20 4:17 PM, Alex Deucher wrote:
>>>>> On Mon, Aug 31, 2020 at 6:41 AM Nirmoy Das <nirmoy.das@amd.com> wrote:
>>>>>> UVD dependent jobs should run on the same udv instance.
>>>>>> This patch disables gpu scheduler's load balancer for
>>>>>> a context which binds jobs from same the context to a udv
>>>>>> instance.
>>>>> typos: udv -> uvd
>>>>> With that fixed:
>>>>> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>>>>>
>>>>> Does VCE need a similar fix? What about UVD_ENC?
>>>> I am not sure, can you please confirm this.
>>> @Leo Liu can you confirm?
>> Vega20 have 2 UVDs and 1 VCE, so UVD_ENC(AMDGPU_HW_IP_UVD_ENC) should
>> need the same fix.
> What about other chips? Didn't CZ and tonga have two VCE instances?
> I guess any engine with hw contexts needs this.
Vega20 2 UVDs are identical and separated, exposed separated own set of
rings to driver, and have their own scheduler.
For CZ and Tonga, it got 2 VCE instances internally, and just expose one
set of rings to driver. i.e the instances will receive the IB thru the
same ring, and different IB structures will decide that one instance or
two instances will be used.
Regards,
Leo
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-08-31 22:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 10:45 [PATCH 1/1] drm/amdgpu: disable gpu-sched load balance for uvd Nirmoy Das
2020-08-31 11:39 ` Christian König
2020-08-31 14:17 ` Alex Deucher
2020-08-31 14:59 ` Nirmoy
2020-08-31 17:39 ` Alex Deucher
2020-08-31 21:50 ` Leo Liu
2020-08-31 21:53 ` Alex Deucher
2020-08-31 22:17 ` Leo Liu [this message]
2020-09-01 7:07 ` Paul Menzel
2020-09-01 7:50 ` Nirmoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e66fad81-8de5-75ec-f2fb-bdc36282d422@amd.com \
--to=leo.liu@amd.com \
--cc=Tianci.Yin@amd.com \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=nirmodas@amd.com \
--cc=nirmoy.das@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox