[PATCH] drm/amdgpu: remove unused parameter for va update

[PATCH] drm/amdgpu: remove unused parameter for va update

[Junwei Zhang]

Don't need validation list any more

Signed-off-by: Junwei Zhang <Jerry.Zhang@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
index 5fb156a..eff716d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
@@ -510,7 +510,6 @@ int amdgpu_gem_metadata_ioctl(struct drm_device *dev, void *data,
  * @adev: amdgpu_device pointer
  * @vm: vm to update
  * @bo_va: bo_va to update
- * @list: validation list
  * @operation: map, unmap or clear
  *
  * Update the bo_va directly after setting its address. Errors are not
@@ -519,7 +518,6 @@ int amdgpu_gem_metadata_ioctl(struct drm_device *dev, void *data,
 static void amdgpu_gem_va_update_vm(struct amdgpu_device *adev,
 				    struct amdgpu_vm *vm,
 				    struct amdgpu_bo_va *bo_va,
-				    struct list_head *list,
 				    uint32_t operation)
 {
 	int r;
@@ -673,7 +671,7 @@ int amdgpu_gem_va_ioctl(struct drm_device *dev, void *data,
 		break;
 	}
 	if (!r && !(args->flags & AMDGPU_VM_DELAY_UPDATE) && !amdgpu_vm_debug)
-		amdgpu_gem_va_update_vm(adev, &fpriv->vm, bo_va, &list,
+		amdgpu_gem_va_update_vm(adev, &fpriv->vm, bo_va,
 					args->operation);
 
 error_backoff:
-- 
1.9.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu: remove unused parameter for va update

[zhoucm1]

[-- Attachment #1.1: Type: text/plain, Size: 1561 bytes --]



On 2018年06月12日 14:01, Junwei Zhang wrote:
> Don't need validation list any more
>
> Signed-off-by: Junwei Zhang <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
Reviewed-by: Chunming Zhou <david1.zhou-5C7GfCeVMHo@public.gmane.org>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> index 5fb156a..eff716d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> @@ -510,7 +510,6 @@ int amdgpu_gem_metadata_ioctl(struct drm_device *dev, void *data,
>    * @adev: amdgpu_device pointer
>    * @vm: vm to update
>    * @bo_va: bo_va to update
> - * @list: validation list
>    * @operation: map, unmap or clear
>    *
>    * Update the bo_va directly after setting its address. Errors are not
> @@ -519,7 +518,6 @@ int amdgpu_gem_metadata_ioctl(struct drm_device *dev, void *data,
>   static void amdgpu_gem_va_update_vm(struct amdgpu_device *adev,
>   				    struct amdgpu_vm *vm,
>   				    struct amdgpu_bo_va *bo_va,
> -				    struct list_head *list,
>   				    uint32_t operation)
>   {
>   	int r;
> @@ -673,7 +671,7 @@ int amdgpu_gem_va_ioctl(struct drm_device *dev, void *data,
>   		break;
>   	}
>   	if (!r && !(args->flags & AMDGPU_VM_DELAY_UPDATE) && !amdgpu_vm_debug)
> -		amdgpu_gem_va_update_vm(adev, &fpriv->vm, bo_va, &list,
> +		amdgpu_gem_va_update_vm(adev, &fpriv->vm, bo_va,
>   					args->operation);
>   
>   error_backoff:


[-- Attachment #1.2: Type: text/html, Size: 2309 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu: remove unused parameter for va update

[Christian König]

[-- Attachment #1.1: Type: text/plain, Size: 1921 bytes --]

Am 12.06.2018 um 08:38 schrieb zhoucm1:
>
>
>
> On 2018年06月12日 14:01, Junwei Zhang wrote:
>> Don't need validation list any more
>>
>> Signed-off-by: Junwei Zhang<Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
> Reviewed-by: Chunming Zhou <david1.zhou-5C7GfCeVMHo@public.gmane.org>

Reviewed-by: Christian König <christian.koenig-5C7GfCeVMHo@public.gmane.org>

>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 4 +---
>>   1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
>> index 5fb156a..eff716d 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
>> @@ -510,7 +510,6 @@ int amdgpu_gem_metadata_ioctl(struct drm_device *dev, void *data,
>>    * @adev: amdgpu_device pointer
>>    * @vm: vm to update
>>    * @bo_va: bo_va to update
>> - * @list: validation list
>>    * @operation: map, unmap or clear
>>    *
>>    * Update the bo_va directly after setting its address. Errors are not
>> @@ -519,7 +518,6 @@ int amdgpu_gem_metadata_ioctl(struct drm_device *dev, void *data,
>>   static void amdgpu_gem_va_update_vm(struct amdgpu_device *adev,
>>   				    struct amdgpu_vm *vm,
>>   				    struct amdgpu_bo_va *bo_va,
>> -				    struct list_head *list,
>>   				    uint32_t operation)
>>   {
>>   	int r;
>> @@ -673,7 +671,7 @@ int amdgpu_gem_va_ioctl(struct drm_device *dev, void *data,
>>   		break;
>>   	}
>>   	if (!r && !(args->flags & AMDGPU_VM_DELAY_UPDATE) && !amdgpu_vm_debug)
>> -		amdgpu_gem_va_update_vm(adev, &fpriv->vm, bo_va, &list,
>> +		amdgpu_gem_va_update_vm(adev, &fpriv->vm, bo_va,
>>   					args->operation);
>>   
>>   error_backoff:
>
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


[-- Attachment #1.2: Type: text/html, Size: 3529 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx