AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Jesse Zhang <jesse.zhang@amd.com>, amd-gfx@lists.freedesktop.org
Cc: Alexander.Deucher@amd.com,
	Felix Kuehling <felix.kuehling@amd.com>,
	jonathan.kim@amd.com, Tim.Huang@amd.com
Subject: Re: [PATCH 7/8] drm/amdkfd: Comment out the unused variable use_static in pm_map_queues_v9
Date: Thu, 30 May 2024 16:12:23 +0200	[thread overview]
Message-ID: <15b6ed13-acd6-4363-90ea-e5e87a834a59@amd.com> (raw)
In-Reply-To: <20240530035012.2341573-1-jesse.zhang@amd.com>

Am 30.05.24 um 05:50 schrieb Jesse Zhang:
> To fix the warning about unused value, comment out the variable use_static.

Commenting out variables with // will just get you another warning from 
checkpatch.

Christian.

>
> Signed-off-by: Jesse Zhang <Jesse.Zhang@amd.com>
> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c
> index 8ee2bedd301a..c09476273f73 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c
> @@ -244,7 +244,7 @@ static int pm_map_queues_v9(struct packet_manager *pm, uint32_t *buffer,
>   		break;
>   	case KFD_QUEUE_TYPE_SDMA:
>   	case KFD_QUEUE_TYPE_SDMA_XGMI:
> -		use_static = false; /* no static queues under SDMA */
> +		//use_static = false; /* no static queues under SDMA */
>   		if (q->properties.sdma_engine_id < 2 &&
>   		    !pm_use_ext_eng(q->device->kfd))
>   			packet->bitfields2.engine_sel = q->properties.sdma_engine_id +


  reply	other threads:[~2024-05-30 14:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-30  3:50 [PATCH 7/8] drm/amdkfd: Comment out the unused variable use_static in pm_map_queues_v9 Jesse Zhang
2024-05-30 14:12 ` Christian König [this message]
2024-05-30 20:51   ` Felix Kuehling
  -- strict thread matches above, loose matches on Subject: below --
2024-05-31  2:51 Jesse Zhang
2024-05-31 18:46 ` Felix Kuehling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15b6ed13-acd6-4363-90ea-e5e87a834a59@amd.com \
    --to=christian.koenig@amd.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Tim.Huang@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=felix.kuehling@amd.com \
    --cc=jesse.zhang@amd.com \
    --cc=jonathan.kim@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox