Re: [PATCH 7/8] drm/amdkfd: Comment out the unused variable use_static in pm_map_queues_v9

[Felix Kuehling <felix.kuehling@amd.com>]

On 2024-05-30 22:51, Jesse Zhang wrote:
> To fix the warning about unused value,
> remove the use_static and use the parameter is_static directly.
>
> Signed-off-by: Jesse Zhang <Jesse.Zhang@amd.com>
> Suggested-by: Felix Kuehling <felix.kuehling@amd.com>

Reviewed-by: Felix Kuehling <felix.kuehling@amd.com>


> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c
> index 8ee2bedd301a..00776f08351c 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c
> @@ -213,7 +213,6 @@ static int pm_map_queues_v9(struct packet_manager *pm, uint32_t *buffer,
>   		struct queue *q, bool is_static)
>   {
>   	struct pm4_mes_map_queues *packet;
> -	bool use_static = is_static;
>   
>   	packet = (struct pm4_mes_map_queues *)buffer;
>   	memset(buffer, 0, sizeof(struct pm4_mes_map_queues));
> @@ -234,7 +233,7 @@ static int pm_map_queues_v9(struct packet_manager *pm, uint32_t *buffer,
>   
>   	switch (q->properties.type) {
>   	case KFD_QUEUE_TYPE_COMPUTE:
> -		if (use_static)
> +		if (is_static)
>   			packet->bitfields2.queue_type =
>   		queue_type__mes_map_queues__normal_latency_static_queue_vi;
>   		break;
> @@ -244,7 +243,6 @@ static int pm_map_queues_v9(struct packet_manager *pm, uint32_t *buffer,
>   		break;
>   	case KFD_QUEUE_TYPE_SDMA:
>   	case KFD_QUEUE_TYPE_SDMA_XGMI:
> -		use_static = false; /* no static queues under SDMA */
>   		if (q->properties.sdma_engine_id < 2 &&
>   		    !pm_use_ext_eng(q->device->kfd))
>   			packet->bitfields2.engine_sel = q->properties.sdma_engine_id +