Re: [PATCH 7/8] drm/amdkfd: Comment out the unused variable use_static in pm_map_queues_v9

[Felix Kuehling <felix.kuehling@amd.com>]

On 2024-05-30 10:12, Christian König wrote:
> Am 30.05.24 um 05:50 schrieb Jesse Zhang:
>> To fix the warning about unused value, comment out the variable 
>> use_static.
>
> Commenting out variables with // will just get you another warning 
> from checkpatch.
>
> Christian.
>
>>
>> Signed-off-by: Jesse Zhang <Jesse.Zhang@amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c 
>> b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c
>> index 8ee2bedd301a..c09476273f73 100644
>> --- a/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c
>> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c
>> @@ -244,7 +244,7 @@ static int pm_map_queues_v9(struct packet_manager 
>> *pm, uint32_t *buffer,
>>           break;
>>       case KFD_QUEUE_TYPE_SDMA:
>>       case KFD_QUEUE_TYPE_SDMA_XGMI:
>> -        use_static = false; /* no static queues under SDMA */
>> +        //use_static = false; /* no static queues under SDMA */

I'd just remove this line, remove the use_static variable and use the 
parameter is_static directly under case KFD_QUEUE_TYPE_COMPUTE.

Regards,
   Felix


>>           if (q->properties.sdma_engine_id < 2 &&
>>               !pm_use_ext_eng(q->device->kfd))
>>               packet->bitfields2.engine_sel = 
>> q->properties.sdma_engine_id +
>