From: Huang Rui <ray.huang-5C7GfCeVMHo@public.gmane.org>
To: Felix Kuehling <felix.kuehling-5C7GfCeVMHo@public.gmane.org>
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PART1 PATCH 2/8] drm/amdgpu: add parse clock gating state
Date: Fri, 6 Jan 2017 14:19:57 +0800 [thread overview]
Message-ID: <20170106061956.GA31759@hr-amur2> (raw)
In-Reply-To: <b407dd74-16e2-8df3-0adb-2afa17bf8f13-5C7GfCeVMHo@public.gmane.org>
On Thu, Jan 05, 2017 at 11:33:38AM -0500, Felix Kuehling wrote:
> This could be done with much less code duplication:
>
> static const struct {
> u32 flag;
> const char *name;
> } clocks[] = {
> {AMD_CG_SUPPORT_GFX_MGCG, "Medium Grain Clock Gating"},
> {AMD_CG_SUPPORT_GFX_MGLS, "Medium Grain memory Light Sleep"},
> ...
> {0, NULL}
> };
>
> for (i = 0; clocks[i].flag; i++)
> seq_printf(m, "\t%s: %s\n",
> clocks[i].name,
> (flags & clocks[i].flag) ? "On" : "Off");
>
Looks better. Thank you.
Thanks,
Rui
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2017-01-06 6:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 13:49 [PART1 PATCH 0/8] Introduce a method to get clock gating status dynamically Huang Rui
[not found] ` <1483624193-20897-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org>
2017-01-05 13:49 ` [PART1 PATCH 1/8] drm/amdgpu: introduce an interface " Huang Rui
2017-01-05 13:49 ` [PART1 PATCH 2/8] drm/amdgpu: add parse clock gating state Huang Rui
[not found] ` <1483624193-20897-3-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org>
2017-01-05 16:33 ` Felix Kuehling
[not found] ` <b407dd74-16e2-8df3-0adb-2afa17bf8f13-5C7GfCeVMHo@public.gmane.org>
2017-01-06 6:19 ` Huang Rui [this message]
2017-01-05 16:34 ` William Lewis
[not found] ` <BN6PR17MB0913FDE2AC51D02FD9730FD1C8600-jOV4XOBZ6Mu/5fi7T5v52H+GY4YGzQ7gvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-01-06 6:21 ` Huang Rui
2017-01-05 13:49 ` [PART1 PATCH 3/8] drm/amdgpu: add clockgating_state method for gfx v8 Huang Rui
2017-01-05 13:49 ` [PART1 PATCH 4/8] drm/amdgpu: add clockgating_state method for gmc v8 Huang Rui
2017-01-05 13:49 ` [PART1 PATCH 5/8] drm/amdgpu: add clockgating_state method for sdma v3 Huang Rui
2017-01-05 13:49 ` [PART1 PATCH 6/8] drm/amdgpu: add clockgating_state method for vi common Huang Rui
2017-01-05 13:49 ` [PART1 PATCH 7/8] drm/amdgpu: add clockgating_state method for uvd v5&v6 Huang Rui
2017-01-05 13:49 ` [PART1 PATCH 8/8] drm/amdgpu: add clockgating_state method for vce v3 Huang Rui
2017-01-05 15:40 ` [PART1 PATCH 0/8] Introduce a method to get clock gating status dynamically Deucher, Alexander
[not found] ` <BN6PR12MB1652B0E3AD8F9252CE089FA0F7600-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-01-05 15:51 ` StDenis, Tom
2017-01-06 6:12 ` Huang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170106061956.GA31759@hr-amur2 \
--to=ray.huang-5c7gfcevmho@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=felix.kuehling-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox