From: Daniel Vetter <daniel@ffwll.ch>
To: "Michel Dänzer" <michel@daenzer.net>
Cc: Leo Li <sunpeng.li@amd.com>,
dri-devel@lists.freedesktop.org,
Pekka Paalanen <ppaalanen@gmail.com>,
amd-gfx@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
"Kazlauskas, Nicholas" <nicholas.kazlauskas@amd.com>
Subject: Re: [PATCH] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is
Date: Tue, 1 Sep 2020 12:34:01 +0200 [thread overview]
Message-ID: <20200901103401.GA2352366@phenom.ffwll.local> (raw)
In-Reply-To: <52d558d2-3277-716f-6386-b8b90e6f41d3@daenzer.net>
On Tue, Sep 01, 2020 at 10:56:42AM +0200, Michel Dänzer wrote:
> On 2020-09-01 9:57 a.m., Daniel Vetter wrote:
> > On Tue, Aug 25, 2020 at 04:55:28PM +0200, Michel Dänzer wrote:
> >> On 2020-08-24 9:43 a.m., Pekka Paalanen wrote:
> >>
> >>> Sounds like the helpers you refer to are inadequate for your case.
> >>> Can't you fix the helpers in the long run and land this patch as an
> >>> immediate fix?
> >>
> >> I'd rather leave working on those helpers to KMS developers. :)
> >
> > I thought the issue is the rmfb ioctl trickery, which has this assumption
> > fully backed in. The wiggle room in there for semantic changes is iirc
> > pretty much nil, it took us a pile of patches to just get to the current
> > state. So it's not helper code, it's core legacy ioctl code for atomic
> > drivers.
>
> My bad. Should I respin with an amended commit log?
Yeah if it's not yet merged then I think would be good to clarify that
this assumption is baked into rmfb, and that together with the assumption
the the legacy cursor ioctls just work we have fallout.
If (and hey I've been on vacations for 2 weeks, so good chances I remebers
this all wrong) this is indeed what we discussed a few weeks ago.
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-09-01 10:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 16:57 [PATCH] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is Michel Dänzer
2020-08-21 18:07 ` Kazlauskas, Nicholas
2020-08-22 9:59 ` Michel Dänzer
2020-08-24 7:43 ` Pekka Paalanen
2020-08-25 14:55 ` Michel Dänzer
2020-09-01 7:57 ` Daniel Vetter
2020-09-01 8:56 ` Michel Dänzer
2020-09-01 10:34 ` Daniel Vetter [this message]
2020-08-25 16:58 ` Kazlauskas, Nicholas
2020-08-26 8:24 ` Pekka Paalanen
2020-08-26 8:58 ` Michel Dänzer
2020-09-01 7:54 ` Daniel Vetter
2020-09-01 13:58 ` Harry Wentland
2020-09-02 7:02 ` Daniel Vetter
2020-09-02 9:26 ` Michel Dänzer
2020-09-04 10:43 ` [PATCH v2] " Michel Dänzer
2020-09-07 7:57 ` Daniel Vetter
2020-09-14 7:52 ` Michel Dänzer
2020-09-14 14:37 ` Kazlauskas, Nicholas
2020-09-14 15:22 ` Michel Dänzer
2020-09-14 15:33 ` Kazlauskas, Nicholas
2020-09-14 15:44 ` Michel Dänzer
2020-09-15 21:00 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901103401.GA2352366@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=michel@daenzer.net \
--cc=nicholas.kazlauskas@amd.com \
--cc=ppaalanen@gmail.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox