* [PATCH 1/3] drm/amdgpu/gmc9: re-enable AGP
@ 2024-01-03 21:55 Alex Deucher
2024-01-03 21:55 ` [PATCH 2/3] drm/amdgpu/gmc10: " Alex Deucher
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Alex Deucher @ 2024-01-03 21:55 UTC (permalink / raw)
To: amd-gfx; +Cc: Alex Deucher
It should be fixed with
commit ca0b006939f9 ("drm/amdgpu: fix AGP addressing when GART is not at 0")
so re-enable it.
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
index 9bff72356a37..de961bedad3b 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
@@ -1632,7 +1632,7 @@ static void gmc_v9_0_vram_gtt_location(struct amdgpu_device *adev,
} else {
amdgpu_gmc_vram_location(adev, mc, base);
amdgpu_gmc_gart_location(adev, mc, AMDGPU_GART_PLACEMENT_BEST_FIT);
- if (!amdgpu_sriov_vf(adev) && (amdgpu_agp == 1))
+ if (!amdgpu_sriov_vf(adev) && (amdgpu_agp != 0))
amdgpu_gmc_agp_location(adev, mc);
}
/* base offset of vram pages */
--
2.42.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/3] drm/amdgpu/gmc10: re-enable AGP
2024-01-03 21:55 [PATCH 1/3] drm/amdgpu/gmc9: re-enable AGP Alex Deucher
@ 2024-01-03 21:55 ` Alex Deucher
2024-01-03 21:55 ` [PATCH 3/3] drm/amdgpu/gmc11: " Alex Deucher
2024-01-08 8:17 ` [PATCH 1/3] drm/amdgpu/gmc9: " Christian König
2 siblings, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2024-01-03 21:55 UTC (permalink / raw)
To: amd-gfx; +Cc: Alex Deucher
It should be fixed with
commit ca0b006939f9 ("drm/amdgpu: fix AGP addressing when GART is not at 0")
so re-enable it.
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
index db89d13bd80d..bb04cb8c80f2 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
@@ -676,7 +676,7 @@ static void gmc_v10_0_vram_gtt_location(struct amdgpu_device *adev,
amdgpu_gmc_set_agp_default(adev, mc);
amdgpu_gmc_vram_location(adev, &adev->gmc, base);
amdgpu_gmc_gart_location(adev, mc, AMDGPU_GART_PLACEMENT_BEST_FIT);
- if (!amdgpu_sriov_vf(adev) && (amdgpu_agp == 1))
+ if (!amdgpu_sriov_vf(adev) && (amdgpu_agp != 0))
amdgpu_gmc_agp_location(adev, mc);
/* base offset of vram pages */
--
2.42.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 3/3] drm/amdgpu/gmc11: re-enable AGP
2024-01-03 21:55 [PATCH 1/3] drm/amdgpu/gmc9: re-enable AGP Alex Deucher
2024-01-03 21:55 ` [PATCH 2/3] drm/amdgpu/gmc10: " Alex Deucher
@ 2024-01-03 21:55 ` Alex Deucher
2024-01-04 14:22 ` Zhang, Hawking
2024-01-08 8:17 ` [PATCH 1/3] drm/amdgpu/gmc9: " Christian König
2 siblings, 1 reply; 5+ messages in thread
From: Alex Deucher @ 2024-01-03 21:55 UTC (permalink / raw)
To: amd-gfx; +Cc: Alex Deucher
It should be fixed with
commit ca0b006939f9 ("drm/amdgpu: fix AGP addressing when GART is not at 0")
so re-enable it.
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
index 6c68135cac9f..906f23d13975 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
@@ -643,7 +643,7 @@ static void gmc_v11_0_vram_gtt_location(struct amdgpu_device *adev,
amdgpu_gmc_gart_location(adev, mc, AMDGPU_GART_PLACEMENT_HIGH);
if (!amdgpu_sriov_vf(adev) &&
(amdgpu_ip_version(adev, GC_HWIP, 0) < IP_VERSION(11, 5, 0)) &&
- (amdgpu_agp == 1))
+ (amdgpu_agp != 0))
amdgpu_gmc_agp_location(adev, mc);
/* base offset of vram pages */
--
2.42.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* RE: [PATCH 3/3] drm/amdgpu/gmc11: re-enable AGP
2024-01-03 21:55 ` [PATCH 3/3] drm/amdgpu/gmc11: " Alex Deucher
@ 2024-01-04 14:22 ` Zhang, Hawking
0 siblings, 0 replies; 5+ messages in thread
From: Zhang, Hawking @ 2024-01-04 14:22 UTC (permalink / raw)
To: Deucher, Alexander, amd-gfx@lists.freedesktop.org; +Cc: Deucher, Alexander
[AMD Official Use Only - General]
Series is
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Regards,
Hawking
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Alex Deucher
Sent: Thursday, January 4, 2024 05:56
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>
Subject: [PATCH 3/3] drm/amdgpu/gmc11: re-enable AGP
It should be fixed with
commit ca0b006939f9 ("drm/amdgpu: fix AGP addressing when GART is not at 0") so re-enable it.
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
index 6c68135cac9f..906f23d13975 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
@@ -643,7 +643,7 @@ static void gmc_v11_0_vram_gtt_location(struct amdgpu_device *adev,
amdgpu_gmc_gart_location(adev, mc, AMDGPU_GART_PLACEMENT_HIGH);
if (!amdgpu_sriov_vf(adev) &&
(amdgpu_ip_version(adev, GC_HWIP, 0) < IP_VERSION(11, 5, 0)) &&
- (amdgpu_agp == 1))
+ (amdgpu_agp != 0))
amdgpu_gmc_agp_location(adev, mc);
/* base offset of vram pages */
--
2.42.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3] drm/amdgpu/gmc9: re-enable AGP
2024-01-03 21:55 [PATCH 1/3] drm/amdgpu/gmc9: re-enable AGP Alex Deucher
2024-01-03 21:55 ` [PATCH 2/3] drm/amdgpu/gmc10: " Alex Deucher
2024-01-03 21:55 ` [PATCH 3/3] drm/amdgpu/gmc11: " Alex Deucher
@ 2024-01-08 8:17 ` Christian König
2 siblings, 0 replies; 5+ messages in thread
From: Christian König @ 2024-01-08 8:17 UTC (permalink / raw)
To: Alex Deucher, amd-gfx
Am 03.01.24 um 22:55 schrieb Alex Deucher:
> It should be fixed with
> commit ca0b006939f9 ("drm/amdgpu: fix AGP addressing when GART is not at 0")
> so re-enable it.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com> for the series.
> ---
> drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> index 9bff72356a37..de961bedad3b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> @@ -1632,7 +1632,7 @@ static void gmc_v9_0_vram_gtt_location(struct amdgpu_device *adev,
> } else {
> amdgpu_gmc_vram_location(adev, mc, base);
> amdgpu_gmc_gart_location(adev, mc, AMDGPU_GART_PLACEMENT_BEST_FIT);
> - if (!amdgpu_sriov_vf(adev) && (amdgpu_agp == 1))
> + if (!amdgpu_sriov_vf(adev) && (amdgpu_agp != 0))
> amdgpu_gmc_agp_location(adev, mc);
> }
> /* base offset of vram pages */
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-01-08 8:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-03 21:55 [PATCH 1/3] drm/amdgpu/gmc9: re-enable AGP Alex Deucher
2024-01-03 21:55 ` [PATCH 2/3] drm/amdgpu/gmc10: " Alex Deucher
2024-01-03 21:55 ` [PATCH 3/3] drm/amdgpu/gmc11: " Alex Deucher
2024-01-04 14:22 ` Zhang, Hawking
2024-01-08 8:17 ` [PATCH 1/3] drm/amdgpu/gmc9: " Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox