* [PATCH] drm/amdkfd: Fix improper NULL termination of queue restore SMI event string
@ 2025-11-20 19:12 Brian Kocoloski
0 siblings, 0 replies; 3+ messages in thread
From: Brian Kocoloski @ 2025-11-20 19:12 UTC (permalink / raw)
To: amd-gfx; +Cc: Philip.Yang, Brian Kocoloski
Pass character "0" rather than NULL terminator to properly format
queue restoration SMI events. Currently, the NULL terminator precedes
the newline character that is intended to delineate separate events
in the SMI event buffer, which can break userspace parsers.
---
drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c b/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
index a499449fcb06..d2bc169e84b0 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
@@ -312,7 +312,7 @@ void kfd_smi_event_queue_restore(struct kfd_node *node, pid_t pid)
{
kfd_smi_event_add(pid, node, KFD_SMI_EVENT_QUEUE_RESTORE,
KFD_EVENT_FMT_QUEUE_RESTORE(ktime_get_boottime_ns(), pid,
- node->id, 0));
+ node->id, '0'));
}
void kfd_smi_event_queue_restore_rescheduled(struct mm_struct *mm)
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] drm/amdkfd: Fix improper NULL termination of queue restore SMI event string
@ 2025-12-01 21:00 Brian Kocoloski
2025-12-01 21:46 ` Philip Yang
0 siblings, 1 reply; 3+ messages in thread
From: Brian Kocoloski @ 2025-12-01 21:00 UTC (permalink / raw)
To: amd-gfx; +Cc: Philip.Yang, Brian Kocoloski, Brian Kocoloski
From: Brian Kocoloski <bkocolos@amd.com>
Pass character "0" rather than NULL terminator to properly format
queue restoration SMI events. Currently, the NULL terminator precedes
the newline character that is intended to delineate separate events
in the SMI event buffer, which can break userspace parsers.
Signed-off-by: Brian Kocoloski <brian.kocoloski@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c b/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
index a499449fcb06..d2bc169e84b0 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
@@ -312,7 +312,7 @@ void kfd_smi_event_queue_restore(struct kfd_node *node, pid_t pid)
{
kfd_smi_event_add(pid, node, KFD_SMI_EVENT_QUEUE_RESTORE,
KFD_EVENT_FMT_QUEUE_RESTORE(ktime_get_boottime_ns(), pid,
- node->id, 0));
+ node->id, '0'));
}
void kfd_smi_event_queue_restore_rescheduled(struct mm_struct *mm)
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/amdkfd: Fix improper NULL termination of queue restore SMI event string
2025-12-01 21:00 Brian Kocoloski
@ 2025-12-01 21:46 ` Philip Yang
0 siblings, 0 replies; 3+ messages in thread
From: Philip Yang @ 2025-12-01 21:46 UTC (permalink / raw)
To: Brian Kocoloski, amd-gfx; +Cc: Philip.Yang, Brian Kocoloski
On 2025-12-01 16:00, Brian Kocoloski wrote:
> From: Brian Kocoloski <bkocolos@amd.com>
>
> Pass character "0" rather than NULL terminator to properly format
> queue restoration SMI events. Currently, the NULL terminator precedes
> the newline character that is intended to delineate separate events
> in the SMI event buffer, which can break userspace parsers.
>
> Signed-off-by: Brian Kocoloski <brian.kocoloski@amd.com>
Reviewed-by: Philip Yang <Philip.Yang@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c b/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
> index a499449fcb06..d2bc169e84b0 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
> @@ -312,7 +312,7 @@ void kfd_smi_event_queue_restore(struct kfd_node *node, pid_t pid)
> {
> kfd_smi_event_add(pid, node, KFD_SMI_EVENT_QUEUE_RESTORE,
> KFD_EVENT_FMT_QUEUE_RESTORE(ktime_get_boottime_ns(), pid,
> - node->id, 0));
> + node->id, '0'));
> }
>
> void kfd_smi_event_queue_restore_rescheduled(struct mm_struct *mm)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-01 21:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-20 19:12 [PATCH] drm/amdkfd: Fix improper NULL termination of queue restore SMI event string Brian Kocoloski
-- strict thread matches above, loose matches on Subject: below --
2025-12-01 21:00 Brian Kocoloski
2025-12-01 21:46 ` Philip Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox