From: Zhu Lingshan <lingshan.zhu@amd.com>
To: <Alexander.Deucher@amd.com>, <felix.kuehling@amd.com>
Cc: <Ray.Huang@amd.com>, <amd-gfx@lists.freedesktop.org>,
Zhu Lingshan <lingshan.zhu@amd.com>
Subject: [RFC 09/10] drm/amdgpu: implement device PMC handler
Date: Tue, 22 Sep 2026 17:34:35 +0800 [thread overview]
Message-ID: <20260922093436.596947-10-lingshan.zhu@amd.com> (raw)
In-Reply-To: <20260922093436.596947-1-lingshan.zhu@amd.com>
This commit implements device PMC handler
Signed-off-by: Zhu Lingshan <lingshan.zhu@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_profiler.c | 6 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 68 ++++++++++++++++++++
drivers/gpu/drm/amd/amdgpu/amdgpu_userq.h | 2 +
3 files changed, 75 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_profiler.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_profiler.c
index 254fb8d77d80..f40c848331a0 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_profiler.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_profiler.c
@@ -95,7 +95,11 @@ int amdgpu_profiler_set_perfcount(struct amdgpu_device *adev,
mutex_unlock(&adev->pmc_profiler.lock);
- return ret;
+ if (ret)
+ return ret;
+
+ /* no racings because the device was reserved by pmc_profiler.owner */
+ return amdgpu_set_perfcount(adev, enable);
}
static int amdgpu_profiler_check_access(struct drm_device *dev)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
index 45e4225c0201..8a1f0841e8e7 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
@@ -1541,6 +1541,74 @@ int amdgpu_userq_resume(struct amdgpu_device *adev)
return 0;
}
+static void amdgpu_userq_set_perfcount(struct amdgpu_usermode_queue *queue,
+ bool enable)
+{
+ struct amdgpu_userq_mgr *uq_mgr = queue->userq_mgr;
+ struct amdgpu_device *adev = uq_mgr->adev;
+ struct amdgpu_mqd *mqd_funcs = &adev->mqds[queue->queue_type];
+ int r;
+
+ /* IP does not support PMC */
+ if (!mqd_funcs->set_mqd_perfcount)
+ return;
+
+ mutex_lock(&uq_mgr->userq_mutex);
+ queue->userq_prop->perfcount_enable = enable;
+
+ if (queue->state == AMDGPU_USERQ_STATE_MAPPED) {
+ r = amdgpu_userq_unmap_helper(queue);
+ if (r) {
+ drm_file_err(uq_mgr->file,
+ "Failed to unmap user queue %llu when updating PMC\n",
+ queue->doorbell_index);
+ } else {
+ mqd_funcs->set_mqd_perfcount(queue->mqd.cpu_ptr,
+ queue->userq_prop);
+ r = amdgpu_userq_map_helper(queue);
+ if (r)
+ drm_file_err(uq_mgr->file,
+ "Failed to map user queue %llu when updating PMC\n",
+ queue->doorbell_index);
+ }
+ } else {
+ drm_dbg_driver(adev_to_drm(adev),
+ "user queue %llu is in state %d, skip it when updating PMC\n",
+ queue->doorbell_index, queue->state);
+ }
+
+ mutex_unlock(&uq_mgr->userq_mutex);
+}
+
+/* set perfcount for every queue on the device. */
+int amdgpu_set_perfcount(struct amdgpu_device *adev, bool enable)
+{
+ struct amdgpu_usermode_queue *queue;
+ unsigned long queue_id = 0;
+
+ if (amdgpu_in_reset(adev))
+ return -EIO;
+
+ if (adev->userq_halt_for_enforce_isolation)
+ return -EAGAIN;
+
+ queue = amdgpu_userq_xa_find(&adev->userq_doorbell_xa, &queue_id);
+ while (queue) {
+ amdgpu_userq_set_perfcount(queue, enable);
+ amdgpu_userq_put(queue);
+
+ if (queue_id == ULONG_MAX)
+ break;
+
+ /* find next queue */
+ queue_id++;
+ queue = amdgpu_userq_xa_find(&adev->userq_doorbell_xa,
+ &queue_id);
+ }
+
+ return 0;
+}
+
int amdgpu_userq_stop_sched_for_enforce_isolation(struct amdgpu_device *adev,
u32 idx)
{
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.h
index 4c9a71b56792..2fcde5955d4d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.h
@@ -189,6 +189,8 @@ int amdgpu_userq_stop_sched_for_enforce_isolation(struct amdgpu_device *adev,
u32 idx);
int amdgpu_userq_start_sched_for_enforce_isolation(struct amdgpu_device *adev,
u32 idx);
+
+int amdgpu_set_perfcount(struct amdgpu_device *adev, bool enable);
void amdgpu_userq_reset_work(struct work_struct *work);
void amdgpu_userq_pre_reset(struct amdgpu_device *adev);
int amdgpu_userq_post_reset(struct amdgpu_device *adev, bool vram_lost);
--
2.55.0
next prev parent reply other threads:[~2026-09-22 9:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 9:34 [RFC 00/10] amdgpu: implement Performance Monitor Counter support Zhu Lingshan
2026-09-22 9:34 ` [RFC 01/10] drm/amdgpu: implement PMC ioctl framework Zhu Lingshan
2026-09-23 14:17 ` James Zhu
2026-09-24 3:38 ` Zhu, Lingshan
2026-09-24 15:49 ` James Zhu
2026-10-08 7:59 ` Zhu, Lingshan
2026-09-22 9:34 ` [RFC 02/10] drm/amdgpu: add device-wide PMC config Zhu Lingshan
2026-09-23 14:13 ` James Zhu
2026-09-24 3:23 ` Zhu, Lingshan
2026-09-24 15:40 ` James Zhu
2026-10-08 7:50 ` Zhu, Lingshan
2026-09-22 9:34 ` [RFC 03/10] drm/amdgpu: introduce PMC ioctl handler Zhu Lingshan
2026-09-22 9:34 ` [RFC 04/10] drm/amdgpu: implement reservation mechanism for PMC Zhu Lingshan
2026-09-22 9:34 ` [RFC 05/10] drm/amdgpu: set device-wide PMC enablement indicator Zhu Lingshan
2026-09-22 9:34 ` [RFC 06/10] drm/amdgpu: GFX11: set mqd->perfcount from mqd_prop Zhu Lingshan
2026-09-22 9:34 ` [RFC 07/10] drm/amdgpu: GFX12: " Zhu Lingshan
2026-09-22 9:34 ` [RFC 08/10] drm/amdgpu: GFX12.1: " Zhu Lingshan
2026-09-22 9:34 ` Zhu Lingshan [this message]
2026-09-22 9:34 ` [RFC 10/10] drm/amdgpu: set userq perf state before publish it Zhu Lingshan
2026-09-23 14:02 ` [RFC 00/10] amdgpu: implement Performance Monitor Counter support James Zhu
2026-09-23 15:02 ` Welton, Benjamin
2026-09-23 15:11 ` James Zhu
2026-09-24 3:40 ` Zhu, Lingshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922093436.596947-10-lingshan.zhu@amd.com \
--to=lingshan.zhu@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Ray.Huang@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=felix.kuehling@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox