* [PATCH] drm/amd/pm set pp_dpm_*clk as read only for SRIOV one VF mode
@ 2024-03-15 6:31 Lin.Cao
2024-03-19 7:09 ` JingWen Chen
0 siblings, 1 reply; 2+ messages in thread
From: Lin.Cao @ 2024-03-15 6:31 UTC (permalink / raw)
To: amd-gfx; +Cc: haijun.chang, Christian König, zhenguo.yin, lincao12
pp_dpm_*clk should be set as read only for SRIOV one VF mode, remove
S_IWUGO flag and _store function of these debugfs in one VF mode.
Signed-off-by: Lin.Cao <lincao12@amd.com>
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
index efc631bddf4a..2883a1d873ab 100644
--- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
@@ -2367,7 +2367,15 @@ static int default_attr_update(struct amdgpu_device *adev, struct amdgpu_device_
}
/* setting should not be allowed from VF if not in one VF mode */
- if (amdgpu_sriov_vf(adev) && !amdgpu_sriov_is_pp_one_vf(adev)) {
+ if (amdgpu_sriov_vf(adev) && (!amdgpu_sriov_is_pp_one_vf(adev) ||
+ DEVICE_ATTR_IS(pp_dpm_sclk) ||
+ DEVICE_ATTR_IS(pp_dpm_mclk) ||
+ DEVICE_ATTR_IS(pp_dpm_socclk) ||
+ DEVICE_ATTR_IS(pp_dpm_fclk) ||
+ DEVICE_ATTR_IS(pp_dpm_vclk) ||
+ DEVICE_ATTR_IS(pp_dpm_vclk1) ||
+ DEVICE_ATTR_IS(pp_dpm_dclk) ||
+ DEVICE_ATTR_IS(pp_dpm_dclk1))) {
dev_attr->attr.mode &= ~S_IWUGO;
dev_attr->store = NULL;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm/amd/pm set pp_dpm_*clk as read only for SRIOV one VF mode
2024-03-15 6:31 [PATCH] drm/amd/pm set pp_dpm_*clk as read only for SRIOV one VF mode Lin.Cao
@ 2024-03-19 7:09 ` JingWen Chen
0 siblings, 0 replies; 2+ messages in thread
From: JingWen Chen @ 2024-03-19 7:09 UTC (permalink / raw)
To: amd-gfx
Acked-by: Jingwen Chen <Jingwen.Chen2@amd.com>
On 2024/3/15 14:31, Lin.Cao wrote:
> pp_dpm_*clk should be set as read only for SRIOV one VF mode, remove
> S_IWUGO flag and _store function of these debugfs in one VF mode.
>
> Signed-off-by: Lin.Cao <lincao12@amd.com>
> ---
> drivers/gpu/drm/amd/pm/amdgpu_pm.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index efc631bddf4a..2883a1d873ab 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -2367,7 +2367,15 @@ static int default_attr_update(struct amdgpu_device *adev, struct amdgpu_device_
> }
>
> /* setting should not be allowed from VF if not in one VF mode */
> - if (amdgpu_sriov_vf(adev) && !amdgpu_sriov_is_pp_one_vf(adev)) {
> + if (amdgpu_sriov_vf(adev) && (!amdgpu_sriov_is_pp_one_vf(adev) ||
> + DEVICE_ATTR_IS(pp_dpm_sclk) ||
> + DEVICE_ATTR_IS(pp_dpm_mclk) ||
> + DEVICE_ATTR_IS(pp_dpm_socclk) ||
> + DEVICE_ATTR_IS(pp_dpm_fclk) ||
> + DEVICE_ATTR_IS(pp_dpm_vclk) ||
> + DEVICE_ATTR_IS(pp_dpm_vclk1) ||
> + DEVICE_ATTR_IS(pp_dpm_dclk) ||
> + DEVICE_ATTR_IS(pp_dpm_dclk1))) {
> dev_attr->attr.mode &= ~S_IWUGO;
> dev_attr->store = NULL;
> }
--
Best Regards,
JingWen Chen
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-19 7:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-15 6:31 [PATCH] drm/amd/pm set pp_dpm_*clk as read only for SRIOV one VF mode Lin.Cao
2024-03-19 7:09 ` JingWen Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox