AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu: add sriov microcode init for MP0 15.0.8
@ 2026-09-24  7:01 YuBiao Wang
  2026-09-29  2:53 ` YuBiao Wang
  2026-09-29  5:27 ` Lazar, Lijo
  0 siblings, 2 replies; 3+ messages in thread
From: YuBiao Wang @ 2026-09-24  7:01 UTC (permalink / raw)
  To: amd-gfx; +Cc: Alexander.Deucher, Hawking.Zhang, Lijo.Lazar

psp_init_sriov_microcode() returns -EINVAL for an MP0 version it does not
know about, so PSP init fails on a VF before any firmware is loaded.

Add the MP0 15.0.8 case. It needs neither cap nor ta microcode, only the
autoload trigger: on a VF psp_load_non_psp_fw() starts RLC autoload once it
has handed virt.autoload_ucode_id to PSP, and on this generation IMU comes
from the IFWI and is skipped, which leaves MES1 DATA as the last firmware
PSP receives.

Signed-off-by: YuBiao Wang <YuBiao.Wang@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
index 66eb2f34cc0d..453aef42556d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
@@ -173,6 +173,9 @@ static int psp_init_sriov_microcode(struct psp_context *psp)
 	case IP_VERSION(13, 0, 12):
 		ret = psp_init_ta_microcode(psp, ucode_prefix);
 		break;
+	case IP_VERSION(15, 0, 8):
+		adev->virt.autoload_ucode_id = AMDGPU_UCODE_ID_CP_MES1_DATA;
+		break;
 	default:
 		return -EINVAL;
 	}
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/amdgpu: add sriov microcode init for MP0 15.0.8
  2026-09-24  7:01 [PATCH] drm/amdgpu: add sriov microcode init for MP0 15.0.8 YuBiao Wang
@ 2026-09-29  2:53 ` YuBiao Wang
  2026-09-29  5:27 ` Lazar, Lijo
  1 sibling, 0 replies; 3+ messages in thread
From: YuBiao Wang @ 2026-09-29  2:53 UTC (permalink / raw)
  To: amd-gfx; +Cc: Alexander.Deucher, Hawking.Zhang, Lijo.Lazar

Ping.

On Thu, Sep 24, 2026 at 07:01:21 UTC, YuBiao Wang wrote:
> psp_init_sriov_microcode() returns -EINVAL for an MP0 version it does not
> know about, so PSP init fails on a VF before any firmware is loaded.
>
> Add the MP0 15.0.8 case. It needs neither cap nor ta microcode, only the
> autoload trigger: on a VF psp_load_non_psp_fw() starts RLC autoload once it
> has handed virt.autoload_ucode_id to PSP, and on this generation IMU comes
> from the IFWI and is skipped, which leaves MES1 DATA as the last firmware
> PSP receives.
>
> Signed-off-by: YuBiao Wang <YuBiao.Wang@amd.com>
> Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> index 66eb2f34cc0d..453aef42556d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> @@ -173,6 +173,9 @@ static int psp_init_sriov_microcode(struct psp_context *psp)
>  	case IP_VERSION(13, 0, 12):
>  		ret = psp_init_ta_microcode(psp, ucode_prefix);
>  		break;
> +	case IP_VERSION(15, 0, 8):
> +		adev->virt.autoload_ucode_id = AMDGPU_UCODE_ID_CP_MES1_DATA;
> +		break;
>  	default:
>  		return -EINVAL;
>  	}

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/amdgpu: add sriov microcode init for MP0 15.0.8
  2026-09-24  7:01 [PATCH] drm/amdgpu: add sriov microcode init for MP0 15.0.8 YuBiao Wang
  2026-09-29  2:53 ` YuBiao Wang
@ 2026-09-29  5:27 ` Lazar, Lijo
  1 sibling, 0 replies; 3+ messages in thread
From: Lazar, Lijo @ 2026-09-29  5:27 UTC (permalink / raw)
  To: YuBiao Wang, amd-gfx; +Cc: Alexander.Deucher, Hawking.Zhang



On 24-Sep-26 12:31 PM, YuBiao Wang wrote:
> psp_init_sriov_microcode() returns -EINVAL for an MP0 version it does not
> know about, so PSP init fails on a VF before any firmware is loaded.
> 
> Add the MP0 15.0.8 case. It needs neither cap nor ta microcode, only the
> autoload trigger: on a VF psp_load_non_psp_fw() starts RLC autoload once it
> has handed virt.autoload_ucode_id to PSP, and on this generation IMU comes
> from the IFWI and is skipped, which leaves MES1 DATA as the last firmware
> PSP receives.
> 
> Signed-off-by: YuBiao Wang <YuBiao.Wang@amd.com>

Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>

Thanks,
Lijo

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> index 66eb2f34cc0d..453aef42556d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> @@ -173,6 +173,9 @@ static int psp_init_sriov_microcode(struct psp_context *psp)
>   	case IP_VERSION(13, 0, 12):
>   		ret = psp_init_ta_microcode(psp, ucode_prefix);
>   		break;
> +	case IP_VERSION(15, 0, 8):
> +		adev->virt.autoload_ucode_id = AMDGPU_UCODE_ID_CP_MES1_DATA;
> +		break;
>   	default:
>   		return -EINVAL;
>   	}


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-29  5:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-24  7:01 [PATCH] drm/amdgpu: add sriov microcode init for MP0 15.0.8 YuBiao Wang
2026-09-29  2:53 ` YuBiao Wang
2026-09-29  5:27 ` Lazar, Lijo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox