From: "Christian König" <christian.koenig@amd.com>
To: Huang Rui <ray.huang@amd.com>, amd-gfx@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>,
Leo Liu <leo.liu@amd.com>, AnZhong Huang <AnZhong.Huang@amd.com>,
Aaron Liu <aaron.liu@amd.com>
Subject: Re: [PATCH 00/12] drm/amdgpu: add register distance
Date: Mon, 6 Jul 2020 12:39:32 +0200 [thread overview]
Message-ID: <a56c76d4-71bc-3a70-c8bc-5584104f6963@amd.com> (raw)
In-Reply-To: <20200706050509.714975-1-ray.huang@amd.com>
Am 06.07.20 um 07:04 schrieb Huang Rui:
> During IP block updates in some asic, the register distribution pattern of
> context domains and invalidation engines will be changed in gc_v***.h and
> mmhub_v***.h. However the register distances are always constant in one IP block
> beside gfxhub and mmhub. So we can add register distance member in vmhub
> structure to store the register distance value, that's able to avoid the issue
> of hardcode at current in future updates.
Reviewed-by: Christian König <christian.koenig@amd.com> for the whole
series.
>
> Thanks,
> Ray
>
> Huang Rui (12):
> drm/amdgpu: add register distance members into vmhub structure
> drm/amdgpu: use register distance member instead of hardcode in GMC9
> drm/amdgpu: use register distance member instead of hardcode in GMC10
> drm/amdgpu: use register distance member instead of hardcode in
> VCN1/JEPG1
> drm/amdgpu: use register distance member instead of hardcode in
> UVD7/VCE4
> drm/amdgpu: use register distance member instead of hardcode in
> VCN2/JEPG2
> drm/amdgpu: use register distance member instead of hardcode in gfxhub
> v1
> drm/amdgpu: use register distance member instead of hardcode in gfxhub
> v2
> drm/amdgpu: use register distance member instead of hardcode in gfxhub
> v2.1
> drm/amdgpu: use register distance member instead of hardcode in mmhub
> v1
> drm/amdgpu: use register distance member instead of hardcode in mmhub
> v2
> drm/amdgpu: use register distance member instead of hardcode in mmhub
> v9.4
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 9 +++++
> drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 48 ++++++++++++++++--------
> drivers/gpu/drm/amd/amdgpu/gfxhub_v2_0.c | 47 +++++++++++++++--------
> drivers/gpu/drm/amd/amdgpu/gfxhub_v2_1.c | 47 +++++++++++++++--------
> drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 43 ++++++++++++---------
> drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 39 ++++++++++++-------
> drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 45 ++++++++++++++--------
> drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c | 46 +++++++++++++++--------
> drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c | 46 +++++++++++++++--------
> drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 5 ++-
> drivers/gpu/drm/amd/amdgpu/vce_v4_0.c | 3 +-
> drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 5 ++-
> drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 5 ++-
> 15 files changed, 260 insertions(+), 132 deletions(-)
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2020-07-06 10:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 5:04 [PATCH 00/12] drm/amdgpu: add register distance Huang Rui
2020-07-06 5:04 ` [PATCH 01/12] drm/amdgpu: add register distance members into vmhub structure Huang Rui
2020-07-06 5:04 ` [PATCH 02/12] drm/amdgpu: use register distance member instead of hardcode in GMC9 Huang Rui
2020-07-06 5:05 ` [PATCH 03/12] drm/amdgpu: use register distance member instead of hardcode in GMC10 Huang Rui
2020-07-06 5:05 ` [PATCH 04/12] drm/amdgpu: use register distance member instead of hardcode in VCN1/JEPG1 Huang Rui
2020-07-06 5:05 ` [PATCH 05/12] drm/amdgpu: use register distance member instead of hardcode in UVD7/VCE4 Huang Rui
2020-07-06 5:05 ` [PATCH 06/12] drm/amdgpu: use register distance member instead of hardcode in VCN2/JEPG2 Huang Rui
2020-07-06 5:05 ` [PATCH 07/12] drm/amdgpu: use register distance member instead of hardcode in gfxhub v1 Huang Rui
2020-07-06 5:05 ` [PATCH 08/12] drm/amdgpu: use register distance member instead of hardcode in gfxhub v2 Huang Rui
2020-07-06 5:05 ` [PATCH 09/12] drm/amdgpu: use register distance member instead of hardcode in gfxhub v2.1 Huang Rui
2020-07-06 5:05 ` [PATCH 10/12] drm/amdgpu: use register distance member instead of hardcode in mmhub v1 Huang Rui
2020-07-06 5:05 ` [PATCH 11/12] drm/amdgpu: use register distance member instead of hardcode in mmhub v2 Huang Rui
2020-07-06 5:05 ` [PATCH 12/12] drm/amdgpu: use register distance member instead of hardcode in mmhub v9.4 Huang Rui
2020-07-06 10:39 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a56c76d4-71bc-3a70-c8bc-5584104f6963@amd.com \
--to=christian.koenig@amd.com \
--cc=AnZhong.Huang@amd.com \
--cc=aaron.liu@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=leo.liu@amd.com \
--cc=ray.huang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox