[PATCH v3 1/2] drm/amdgpu: add the argument description for inst

[PATCH v3 1/2] drm/amdgpu: add the argument description for inst

[Sunil Khatri]

Add argument description for the input argument
inst for amdgpu_device_ip_set_powergating_state.

Fixes the warning raised by the compiler:
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:2182:
warning: Function parameter or struct member 'inst' not described in 'amdgpu_device_ip_set_powergating_state'

Cc: Boyuan Zhang <Boyuan.Zhang@amd.com>
Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index bb530dd2b3e3..b3ca911e55d6 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2170,6 +2170,7 @@ int amdgpu_device_ip_set_clockgating_state(void *dev,
  * @dev: amdgpu_device pointer
  * @block_type: Type of hardware IP (SMU, GFX, UVD, etc.)
  * @state: powergating state (gate or ungate)
+ * @inst: Instance id of the specific block_type
  *
  * Sets the requested powergating state for all instances of
  * the hardware IP specified.
-- 
2.34.1

[PATCH v3 2/2] drm/amdgpu: add the argument description for gpu_addr

[Sunil Khatri]

Add argument description for the input argument
gpu_addr for amdgpu_seq64_alloc.

Fixes the warning raised by the compiler:
drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c:168:
warning: Function parameter or struct member 'gpu_addr' not described in 'amdgpu_seq64_alloc

Cc: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
index 0defad71044c..898d215a8d99 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
@@ -156,6 +156,7 @@ void amdgpu_seq64_unmap(struct amdgpu_device *adev, struct amdgpu_fpriv *fpriv)
  *
  * @adev: amdgpu_device pointer
  * @va: VA to access the seq in process address space
+ * @gpu_addr: GPU address to access the seq
  * @cpu_addr: CPU address to access the seq
  *
  * Alloc a 64 bit memory from seq64 pool.
-- 
2.34.1

Re: [PATCH v3 2/2] drm/amdgpu: add the argument description for gpu_addr

[Paneer Selvam, Arunpravin]

[-- Attachment #1: Type: text/plain, Size: 1198 bytes --]

Reviewed-by: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>

On 11/13/2024 2:37 PM, Sunil Khatri wrote:
> Add argument description for the input argument
> gpu_addr for amdgpu_seq64_alloc.
>
> Fixes the warning raised by the compiler:
> drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c:168:
> warning: Function parameter or struct member 'gpu_addr' not described in 'amdgpu_seq64_alloc
>
> Cc: Arunpravin Paneer Selvam<Arunpravin.PaneerSelvam@amd.com>
> Signed-off-by: Sunil Khatri<sunil.khatri@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
> index 0defad71044c..898d215a8d99 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
> @@ -156,6 +156,7 @@ void amdgpu_seq64_unmap(struct amdgpu_device *adev, struct amdgpu_fpriv *fpriv)
>    *
>    * @adev: amdgpu_device pointer
>    * @va: VA to access the seq in process address space
> + * @gpu_addr: GPU address to access the seq
>    * @cpu_addr: CPU address to access the seq
>    *
>    * Alloc a 64 bit memory from seq64 pool.

[-- Attachment #2: Type: text/html, Size: 1768 bytes --]

Re: [PATCH v3 2/2] drm/amdgpu: add the argument description for gpu_addr

[Boyuan Zhang]

[-- Attachment #1: Type: text/plain, Size: 1176 bytes --]


On 2024-11-13 04:07, Sunil Khatri wrote:
> Add argument description for the input argument
> gpu_addr for amdgpu_seq64_alloc.
>
> Fixes the warning raised by the compiler:
> drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c:168:
> warning: Function parameter or struct member 'gpu_addr' not described in 'amdgpu_seq64_alloc
>
> Cc: Arunpravin Paneer Selvam<Arunpravin.PaneerSelvam@amd.com>
> Signed-off-by: Sunil Khatri<sunil.khatri@amd.com>


Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>


> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
> index 0defad71044c..898d215a8d99 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
> @@ -156,6 +156,7 @@ void amdgpu_seq64_unmap(struct amdgpu_device *adev, struct amdgpu_fpriv *fpriv)
>    *
>    * @adev: amdgpu_device pointer
>    * @va: VA to access the seq in process address space
> + * @gpu_addr: GPU address to access the seq
>    * @cpu_addr: CPU address to access the seq
>    *
>    * Alloc a 64 bit memory from seq64 pool.

[-- Attachment #2: Type: text/html, Size: 2146 bytes --]

Re: [PATCH v3 1/2] drm/amdgpu: add the argument description for inst

[Boyuan Zhang]

[-- Attachment #1: Type: text/plain, Size: 1225 bytes --]


On 2024-11-13 04:07, Sunil Khatri wrote:
> Add argument description for the input argument
> inst for amdgpu_device_ip_set_powergating_state.
>
> Fixes the warning raised by the compiler:
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:2182:
> warning: Function parameter or struct member 'inst' not described in 'amdgpu_device_ip_set_powergating_state'
>
> Cc: Boyuan Zhang<Boyuan.Zhang@amd.com>
> Signed-off-by: Sunil Khatri<sunil.khatri@amd.com>


Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>


> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index bb530dd2b3e3..b3ca911e55d6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -2170,6 +2170,7 @@ int amdgpu_device_ip_set_clockgating_state(void *dev,
>    * @dev: amdgpu_device pointer
>    * @block_type: Type of hardware IP (SMU, GFX, UVD, etc.)
>    * @state: powergating state (gate or ungate)
> + * @inst: Instance id of the specific block_type
>    *
>    * Sets the requested powergating state for all instances of
>    * the hardware IP specified.

[-- Attachment #2: Type: text/html, Size: 2184 bytes --]