From: "Lazar, Lijo" <lijo.lazar@amd.com>
To: amd-gfx@lists.freedesktop.org
Cc: Hawking.Zhang@amd.com, Alexander.Deucher@amd.com,
Asad.Kamal@amd.com, kevinyang.wang@amd.com
Subject: Re: [PATCH v2 0/7] Refactor smu feature bit implementation
Date: Thu, 22 Jan 2026 16:14:12 +0530 [thread overview]
Message-ID: <d7f45afa-5c79-4b98-824e-9ca0adbb60f5@amd.com> (raw)
In-Reply-To: <20260120061402.1287680-1-lijo.lazar@amd.com>
<ping>
On 20-Jan-26 11:42 AM, Lijo Lazar wrote:
> Presently a 64-bit bitmask is used to represent the PM features enabled/supported by SOC. The
> number of features has grown to nearly 64 and could extend beyond that. Instead of using a 64-bit
> mask, implement a data structure around bitmap and move the implementation to use the datastructure
> instead of directly operating on 64-bit bitmask.
>
> v2:
> Use to_arr32 instead of direct assignment
>
> Lijo Lazar (7):
> drm/amd/pm: Add smu feature bits data struct
> drm/amd/pm: Add smu feature interface functions
> drm/amd/pm: Remove unused logic in SMUv14.0.2
> drm/amd/pm: Initialize allowed feature list
> drm/amd/pm: Use feature bits data structure
> drm/amd/pm: Change get_enabled_mask signature
> drm/amd/pm: Add default feature number definition
>
> drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 48 ++---
> drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 204 +++++++++++++++++-
> .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 33 ++-
> .../amd/pm/swsmu/smu11/cyan_skillfish_ppt.c | 24 ++-
> .../gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 119 +++++-----
> .../amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 116 +++++-----
> .../gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 5 +-
> .../gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 29 +--
> .../gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c | 4 +-
> .../drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 37 ++--
> .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 6 +-
> .../drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 58 +++--
> .../drm/amd/pm/swsmu/smu13/smu_v13_0_12_ppt.c | 20 +-
> .../drm/amd/pm/swsmu/smu13/smu_v13_0_4_ppt.c | 34 +--
> .../drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c | 29 +--
> .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 39 ++--
> .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 103 +++++----
> .../drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c | 29 +--
> .../gpu/drm/amd/pm/swsmu/smu14/smu_v14_0.c | 6 +-
> .../drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c | 33 +--
> .../drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c | 69 ++----
> .../gpu/drm/amd/pm/swsmu/smu15/smu_v15_0.c | 6 +-
> .../drm/amd/pm/swsmu/smu15/smu_v15_0_0_ppt.c | 33 +--
> drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 82 +++----
> drivers/gpu/drm/amd/pm/swsmu/smu_cmn.h | 2 +-
> drivers/gpu/drm/amd/pm/swsmu/smu_internal.h | 2 +-
> 26 files changed, 662 insertions(+), 508 deletions(-)
>
next prev parent reply other threads:[~2026-01-22 10:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 6:12 [PATCH v2 0/7] Refactor smu feature bit implementation Lijo Lazar
2026-01-20 6:12 ` [PATCH v2 1/7] drm/amd/pm: Add smu feature bits data struct Lijo Lazar
2026-01-20 6:12 ` [PATCH v2 2/7] drm/amd/pm: Add smu feature interface functions Lijo Lazar
2026-01-20 6:12 ` [PATCH v2 3/7] drm/amd/pm: Remove unused logic in SMUv14.0.2 Lijo Lazar
2026-01-20 6:12 ` [PATCH v2 4/7] drm/amd/pm: Initialize allowed feature list Lijo Lazar
2026-01-20 6:12 ` [PATCH v2 5/7] drm/amd/pm: Use feature bits data structure Lijo Lazar
2026-01-20 6:12 ` [PATCH v2 6/7] drm/amd/pm: Change get_enabled_mask signature Lijo Lazar
2026-01-20 6:12 ` [PATCH v2 7/7] drm/amd/pm: Add default feature number definition Lijo Lazar
2026-01-22 10:44 ` Lazar, Lijo [this message]
2026-01-23 6:06 ` [PATCH v2 0/7] Refactor smu feature bit implementation Kamal, Asad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7f45afa-5c79-4b98-824e-9ca0adbb60f5@amd.com \
--to=lijo.lazar@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Asad.Kamal@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=kevinyang.wang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox