ATH10K Archive on lore.kernel.org
 help / color / mirror / Atom feed
* ath10k: Two missing sdio patches
@ 2019-05-05 14:22 Erik Stromdahl
  2019-05-06  3:36 ` Wen Gong
  0 siblings, 1 reply; 2+ messages in thread
From: Erik Stromdahl @ 2019-05-05 14:22 UTC (permalink / raw)
  To: Kalle Valo, wgong, ath10k@lists.infradead.org

Hej Kalle, Wen,

I see there are lots of SDIO patches coming in to the mailing ath10k list, great!

I while back I submitted two patches that adds an inline wrapper for an htt op.

patchwork:
https://patchwork.kernel.org/project/linux-wireless/list/?series=97099

Without these patches I get a panic due to calling a NULL pointer callback
with SDIO.

It is the htt->tx_ops->htt_h2t_aggr_cfg_msg() in ath10k_htt_setup() that causes the panic.

Kalle:
I notice that you don't have these patches in your pending-sdio-usb branch.

Wen:
Do you have any other patch that fixes this issue (I can't see how it can work without
these patches unless you have some other fix)?

--
Erik

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: ath10k: Two missing sdio patches
  2019-05-05 14:22 ath10k: Two missing sdio patches Erik Stromdahl
@ 2019-05-06  3:36 ` Wen Gong
  0 siblings, 0 replies; 2+ messages in thread
From: Wen Gong @ 2019-05-06  3:36 UTC (permalink / raw)
  To: Erik Stromdahl, kvalo@codeaurora.org, wgong@codeaurora.org,
	ath10k@lists.infradead.org

> -----Original Message-----
> From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Erik
> Stromdahl
> Sent: Sunday, May 5, 2019 10:23 PM
> To: kvalo@codeaurora.org; wgong@codeaurora.org;
> ath10k@lists.infradead.org
> Subject: [EXT] ath10k: Two missing sdio patches
> 
> Hej Kalle, Wen,
> 
> I see there are lots of SDIO patches coming in to the mailing ath10k list, great!
> 
> I while back I submitted two patches that adds an inline wrapper for an htt
> op.
> 
> patchwork:
> https://patchwork.kernel.org/project/linux-wireless/list/?series=97099
> 
> Without these patches I get a panic due to calling a NULL pointer callback
> with SDIO.
> 
> It is the htt->tx_ops->htt_h2t_aggr_cfg_msg() in ath10k_htt_setup() that
> causes the panic.
> 
> Kalle:
> I notice that you don't have these patches in your pending-sdio-usb branch.
> 
> Wen:
> Do you have any other patch that fixes this issue (I can't see how it can work
> without
> these patches unless you have some other fix)?
> 
Hi Erik,
I do not have other patch to fix the issue.
The patch change the ath10k_htt_h2t_aggr_cfg_msg to htt->tx_ops->htt_h2t_aggr_cfg_msg in ath10k_htt_setup.
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/drivers/net/wireless/ath/ath10k/htt.c?id=5cbb117477501df2f8b3a384b042b08cd7174c92
I used chromeos which does not include the upper patch.
> --
> Erik
> 
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-06  3:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-05 14:22 ath10k: Two missing sdio patches Erik Stromdahl
2019-05-06  3:36 ` Wen Gong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox