ath10k-firmware: QCA4019 hw1.0: Add OpenMesh A42 specific BDFs

ath10k-firmware: QCA4019 hw1.0: Add OpenMesh A42 specific BDFs

[Sven Eckelmann]

[-- Attachment #1.1.1: Type: text/plain, Size: 1265 bytes --]

Hi,

I am currently trying to integrate the OpenMesh A42 support in LEDE [1]. This 
AP requires two special BDFs to get the Wi-Fi PHYs working (correctly). The 
bmi-board-id='s would clash with one of the the IPQ401X AP-DK boards because
QCA doesn't provide special IDs for customers and seems to use the AP-DK
board-ids in the wifi firmware to change its behavior. But we've already
proposed a patch to work around this kind of problem [2].

The name of the files are equal to the id string in the board-2.bin (minus the 
".bin"):

* bus=ahb,bmi-chip-id=0,bmi-board-id=16,variant=OM-A42
  - sha256sum: 
    10700a7ac636d57fe055e5bb4bd5f7bb3f1c282a7f25a8bb2204fc36e8c317bf
* bus=ahb,bmi-chip-id=0,bmi-board-id=17,variant=OM-A42
  - sha256sum:
    b3d9556894e509ac608b2e27c9169da12c63634670bb69c5ef21fb31583e7998
  
I think that Christian Lamparter also has some BDFs for Asus RT-AC58U, 
FRITZ!Box 4040 and Zyxel NBG6617 [3] which could be upstreamed in a similar 
way. So please tell us when you want to have these things submitted in a 
slightly different way.

Kind regards,
	Sven

[1] https://github.com/lede-project/source/pull/1550
[2] https://patchwork.kernel.org/patch/9615185/
[3] https://github.com/lede-project/source/tree/master/package/firmware/ipq-wifi

[-- Attachment #1.1.2: bus=ahb,bmi-chip-id=0,bmi-board-id=16,variant=OM-A42.bin --]
[-- Type: application/octet-stream, Size: 12064 bytes --]

[-- Attachment #1.1.3: bus=ahb,bmi-chip-id=0,bmi-board-id=17,variant=OM-A42.bin --]
[-- Type: application/octet-stream, Size: 12064 bytes --]

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 146 bytes --]

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: ath10k-firmware: QCA4019 hw1.0: Add OpenMesh A42 specific BDFs

[Sven Eckelmann]

[-- Attachment #1.1: Type: text/plain, Size: 1240 bytes --]

On Dienstag, 28. November 2017 15:45:52 CET Sven Eckelmann wrote:
[....]
> I think that Christian Lamparter also has some BDFs for Asus RT-AC58U, 
> FRITZ!Box 4040 and Zyxel NBG6617 [3] which could be upstreamed in a similar 
> way. So please tell us when you want to have these things submitted in a 
> slightly different way.

There is now a wiki page under https://wireless.wiki.kernel.org/en/users/
drivers/ath10k/boardfiles which describes the required information. Here are 
the answers to the questions:

* description for what hardware this is:
  - it is a QCA401x based board (based on qcom-ipq4019-ap.dk01.1)
  - the 5GHz and 2.4GHz radio components were drastically changed by ODM
  - it is sold as OpenMesh A42

* origin of the board file (did you create it yourself or where you downloaded)
  - it was created by the ODM and QCA for the OpenMesh A42
  - was provided by the ODM to OpenMesh for this product (this includes
    distribution)
  - it is the latest release from 2017-05-29

* ids to be used with the board file (ATH10K_BD_IE_BOARD_NAME in ath10k)
  - OM-A42 is the variant string
  - complete strings are listed in original mail

* attach the actual board file (board.bin)
  - See original mail

Kind regards,
	Sven

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 146 bytes --]

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: ath10k-firmware: QCA4019 hw1.0: Add OpenMesh A42 specific BDFs

[Kalle Valo]

Sven Eckelmann <sven.eckelmann@openmesh.com> writes:

> Hi,
>
> I am currently trying to integrate the OpenMesh A42 support in LEDE [1]. This 
> AP requires two special BDFs to get the Wi-Fi PHYs working (correctly). The 
> bmi-board-id='s would clash with one of the the IPQ401X AP-DK boards because
> QCA doesn't provide special IDs for customers and seems to use the AP-DK
> board-ids in the wifi firmware to change its behavior. But we've already
> proposed a patch to work around this kind of problem [2].
>
> The name of the files are equal to the id string in the board-2.bin (minus the 
> ".bin"):
>
> * bus=ahb,bmi-chip-id=0,bmi-board-id=16,variant=OM-A42
>   - sha256sum: 
>     10700a7ac636d57fe055e5bb4bd5f7bb3f1c282a7f25a8bb2204fc36e8c317bf
> * bus=ahb,bmi-chip-id=0,bmi-board-id=17,variant=OM-A42
>   - sha256sum:
>     b3d9556894e509ac608b2e27c9169da12c63634670bb69c5ef21fb31583e7998

I added these now:

https://github.com/kvalo/ath10k-firmware/commit/5cd2bacd8e22217335e539b416d0cb8d59f8e312

To make this easier I did some bigger changes in ath10k-bdencoder,
please check carefully that I didn't break anything.

-- 
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: ath10k-firmware: QCA4019 hw1.0: Add OpenMesh A42 specific BDFs

[Sven Eckelmann]

[-- Attachment #1.1: Type: text/plain, Size: 1701 bytes --]

On Freitag, 26. Januar 2018 16:07:10 CET Kalle Valo wrote:
[...]
> > * bus=ahb,bmi-chip-id=0,bmi-board-id=16,variant=OM-A42
> >   - sha256sum: 
> >     10700a7ac636d57fe055e5bb4bd5f7bb3f1c282a7f25a8bb2204fc36e8c317bf
> > * bus=ahb,bmi-chip-id=0,bmi-board-id=17,variant=OM-A42
> >   - sha256sum:
> >     b3d9556894e509ac608b2e27c9169da12c63634670bb69c5ef21fb31583e7998
> 
> I added these now:
> 
> https://github.com/kvalo/ath10k-firmware/commit/5cd2bacd8e22217335e539b416d0cb8d59f8e312
>
> To make this easier I did some bigger changes in ath10k-bdencoder,
> please check carefully that I didn't break anything.

Tested it by extracting the files using the ath10k-bdencoder d278f25bc977 
(from 2017-02-10) and then calculating the sha256sum's using

    $ sha256sum bus=ahb,bmi-chip-id=0,bmi-board-id=16,variant=OM-A42.bin bus=ahb,bmi-chip-id=0,bmi-board-id=17,variant=OM-A42.bin 
    10700a7ac636d57fe055e5bb4bd5f7bb3f1c282a7f25a8bb2204fc36e8c317bf  bus=ahb,bmi-chip-id=0,bmi-board-id=16,variant=OM-A42.bin
    b3d9556894e509ac608b2e27c9169da12c63634670bb69c5ef21fb31583e7998  bus=ahb,bmi-chip-id=0,bmi-board-id=17,variant=OM-A42.bin

It was also checked that the board-2.json only had these names attached to the 
.bin files.

I did the same with my reference files and came to the same results. I am
assuming that the files must have been added correctly when the names are 
correct and the content is correct.

I have then extracted the version prior to the OM-A42 change and compared it 
to the one with OM-A42. The only difference I could find are related to the 
OM-A42. I must therefore also assume that only the relevant parts were changed 
and the other BDFs were not touched.

Thanks,
	Sven

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 146 bytes --]

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: ath10k-firmware: QCA4019 hw1.0: Add OpenMesh A42 specific BDFs

[Kalle Valo]

Sven Eckelmann <sven.eckelmann@openmesh.com> writes:

> On Freitag, 26. Januar 2018 16:07:10 CET Kalle Valo wrote:
> [...]
>> > * bus=ahb,bmi-chip-id=0,bmi-board-id=16,variant=OM-A42
>> >   - sha256sum: 
>> >     10700a7ac636d57fe055e5bb4bd5f7bb3f1c282a7f25a8bb2204fc36e8c317bf
>> > * bus=ahb,bmi-chip-id=0,bmi-board-id=17,variant=OM-A42
>> >   - sha256sum:
>> >     b3d9556894e509ac608b2e27c9169da12c63634670bb69c5ef21fb31583e7998
>> 
>> I added these now:
>> 
>> https://github.com/kvalo/ath10k-firmware/commit/5cd2bacd8e22217335e539b416d0cb8d59f8e312
>>
>> To make this easier I did some bigger changes in ath10k-bdencoder,
>> please check carefully that I didn't break anything.
>
> Tested it by extracting the files using the ath10k-bdencoder d278f25bc977 
> (from 2017-02-10) and then calculating the sha256sum's using
>
>     $ sha256sum bus=ahb,bmi-chip-id=0,bmi-board-id=16,variant=OM-A42.bin bus=ahb,bmi-chip-id=0,bmi-board-id=17,variant=OM-A42.bin 
>     10700a7ac636d57fe055e5bb4bd5f7bb3f1c282a7f25a8bb2204fc36e8c317bf  bus=ahb,bmi-chip-id=0,bmi-board-id=16,variant=OM-A42.bin
>     b3d9556894e509ac608b2e27c9169da12c63634670bb69c5ef21fb31583e7998  bus=ahb,bmi-chip-id=0,bmi-board-id=17,variant=OM-A42.bin
>
> It was also checked that the board-2.json only had these names attached to the 
> .bin files.
>
> I did the same with my reference files and came to the same results. I am
> assuming that the files must have been added correctly when the names are 
> correct and the content is correct.
>
> I have then extracted the version prior to the OM-A42 change and compared it 
> to the one with OM-A42. The only difference I could find are related to the 
> OM-A42. I must therefore also assume that only the relevant parts were changed 
> and the other BDFs were not touched.

Good, thanks for checking!

-- 
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k