ATH10K Archive on lore.kernel.org
 help / color / mirror / Atom feed
* ath10k: first qca6174 hw2.1 firmware released
@ 2015-08-13 10:31 Kalle Valo
  2015-08-13 14:00 ` Lapo Calamandrei
  0 siblings, 1 reply; 9+ messages in thread
From: Kalle Valo @ 2015-08-13 10:31 UTC (permalink / raw)
  To: ath10k; +Cc: linux-wireless

Hi,

I just pushed the first qca6174  hw2.1 firmware to ath10k-firmware.git:

https://github.com/kvalo/ath10k-firmware/commit/7f7e7dda33676ced293de477b03711199ffe5256

Please test and provide feedback.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: ath10k: first qca6174 hw2.1 firmware released
  2015-08-13 10:31 ath10k: first qca6174 hw2.1 firmware released Kalle Valo
@ 2015-08-13 14:00 ` Lapo Calamandrei
  2015-08-17  5:52   ` Michal Kazior
  0 siblings, 1 reply; 9+ messages in thread
From: Lapo Calamandrei @ 2015-08-13 14:00 UTC (permalink / raw)
  To: Kalle Valo; +Cc: ath10k

2015-08-13 12:31 GMT+02:00 Kalle Valo <kvalo@qca.qualcomm.com>:
> Hi,
>
> I just pushed the first qca6174  hw2.1 firmware to ath10k-firmware.git:
>
> https://github.com/kvalo/ath10k-firmware/commit/7f7e7dda33676ced293de477b03711199ffe5256
>
> Please test and provide feedback.
>
> --
> Kalle Valo
>

Loads w/o skip_otp and works fine here (qca6174), except it crashes on
5GHz network connection attempt as the one created from the window
drivers.

Ciao
Lapo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: ath10k: first qca6174 hw2.1 firmware released
  2015-08-13 14:00 ` Lapo Calamandrei
@ 2015-08-17  5:52   ` Michal Kazior
  2015-08-24 16:26     ` Lapo Calamandrei
  0 siblings, 1 reply; 9+ messages in thread
From: Michal Kazior @ 2015-08-17  5:52 UTC (permalink / raw)
  To: Lapo Calamandrei; +Cc: Kalle Valo, ath10k@lists.infradead.org

On 13 August 2015 at 16:00, Lapo Calamandrei <calamandrei@gmail.com> wrote:
> 2015-08-13 12:31 GMT+02:00 Kalle Valo <kvalo@qca.qualcomm.com>:
>> Hi,
>>
>> I just pushed the first qca6174  hw2.1 firmware to ath10k-firmware.git:
>>
>> https://github.com/kvalo/ath10k-firmware/commit/7f7e7dda33676ced293de477b03711199ffe5256
>>
>> Please test and provide feedback.
>>
>> --
>> Kalle Valo
>>
>
> Loads w/o skip_otp and works fine here (qca6174), except it crashes on
> 5GHz network connection attempt as the one created from the window
> drivers.

Paste the crash register dump and `iw list` output, please.


Michał

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: ath10k: first qca6174 hw2.1 firmware released
  2015-08-17  5:52   ` Michal Kazior
@ 2015-08-24 16:26     ` Lapo Calamandrei
  2015-08-25  5:09       ` Michal Kazior
  0 siblings, 1 reply; 9+ messages in thread
From: Lapo Calamandrei @ 2015-08-24 16:26 UTC (permalink / raw)
  To: Michal Kazior; +Cc: Kalle Valo, ath10k@lists.infradead.org

2015-08-17 7:52 GMT+02:00 Michal Kazior <michal.kazior@tieto.com>:
> On 13 August 2015 at 16:00, Lapo Calamandrei <calamandrei@gmail.com> wrote:
>> 2015-08-13 12:31 GMT+02:00 Kalle Valo <kvalo@qca.qualcomm.com>:
>>> Hi,
>>>
>>> I just pushed the first qca6174  hw2.1 firmware to ath10k-firmware.git:
>>>
>>> https://github.com/kvalo/ath10k-firmware/commit/7f7e7dda33676ced293de477b03711199ffe5256
>>>
>>> Please test and provide feedback.
>>>
>>> --
>>> Kalle Valo
>>>
>>
>> Loads w/o skip_otp and works fine here (qca6174), except it crashes on
>> 5GHz network connection attempt as the one created from the window
>> drivers.
>
> Paste the crash register dump and `iw list` output, please.
>
>
> Michał

Sorry for the late reply.

Here's the iw list output:

[lapo@localhost ~]$ iw list
Wiphy phy0
    max # scan SSIDs: 16
    max scan IEs length: 195 bytes
    max # sched scan SSIDs: 0
    max # match sets: 0
    Retry short limit: 7
    Retry long limit: 4
    Coverage class: 0 (up to 0m)
    Device supports RSN-IBSS.
    Device supports AP-side u-APSD.
    Supported Ciphers:
        * WEP40 (00-0f-ac:1)
        * WEP104 (00-0f-ac:5)
        * TKIP (00-0f-ac:2)
        * CCMP (00-0f-ac:4)
        * CMAC (00-0f-ac:6)
    Available Antennas: TX 0x3 RX 0x3
    Configured Antennas: TX 0x3 RX 0x3
    Supported interface modes:
         * IBSS
         * managed
         * AP
         * AP/VLAN
         * monitor
         * P2P-client
         * P2P-GO
         * P2P-device
    Band 1:
        Capabilities: 0x19e3
            RX LDPC
            HT20/HT40
            Static SM Power Save
            RX HT20 SGI
            RX HT40 SGI
            TX STBC
            RX STBC 1-stream
            Max AMSDU length: 7935 bytes
            DSSS/CCK HT40
        Maximum RX AMPDU length 65535 bytes (exponent: 0x003)
        Minimum RX AMPDU time spacing: 8 usec (0x06)
        HT TX/RX MCS rate indexes supported: 0-15
        VHT Capabilities (0x339031b2):
            Max MPDU length: 11454
            Supported Channel Width: neither 160 nor 80+80
            RX LDPC
            short GI (80 MHz)
            TX STBC
            SU Beamformee
            MU Beamformee
            RX antenna pattern consistency
            TX antenna pattern consistency
        VHT RX MCS set:
            1 streams: MCS 0-9
            2 streams: MCS 0-9
            3 streams: not supported
            4 streams: not supported
            5 streams: not supported
            6 streams: not supported
            7 streams: not supported
            8 streams: not supported
        VHT RX highest supported: 0 Mbps
        VHT TX MCS set:
            1 streams: MCS 0-9
            2 streams: MCS 0-9
            3 streams: not supported
            4 streams: not supported
            5 streams: not supported
            6 streams: not supported
            7 streams: not supported
            8 streams: not supported
        VHT TX highest supported: 0 Mbps
        Bitrates (non-HT):
            * 1.0 Mbps
            * 2.0 Mbps (short preamble supported)
            * 5.5 Mbps (short preamble supported)
            * 11.0 Mbps (short preamble supported)
            * 6.0 Mbps
            * 9.0 Mbps
            * 12.0 Mbps
            * 18.0 Mbps
            * 24.0 Mbps
            * 36.0 Mbps
            * 48.0 Mbps
            * 54.0 Mbps
        Frequencies:
            * 2412 MHz [1] (20.0 dBm)
            * 2417 MHz [2] (20.0 dBm)
            * 2422 MHz [3] (20.0 dBm)
            * 2427 MHz [4] (20.0 dBm)
            * 2432 MHz [5] (20.0 dBm)
            * 2437 MHz [6] (20.0 dBm)
            * 2442 MHz [7] (20.0 dBm)
            * 2447 MHz [8] (20.0 dBm)
            * 2452 MHz [9] (20.0 dBm)
            * 2457 MHz [10] (20.0 dBm)
            * 2462 MHz [11] (20.0 dBm)
            * 2467 MHz [12] (20.0 dBm) (no IR)
            * 2472 MHz [13] (20.0 dBm) (no IR)
            * 2484 MHz [14] (disabled)
    Band 2:
        Capabilities: 0x19e3
            RX LDPC
            HT20/HT40
            Static SM Power Save
            RX HT20 SGI
            RX HT40 SGI
            TX STBC
            RX STBC 1-stream
            Max AMSDU length: 7935 bytes
            DSSS/CCK HT40
        Maximum RX AMPDU length 65535 bytes (exponent: 0x003)
        Minimum RX AMPDU time spacing: 8 usec (0x06)
        HT TX/RX MCS rate indexes supported: 0-15
        VHT Capabilities (0x339031b2):
            Max MPDU length: 11454
            Supported Channel Width: neither 160 nor 80+80
            RX LDPC
            short GI (80 MHz)
            TX STBC
            SU Beamformee
            MU Beamformee
            RX antenna pattern consistency
            TX antenna pattern consistency
        VHT RX MCS set:
            1 streams: MCS 0-9
            2 streams: MCS 0-9
            3 streams: not supported
            4 streams: not supported
            5 streams: not supported
            6 streams: not supported
            7 streams: not supported
            8 streams: not supported
        VHT RX highest supported: 0 Mbps
        VHT TX MCS set:
            1 streams: MCS 0-9
            2 streams: MCS 0-9
            3 streams: not supported
            4 streams: not supported
            5 streams: not supported
            6 streams: not supported
            7 streams: not supported
            8 streams: not supported
        VHT TX highest supported: 0 Mbps
        Bitrates (non-HT):
            * 6.0 Mbps
            * 9.0 Mbps
            * 12.0 Mbps
            * 18.0 Mbps
            * 24.0 Mbps
            * 36.0 Mbps
            * 48.0 Mbps
            * 54.0 Mbps
        Frequencies:
            * 5180 MHz [36] (20.0 dBm) (no IR)
            * 5200 MHz [40] (20.0 dBm) (no IR)
            * 5220 MHz [44] (20.0 dBm) (no IR)
            * 5240 MHz [48] (20.0 dBm) (no IR)
            * 5260 MHz [52] (20.0 dBm) (no IR, radar detection)
              DFS state: usable (for 527 sec)
              DFS CAC time: 60000 ms
            * 5280 MHz [56] (20.0 dBm) (no IR, radar detection)
              DFS state: usable (for 527 sec)
              DFS CAC time: 60000 ms
            * 5300 MHz [60] (20.0 dBm) (no IR, radar detection)
              DFS state: usable (for 527 sec)
              DFS CAC time: 60000 ms
            * 5320 MHz [64] (20.0 dBm) (no IR, radar detection)
              DFS state: usable (for 527 sec)
              DFS CAC time: 60000 ms
            * 5500 MHz [100] (27.0 dBm) (no IR, radar detection)
              DFS state: usable (for 527 sec)
              DFS CAC time: 60000 ms
            * 5520 MHz [104] (27.0 dBm) (no IR, radar detection)
              DFS state: usable (for 527 sec)
              DFS CAC time: 60000 ms
            * 5540 MHz [108] (27.0 dBm) (no IR, radar detection)
              DFS state: usable (for 527 sec)
              DFS CAC time: 60000 ms
            * 5560 MHz [112] (27.0 dBm) (no IR, radar detection)
              DFS state: usable (for 527 sec)
              DFS CAC time: 60000 ms
            * 5580 MHz [116] (27.0 dBm) (no IR, radar detection)
              DFS state: usable (for 527 sec)
              DFS CAC time: 60000 ms
            * 5600 MHz [120] (27.0 dBm) (no IR, radar detection)
              DFS state: usable (for 527 sec)
              DFS CAC time: 60000 ms
            * 5620 MHz [124] (27.0 dBm) (no IR, radar detection)
              DFS state: usable (for 527 sec)
              DFS CAC time: 60000 ms
            * 5640 MHz [128] (27.0 dBm) (no IR, radar detection)
              DFS state: usable (for 527 sec)
              DFS CAC time: 60000 ms
            * 5660 MHz [132] (27.0 dBm) (no IR, radar detection)
              DFS state: usable (for 527 sec)
              DFS CAC time: 60000 ms
            * 5680 MHz [136] (27.0 dBm) (no IR, radar detection)
              DFS state: usable (for 527 sec)
              DFS CAC time: 60000 ms
            * 5700 MHz [140] (27.0 dBm) (no IR, radar detection)
              DFS state: usable (for 527 sec)
              DFS CAC time: 60000 ms
            * 5720 MHz [144] (disabled)
            * 5745 MHz [149] (disabled)
            * 5765 MHz [153] (disabled)
            * 5785 MHz [157] (disabled)
            * 5805 MHz [161] (disabled)
            * 5825 MHz [165] (disabled)
    Supported commands:
         * new_interface
         * set_interface
         * new_key
         * start_ap
         * new_station
         * new_mpath
         * set_mesh_config
         * set_bss
         * authenticate
         * associate
         * deauthenticate
         * disassociate
         * join_ibss
         * join_mesh
         * remain_on_channel
         * set_tx_bitrate_mask
         * frame
         * frame_wait_cancel
         * set_wiphy_netns
         * set_channel
         * set_wds_peer
         * probe_client
         * set_noack_map
         * register_beacons
         * start_p2p_device
         * set_mcast_rate
         * channel_switch
         * set_qos_map
         * connect
         * disconnect
    Supported TX frame types:
         * IBSS: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90
0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
         * managed: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90
0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
         * AP: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90 0xa0
0xb0 0xc0 0xd0 0xe0 0xf0
         * AP/VLAN: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90
0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
         * mesh point: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80
0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
         * P2P-client: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80
0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
         * P2P-GO: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90
0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
         * P2P-device: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80
0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
    Supported RX frame types:
         * IBSS: 0x40 0xb0 0xc0 0xd0
         * managed: 0x40 0xd0
         * AP: 0x00 0x20 0x40 0xa0 0xb0 0xc0 0xd0
         * AP/VLAN: 0x00 0x20 0x40 0xa0 0xb0 0xc0 0xd0
         * mesh point: 0xb0 0xc0 0xd0
         * P2P-client: 0x40 0xd0
         * P2P-GO: 0x00 0x20 0x40 0xa0 0xb0 0xc0 0xd0
         * P2P-device: 0x40 0xd0
    software interface modes (can always be added):
         * AP/VLAN
         * monitor
    valid interface combinations:
         * #{ managed } <= 2, #{ AP, P2P-client, P2P-GO } <= 2, #{
P2P-device } <= 1,
           total <= 4, #channels <= 1
         * #{ managed } <= 2, #{ P2P-client } <= 2, #{ AP, P2P-GO } <=
1, #{ P2P-device } <= 1,
           total <= 4, #channels <= 2
         * #{ managed } <= 1, #{ IBSS } <= 1,
           total <= 2, #channels <= 1
    HT Capability overrides:
         * MCS: ff ff ff ff ff ff ff ff ff ff
         * maximum A-MSDU length
         * supported channel width
         * short GI for 40 MHz
         * max A-MPDU length exponent
         * min MPDU start spacing
    Device supports TX status socket option.
    Device supports HT-IBSS.
    Device supports SAE with AUTHENTICATE command
    Device supports scan flush.
    Device supports per-vif TX power setting
    Driver supports a userspace MPM
    Driver/device bandwidth changes during BSS lifetime (AP/GO mode)
    Device supports static SMPS
    Device supports configuring vdev MAC-addr on create.
    Device supports VHT-IBSS.

Here's the register dump:

ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
firmware register dump:
ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[00]: 0x05010000 0x000015B3 0x00939797 0x00955B31
ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[04]: 0x00939797 0x00060330 0x00000000 0x00000000
ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[08]: 0x00413980 0x0000FFFF 0x00000000 0x00000000
ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[12]: 0x00000009 0xFFFFFFFF 0x0096C09C 0x0096C0A7
ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[16]: 0x0096BDBC 0x009287BD 0x00000000 0x009287BD
ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[20]: 0x40939797 0x0041A700 0x00407124 0x00000000
ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[24]: 0x8093D6C4 0x0041A760 0x004059D0 0xC0939797
ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[28]: 0x8094777F 0x0041A780 0x0046D5D8 0x00000001
ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[32]: 0x800AA427 0x0041A7B0 0x0046D5D8 0x00000001
ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[36]: 0x800AA58E 0x0041A7D0 0x00424824 0x00000001
ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[40]: 0x80994D90 0x0041A7F0 0x00424824 0x0041A838
ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[44]: 0x80996DC6 0x0041A820 0x0046F888 0x00412984
ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[48]: 0x800B43F5 0x0041A860 0x004222F8 0x00005008
ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[52]: 0x809A6ACC 0x0041A8F0 0x0042930C 0x0042CA24
ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[56]: 0x809A6120 0x0041A930 0x0041A958 0x00427110



Regards,
Lapo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: ath10k: first qca6174 hw2.1 firmware released
  2015-08-24 16:26     ` Lapo Calamandrei
@ 2015-08-25  5:09       ` Michal Kazior
  2015-08-25 14:04         ` Lapo Calamandrei
  0 siblings, 1 reply; 9+ messages in thread
From: Michal Kazior @ 2015-08-25  5:09 UTC (permalink / raw)
  To: Lapo Calamandrei; +Cc: Kalle Valo, ath10k@lists.infradead.org

On 24 August 2015 at 18:26, Lapo Calamandrei <calamandrei@gmail.com> wrote:
> 2015-08-17 7:52 GMT+02:00 Michal Kazior <michal.kazior@tieto.com>:
>> On 13 August 2015 at 16:00, Lapo Calamandrei <calamandrei@gmail.com> wrote:
>>> 2015-08-13 12:31 GMT+02:00 Kalle Valo <kvalo@qca.qualcomm.com>:
>>>> Hi,
>>>>
>>>> I just pushed the first qca6174  hw2.1 firmware to ath10k-firmware.git:
>>>>
>>>> https://github.com/kvalo/ath10k-firmware/commit/7f7e7dda33676ced293de477b03711199ffe5256
>>>>
>>>> Please test and provide feedback.
>>>>
>>>> --
>>>> Kalle Valo
>>>>
>>>
>>> Loads w/o skip_otp and works fine here (qca6174), except it crashes on
>>> 5GHz network connection attempt as the one created from the window
>>> drivers.
>>
>> Paste the crash register dump and `iw list` output, please.
>>
>>
>> Michał
>
> Sorry for the late reply.
>
> Here's the iw list output:
[...]
>     Band 1:
>         Capabilities: 0x19e3
>             RX LDPC
>             HT20/HT40
>             Static SM Power Save
>             RX HT20 SGI
>             RX HT40 SGI
>             TX STBC
>             RX STBC 1-stream
>             Max AMSDU length: 7935 bytes
>             DSSS/CCK HT40
>         Maximum RX AMPDU length 65535 bytes (exponent: 0x003)
>         Minimum RX AMPDU time spacing: 8 usec (0x06)
>         HT TX/RX MCS rate indexes supported: 0-15
>         VHT Capabilities (0x339031b2):
>             Max MPDU length: 11454
>             Supported Channel Width: neither 160 nor 80+80
>             RX LDPC
>             short GI (80 MHz)
>             TX STBC
>             SU Beamformee
>             MU Beamformee

Is this with the change I suggested you earlier? I guess not. I don't
think this firmware should advertise beamforming support.

Can you re-try with patch from
http://lists.infradead.org/pipermail/ath10k/2015-August/005774.html,
please? If it still doesn't work please post `iw list` and the
register dump.

You can also try commenting out calls to ath10k_mac_vif_recalc_txbf() as plan B.


[...]
> Here's the register dump:
>
> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
> firmware register dump:
> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
> [00]: 0x05010000 0x000015B3 0x00939797 0x00955B31
> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
> [04]: 0x00939797 0x00060330 0x00000000 0x00000000
> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
> [08]: 0x00413980 0x0000FFFF 0x00000000 0x00000000
> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
> [12]: 0x00000009 0xFFFFFFFF 0x0096C09C 0x0096C0A7
> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
> [16]: 0x0096BDBC 0x009287BD 0x00000000 0x009287BD
> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
> [20]: 0x40939797 0x0041A700 0x00407124 0x00000000
> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
> [24]: 0x8093D6C4 0x0041A760 0x004059D0 0xC0939797
> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
> [28]: 0x8094777F 0x0041A780 0x0046D5D8 0x00000001
> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
> [32]: 0x800AA427 0x0041A7B0 0x0046D5D8 0x00000001
> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
> [36]: 0x800AA58E 0x0041A7D0 0x00424824 0x00000001
> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
> [40]: 0x80994D90 0x0041A7F0 0x00424824 0x0041A838
> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
> [44]: 0x80996DC6 0x0041A820 0x0046F888 0x00412984
> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
> [48]: 0x800B43F5 0x0041A860 0x004222F8 0x00005008
> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
> [52]: 0x809A6ACC 0x0041A8F0 0x0042930C 0x0042CA24
> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
> [56]: 0x809A6120 0x0041A930 0x0041A958 0x00427110

This definitely looks like a crash on TxBF configuration.


Michał

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: ath10k: first qca6174 hw2.1 firmware released
  2015-08-25  5:09       ` Michal Kazior
@ 2015-08-25 14:04         ` Lapo Calamandrei
  2015-08-26  5:01           ` Michal Kazior
  0 siblings, 1 reply; 9+ messages in thread
From: Lapo Calamandrei @ 2015-08-25 14:04 UTC (permalink / raw)
  To: Michal Kazior; +Cc: Kalle Valo, ath10k@lists.infradead.org

2015-08-25 7:09 GMT+02:00 Michal Kazior <michal.kazior@tieto.com>:
> On 24 August 2015 at 18:26, Lapo Calamandrei <calamandrei@gmail.com> wrote:
>> 2015-08-17 7:52 GMT+02:00 Michal Kazior <michal.kazior@tieto.com>:
>>> On 13 August 2015 at 16:00, Lapo Calamandrei <calamandrei@gmail.com> wrote:
>>>> 2015-08-13 12:31 GMT+02:00 Kalle Valo <kvalo@qca.qualcomm.com>:
>>>>> Hi,
>>>>>
>>>>> I just pushed the first qca6174  hw2.1 firmware to ath10k-firmware.git:
>>>>>
>>>>> https://github.com/kvalo/ath10k-firmware/commit/7f7e7dda33676ced293de477b03711199ffe5256
>>>>>
>>>>> Please test and provide feedback.
>>>>>
>>>>> --
>>>>> Kalle Valo
>>>>>
>>>>
>>>> Loads w/o skip_otp and works fine here (qca6174), except it crashes on
>>>> 5GHz network connection attempt as the one created from the window
>>>> drivers.
>>>
>>> Paste the crash register dump and `iw list` output, please.
>>>
>>>
>>> Michał
>>
>> Sorry for the late reply.
>>
>> Here's the iw list output:
> [...]
>>     Band 1:
>>         Capabilities: 0x19e3
>>             RX LDPC
>>             HT20/HT40
>>             Static SM Power Save
>>             RX HT20 SGI
>>             RX HT40 SGI
>>             TX STBC
>>             RX STBC 1-stream
>>             Max AMSDU length: 7935 bytes
>>             DSSS/CCK HT40
>>         Maximum RX AMPDU length 65535 bytes (exponent: 0x003)
>>         Minimum RX AMPDU time spacing: 8 usec (0x06)
>>         HT TX/RX MCS rate indexes supported: 0-15
>>         VHT Capabilities (0x339031b2):
>>             Max MPDU length: 11454
>>             Supported Channel Width: neither 160 nor 80+80
>>             RX LDPC
>>             short GI (80 MHz)
>>             TX STBC
>>             SU Beamformee
>>             MU Beamformee
>
> Is this with the change I suggested you earlier? I guess not. I don't
> think this firmware should advertise beamforming support.
>
> Can you re-try with patch from
> http://lists.infradead.org/pipermail/ath10k/2015-August/005774.html,
> please? If it still doesn't work please post `iw list` and the
> register dump.
>
> You can also try commenting out calls to ath10k_mac_vif_recalc_txbf() as plan B.
>
>
> [...]
>> Here's the register dump:
>>
>> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
>> firmware register dump:
>> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
>> [00]: 0x05010000 0x000015B3 0x00939797 0x00955B31
>> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
>> [04]: 0x00939797 0x00060330 0x00000000 0x00000000
>> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
>> [08]: 0x00413980 0x0000FFFF 0x00000000 0x00000000
>> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
>> [12]: 0x00000009 0xFFFFFFFF 0x0096C09C 0x0096C0A7
>> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
>> [16]: 0x0096BDBC 0x009287BD 0x00000000 0x009287BD
>> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
>> [20]: 0x40939797 0x0041A700 0x00407124 0x00000000
>> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
>> [24]: 0x8093D6C4 0x0041A760 0x004059D0 0xC0939797
>> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
>> [28]: 0x8094777F 0x0041A780 0x0046D5D8 0x00000001
>> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
>> [32]: 0x800AA427 0x0041A7B0 0x0046D5D8 0x00000001
>> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
>> [36]: 0x800AA58E 0x0041A7D0 0x00424824 0x00000001
>> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
>> [40]: 0x80994D90 0x0041A7F0 0x00424824 0x0041A838
>> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
>> [44]: 0x80996DC6 0x0041A820 0x0046F888 0x00412984
>> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
>> [48]: 0x800B43F5 0x0041A860 0x004222F8 0x00005008
>> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
>> [52]: 0x809A6ACC 0x0041A8F0 0x0042930C 0x0042CA24
>> ago 24 18:10:07 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
>> [56]: 0x809A6120 0x0041A930 0x0041A958 0x00427110
>
> This definitely looks like a crash on TxBF configuration.
>
>
> Michał

Yep, the previous crash was without your patch applied, the following
is with the patch applied though.

iw list output:

Wiphy phy0
    max # scan SSIDs: 16
    max scan IEs length: 195 bytes
    max # sched scan SSIDs: 0
    max # match sets: 0
    Retry short limit: 7
    Retry long limit: 4
    Coverage class: 0 (up to 0m)
    Device supports RSN-IBSS.
    Device supports AP-side u-APSD.
    Supported Ciphers:
        * WEP40 (00-0f-ac:1)
        * WEP104 (00-0f-ac:5)
        * TKIP (00-0f-ac:2)
        * CCMP (00-0f-ac:4)
        * CMAC (00-0f-ac:6)
    Available Antennas: TX 0x3 RX 0x3
    Configured Antennas: TX 0x3 RX 0x3
    Supported interface modes:
         * IBSS
         * managed
         * AP
         * AP/VLAN
         * monitor
         * P2P-client
         * P2P-GO
         * P2P-device
    Band 1:
        Capabilities: 0x19e3
            RX LDPC
            HT20/HT40
            Static SM Power Save
            RX HT20 SGI
            RX HT40 SGI
            TX STBC
            RX STBC 1-stream
            Max AMSDU length: 7935 bytes
            DSSS/CCK HT40
        Maximum RX AMPDU length 65535 bytes (exponent: 0x003)
        Minimum RX AMPDU time spacing: 8 usec (0x06)
        HT TX/RX MCS rate indexes supported: 0-15
        VHT Capabilities (0x339011b2):
            Max MPDU length: 11454
            Supported Channel Width: neither 160 nor 80+80
            RX LDPC
            short GI (80 MHz)
            TX STBC
            SU Beamformee
            MU Beamformee
            RX antenna pattern consistency
            TX antenna pattern consistency
        VHT RX MCS set:
            1 streams: MCS 0-9
            2 streams: MCS 0-9
            3 streams: not supported
            4 streams: not supported
            5 streams: not supported
            6 streams: not supported
            7 streams: not supported
            8 streams: not supported
        VHT RX highest supported: 0 Mbps
        VHT TX MCS set:
            1 streams: MCS 0-9
            2 streams: MCS 0-9
            3 streams: not supported
            4 streams: not supported
            5 streams: not supported
            6 streams: not supported
            7 streams: not supported
            8 streams: not supported
        VHT TX highest supported: 0 Mbps
        Bitrates (non-HT):
            * 1.0 Mbps
            * 2.0 Mbps (short preamble supported)
            * 5.5 Mbps (short preamble supported)
            * 11.0 Mbps (short preamble supported)
            * 6.0 Mbps
            * 9.0 Mbps
            * 12.0 Mbps
            * 18.0 Mbps
            * 24.0 Mbps
            * 36.0 Mbps
            * 48.0 Mbps
            * 54.0 Mbps
        Frequencies:
            * 2412 MHz [1] (20.0 dBm)
            * 2417 MHz [2] (20.0 dBm)
            * 2422 MHz [3] (20.0 dBm)
            * 2427 MHz [4] (20.0 dBm)
            * 2432 MHz [5] (20.0 dBm)
            * 2437 MHz [6] (20.0 dBm)
            * 2442 MHz [7] (20.0 dBm)
            * 2447 MHz [8] (20.0 dBm)
            * 2452 MHz [9] (20.0 dBm)
            * 2457 MHz [10] (20.0 dBm)
            * 2462 MHz [11] (20.0 dBm)
            * 2467 MHz [12] (20.0 dBm) (no IR)
            * 2472 MHz [13] (20.0 dBm) (no IR)
            * 2484 MHz [14] (disabled)
    Band 2:
        Capabilities: 0x19e3
            RX LDPC
            HT20/HT40
            Static SM Power Save
            RX HT20 SGI
            RX HT40 SGI
            TX STBC
            RX STBC 1-stream
            Max AMSDU length: 7935 bytes
            DSSS/CCK HT40
        Maximum RX AMPDU length 65535 bytes (exponent: 0x003)
        Minimum RX AMPDU time spacing: 8 usec (0x06)
        HT TX/RX MCS rate indexes supported: 0-15
        VHT Capabilities (0x339011b2):
            Max MPDU length: 11454
            Supported Channel Width: neither 160 nor 80+80
            RX LDPC
            short GI (80 MHz)
            TX STBC
            SU Beamformee
            MU Beamformee
            RX antenna pattern consistency
            TX antenna pattern consistency
        VHT RX MCS set:
            1 streams: MCS 0-9
            2 streams: MCS 0-9
            3 streams: not supported
            4 streams: not supported
            5 streams: not supported
            6 streams: not supported
            7 streams: not supported
            8 streams: not supported
        VHT RX highest supported: 0 Mbps
        VHT TX MCS set:
            1 streams: MCS 0-9
            2 streams: MCS 0-9
            3 streams: not supported
            4 streams: not supported
            5 streams: not supported
            6 streams: not supported
            7 streams: not supported
            8 streams: not supported
        VHT TX highest supported: 0 Mbps
        Bitrates (non-HT):
            * 6.0 Mbps
            * 9.0 Mbps
            * 12.0 Mbps
            * 18.0 Mbps
            * 24.0 Mbps
            * 36.0 Mbps
            * 48.0 Mbps
            * 54.0 Mbps
        Frequencies:
            * 5180 MHz [36] (20.0 dBm)
            * 5200 MHz [40] (20.0 dBm) (no IR)
            * 5220 MHz [44] (20.0 dBm) (no IR)
            * 5240 MHz [48] (20.0 dBm) (no IR)
            * 5260 MHz [52] (20.0 dBm) (no IR, radar detection)
              DFS state: usable (for 63 sec)
              DFS CAC time: 60000 ms
            * 5280 MHz [56] (20.0 dBm) (no IR, radar detection)
              DFS state: usable (for 63 sec)
              DFS CAC time: 60000 ms
            * 5300 MHz [60] (20.0 dBm) (no IR, radar detection)
              DFS state: usable (for 63 sec)
              DFS CAC time: 60000 ms
            * 5320 MHz [64] (20.0 dBm) (no IR, radar detection)
              DFS state: usable (for 63 sec)
              DFS CAC time: 60000 ms
            * 5500 MHz [100] (27.0 dBm) (no IR, radar detection)
              DFS state: usable (for 63 sec)
              DFS CAC time: 60000 ms
            * 5520 MHz [104] (27.0 dBm) (no IR, radar detection)
              DFS state: usable (for 63 sec)
              DFS CAC time: 60000 ms
            * 5540 MHz [108] (27.0 dBm) (no IR, radar detection)
              DFS state: usable (for 63 sec)
              DFS CAC time: 60000 ms
            * 5560 MHz [112] (27.0 dBm) (no IR, radar detection)
              DFS state: usable (for 63 sec)
              DFS CAC time: 60000 ms
            * 5580 MHz [116] (27.0 dBm) (no IR, radar detection)
              DFS state: usable (for 63 sec)
              DFS CAC time: 60000 ms
            * 5600 MHz [120] (27.0 dBm) (no IR, radar detection)
              DFS state: usable (for 63 sec)
              DFS CAC time: 60000 ms
            * 5620 MHz [124] (27.0 dBm) (no IR, radar detection)
              DFS state: usable (for 63 sec)
              DFS CAC time: 60000 ms
            * 5640 MHz [128] (27.0 dBm) (no IR, radar detection)
              DFS state: usable (for 63 sec)
              DFS CAC time: 60000 ms
            * 5660 MHz [132] (27.0 dBm) (no IR, radar detection)
              DFS state: usable (for 63 sec)
              DFS CAC time: 60000 ms
            * 5680 MHz [136] (27.0 dBm) (no IR, radar detection)
              DFS state: usable (for 63 sec)
              DFS CAC time: 60000 ms
            * 5700 MHz [140] (27.0 dBm) (no IR, radar detection)
              DFS state: usable (for 63 sec)
              DFS CAC time: 60000 ms
            * 5720 MHz [144] (disabled)
            * 5745 MHz [149] (disabled)
            * 5765 MHz [153] (disabled)
            * 5785 MHz [157] (disabled)
            * 5805 MHz [161] (disabled)
            * 5825 MHz [165] (disabled)
    Supported commands:
         * new_interface
         * set_interface
         * new_key
         * start_ap
         * new_station
         * new_mpath
         * set_mesh_config
         * set_bss
         * authenticate
         * associate
         * deauthenticate
         * disassociate
         * join_ibss
         * join_mesh
         * remain_on_channel
         * set_tx_bitrate_mask
         * frame
         * frame_wait_cancel
         * set_wiphy_netns
         * set_channel
         * set_wds_peer
         * probe_client
         * set_noack_map
         * register_beacons
         * start_p2p_device
         * set_mcast_rate
         * channel_switch
         * set_qos_map
         * connect
         * disconnect
    Supported TX frame types:
         * IBSS: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90
0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
         * managed: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90
0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
         * AP: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90 0xa0
0xb0 0xc0 0xd0 0xe0 0xf0
         * AP/VLAN: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90
0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
         * mesh point: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80
0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
         * P2P-client: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80
0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
         * P2P-GO: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90
0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
         * P2P-device: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80
0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
    Supported RX frame types:
         * IBSS: 0x40 0xb0 0xc0 0xd0
         * managed: 0x40 0xd0
         * AP: 0x00 0x20 0x40 0xa0 0xb0 0xc0 0xd0
         * AP/VLAN: 0x00 0x20 0x40 0xa0 0xb0 0xc0 0xd0
         * mesh point: 0xb0 0xc0 0xd0
         * P2P-client: 0x40 0xd0
         * P2P-GO: 0x00 0x20 0x40 0xa0 0xb0 0xc0 0xd0
         * P2P-device: 0x40 0xd0
    software interface modes (can always be added):
         * AP/VLAN
         * monitor
    valid interface combinations:
         * #{ managed } <= 2, #{ AP, P2P-client, P2P-GO } <= 2, #{
P2P-device } <= 1,
           total <= 4, #channels <= 1
         * #{ managed } <= 2, #{ P2P-client } <= 2, #{ AP, P2P-GO } <=
1, #{ P2P-device } <= 1,
           total <= 4, #channels <= 2
         * #{ managed } <= 1, #{ IBSS } <= 1,
           total <= 2, #channels <= 1
    HT Capability overrides:
         * MCS: ff ff ff ff ff ff ff ff ff ff
         * maximum A-MSDU length
         * supported channel width
         * short GI for 40 MHz
         * max A-MPDU length exponent
         * min MPDU start spacing
    Device supports TX status socket option.
    Device supports HT-IBSS.
    Device supports SAE with AUTHENTICATE command
    Device supports scan flush.
    Device supports per-vif TX power setting
    Driver supports a userspace MPM
    Driver/device bandwidth changes during BSS lifetime (AP/GO mode)
    Device supports static SMPS
    Device supports configuring vdev MAC-addr on create.
    Device supports VHT-IBSS.

Register dump:

ago 25 15:57:53 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[00]: 0x05010000 0x000015B3 0x00939797 0x00955B31
ago 25 15:57:53 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[04]: 0x00939797 0x00060330 0x00000000 0x00000000
ago 25 15:57:53 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[08]: 0x00413980 0x0000FFFF 0x00000000 0x00000000
ago 25 15:57:53 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[12]: 0x00000009 0xFFFFFFFF 0x0096C09C 0x0096C0A7
ago 25 15:57:53 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[16]: 0x0096BDBC 0x009287BD 0x00000000 0x00000000
ago 25 15:57:53 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[20]: 0x40939797 0x0041A700 0x00407124 0x00000000
ago 25 15:57:53 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[24]: 0x8093D6C4 0x0041A760 0x004059D0 0xC0939797
ago 25 15:57:53 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[28]: 0x8094777F 0x0041A780 0x0046D5D8 0x00000001
ago 25 15:57:53 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[32]: 0x800AA427 0x0041A7B0 0x0046D5D8 0x00000001
ago 25 15:57:53 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[36]: 0x800AA58E 0x0041A7D0 0x00424824 0x00000001
ago 25 15:57:53 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[40]: 0x80994D90 0x0041A7F0 0x00424824 0x0041A838
ago 25 15:57:53 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[44]: 0x80996DC6 0x0041A820 0x0046F888 0x00412984
ago 25 15:57:53 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[48]: 0x800B43F5 0x0041A860 0x004222F8 0x00005008
ago 25 15:57:53 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[52]: 0x809A6ACC 0x0041A8F0 0x0042930C 0x0042CA24
ago 25 15:57:53 localhost.localdomain kernel: ath10k_pci 0000:03:00.0:
[56]: 0x809A6120 0x0041A930 0x0041A954 0x00427110



Ciao
Lapo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: ath10k: first qca6174 hw2.1 firmware released
  2015-08-25 14:04         ` Lapo Calamandrei
@ 2015-08-26  5:01           ` Michal Kazior
  2015-08-26 10:05             ` Lapo Calamandrei
  0 siblings, 1 reply; 9+ messages in thread
From: Michal Kazior @ 2015-08-26  5:01 UTC (permalink / raw)
  To: Lapo Calamandrei; +Cc: Kalle Valo, ath10k@lists.infradead.org

On 25 August 2015 at 16:04, Lapo Calamandrei <calamandrei@gmail.com> wrote:
[...]
> Yep, the previous crash was without your patch applied, the following
> is with the patch applied though.
>
> iw list output:
[...]
>     Band 2:
>         Capabilities: 0x19e3
>             RX LDPC
>             HT20/HT40
>             Static SM Power Save
>             RX HT20 SGI
>             RX HT40 SGI
>             TX STBC
>             RX STBC 1-stream
>             Max AMSDU length: 7935 bytes
>             DSSS/CCK HT40
>         Maximum RX AMPDU length 65535 bytes (exponent: 0x003)
>         Minimum RX AMPDU time spacing: 8 usec (0x06)
>         HT TX/RX MCS rate indexes supported: 0-15
>         VHT Capabilities (0x339011b2):
>             Max MPDU length: 11454
>             Supported Channel Width: neither 160 nor 80+80
>             RX LDPC
>             short GI (80 MHz)
>             TX STBC
>             SU Beamformee
>             MU Beamformee
[...]

Sorry, my bad. The diff I provided earlier wasn't correct (it was a
quick hack-idea I didn't test myself).

The correct thing that should work is:

--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -6798,27 +6798,14 @@ static struct ieee80211_sta_vht_cap
ath10k_create_vht_cap(struct ath10k *ar)
        u32 val;
        int i;

+       ar->vht_cap_info &= ~(IEEE80211_VHT_CAP_SU_BEAMFORMEE_CAPABLE |
+                             IEEE80211_VHT_CAP_MU_BEAMFORMEE_CAPABLE |
+                             IEEE80211_VHT_CAP_SU_BEAMFORMER_CAPABLE |
+                             IEEE80211_VHT_CAP_MU_BEAMFORMER_CAPABLE);
+
        vht_cap.vht_supported = 1;
        vht_cap.cap = ar->vht_cap_info;

-       if (ar->vht_cap_info & (IEEE80211_VHT_CAP_SU_BEAMFORMEE_CAPABLE |
-                               IEEE80211_VHT_CAP_MU_BEAMFORMEE_CAPABLE)) {
-               val = ar->num_rf_chains - 1;
-               val <<= IEEE80211_VHT_CAP_BEAMFORMEE_STS_SHIFT;
-               val &= IEEE80211_VHT_CAP_BEAMFORMEE_STS_MASK;
-
-               vht_cap.cap |= val;
-       }
-
-       if (ar->vht_cap_info & (IEEE80211_VHT_CAP_SU_BEAMFORMER_CAPABLE |
-                               IEEE80211_VHT_CAP_MU_BEAMFORMER_CAPABLE)) {
-               val = ar->num_rf_chains - 1;
-               val <<= IEEE80211_VHT_CAP_SOUNDING_DIMENSIONS_SHIFT;
-               val &= IEEE80211_VHT_CAP_SOUNDING_DIMENSIONS_MASK;
-
-               vht_cap.cap |= val;
-       }
-
        mcs_map = 0;
        for (i = 0; i < 8; i++) {
                if (i < ar->num_rf_chains)


Michał

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: ath10k: first qca6174 hw2.1 firmware released
  2015-08-26  5:01           ` Michal Kazior
@ 2015-08-26 10:05             ` Lapo Calamandrei
  2015-08-26 10:12               ` Michal Kazior
  0 siblings, 1 reply; 9+ messages in thread
From: Lapo Calamandrei @ 2015-08-26 10:05 UTC (permalink / raw)
  To: Michal Kazior; +Cc: Kalle Valo, ath10k@lists.infradead.org

2015-08-26 7:01 GMT+02:00 Michal Kazior <michal.kazior@tieto.com>:
> On 25 August 2015 at 16:04, Lapo Calamandrei <calamandrei@gmail.com> wrote:
> [...]
>> Yep, the previous crash was without your patch applied, the following
>> is with the patch applied though.
>>
>> iw list output:
> [...]
>>     Band 2:
>>         Capabilities: 0x19e3
>>             RX LDPC
>>             HT20/HT40
>>             Static SM Power Save
>>             RX HT20 SGI
>>             RX HT40 SGI
>>             TX STBC
>>             RX STBC 1-stream
>>             Max AMSDU length: 7935 bytes
>>             DSSS/CCK HT40
>>         Maximum RX AMPDU length 65535 bytes (exponent: 0x003)
>>         Minimum RX AMPDU time spacing: 8 usec (0x06)
>>         HT TX/RX MCS rate indexes supported: 0-15
>>         VHT Capabilities (0x339011b2):
>>             Max MPDU length: 11454
>>             Supported Channel Width: neither 160 nor 80+80
>>             RX LDPC
>>             short GI (80 MHz)
>>             TX STBC
>>             SU Beamformee
>>             MU Beamformee
> [...]
>
> Sorry, my bad. The diff I provided earlier wasn't correct (it was a
> quick hack-idea I didn't test myself).
>
> The correct thing that should work is:
>
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -6798,27 +6798,14 @@ static struct ieee80211_sta_vht_cap
> ath10k_create_vht_cap(struct ath10k *ar)
>         u32 val;
>         int i;
>
> +       ar->vht_cap_info &= ~(IEEE80211_VHT_CAP_SU_BEAMFORMEE_CAPABLE |
> +                             IEEE80211_VHT_CAP_MU_BEAMFORMEE_CAPABLE |
> +                             IEEE80211_VHT_CAP_SU_BEAMFORMER_CAPABLE |
> +                             IEEE80211_VHT_CAP_MU_BEAMFORMER_CAPABLE);
> +
>         vht_cap.vht_supported = 1;
>         vht_cap.cap = ar->vht_cap_info;
>
> -       if (ar->vht_cap_info & (IEEE80211_VHT_CAP_SU_BEAMFORMEE_CAPABLE |
> -                               IEEE80211_VHT_CAP_MU_BEAMFORMEE_CAPABLE)) {
> -               val = ar->num_rf_chains - 1;
> -               val <<= IEEE80211_VHT_CAP_BEAMFORMEE_STS_SHIFT;
> -               val &= IEEE80211_VHT_CAP_BEAMFORMEE_STS_MASK;
> -
> -               vht_cap.cap |= val;
> -       }
> -
> -       if (ar->vht_cap_info & (IEEE80211_VHT_CAP_SU_BEAMFORMER_CAPABLE |
> -                               IEEE80211_VHT_CAP_MU_BEAMFORMER_CAPABLE)) {
> -               val = ar->num_rf_chains - 1;
> -               val <<= IEEE80211_VHT_CAP_SOUNDING_DIMENSIONS_SHIFT;
> -               val &= IEEE80211_VHT_CAP_SOUNDING_DIMENSIONS_MASK;
> -
> -               vht_cap.cap |= val;
> -       }
> -
>         mcs_map = 0;
>         for (i = 0; i < 8; i++) {
>                 if (i < ar->num_rf_chains)
>
>
> Michał

The firmware crash is gone now, thanks. Do you need any kind of
additional tests on this hw I can do?

Ciao
Lapo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: ath10k: first qca6174 hw2.1 firmware released
  2015-08-26 10:05             ` Lapo Calamandrei
@ 2015-08-26 10:12               ` Michal Kazior
  0 siblings, 0 replies; 9+ messages in thread
From: Michal Kazior @ 2015-08-26 10:12 UTC (permalink / raw)
  To: Lapo Calamandrei; +Cc: Kalle Valo, ath10k@lists.infradead.org

On 26 August 2015 at 12:05, Lapo Calamandrei <calamandrei@gmail.com> wrote:
> 2015-08-26 7:01 GMT+02:00 Michal Kazior <michal.kazior@tieto.com>:
>> On 25 August 2015 at 16:04, Lapo Calamandrei <calamandrei@gmail.com> wrote:
>> [...]
>>> Yep, the previous crash was without your patch applied, the following
>>> is with the patch applied though.
>>>
>>> iw list output:
>> [...]
>>>     Band 2:
>>>         Capabilities: 0x19e3
>>>             RX LDPC
>>>             HT20/HT40
>>>             Static SM Power Save
>>>             RX HT20 SGI
>>>             RX HT40 SGI
>>>             TX STBC
>>>             RX STBC 1-stream
>>>             Max AMSDU length: 7935 bytes
>>>             DSSS/CCK HT40
>>>         Maximum RX AMPDU length 65535 bytes (exponent: 0x003)
>>>         Minimum RX AMPDU time spacing: 8 usec (0x06)
>>>         HT TX/RX MCS rate indexes supported: 0-15
>>>         VHT Capabilities (0x339011b2):
>>>             Max MPDU length: 11454
>>>             Supported Channel Width: neither 160 nor 80+80
>>>             RX LDPC
>>>             short GI (80 MHz)
>>>             TX STBC
>>>             SU Beamformee
>>>             MU Beamformee
>> [...]
>>
>> Sorry, my bad. The diff I provided earlier wasn't correct (it was a
>> quick hack-idea I didn't test myself).
>>
>> The correct thing that should work is:
>>
>> --- a/drivers/net/wireless/ath/ath10k/mac.c
>> +++ b/drivers/net/wireless/ath/ath10k/mac.c
>> @@ -6798,27 +6798,14 @@ static struct ieee80211_sta_vht_cap
>> ath10k_create_vht_cap(struct ath10k *ar)
>>         u32 val;
>>         int i;
>>
>> +       ar->vht_cap_info &= ~(IEEE80211_VHT_CAP_SU_BEAMFORMEE_CAPABLE |
>> +                             IEEE80211_VHT_CAP_MU_BEAMFORMEE_CAPABLE |
>> +                             IEEE80211_VHT_CAP_SU_BEAMFORMER_CAPABLE |
>> +                             IEEE80211_VHT_CAP_MU_BEAMFORMER_CAPABLE);
>> +
>>         vht_cap.vht_supported = 1;
>>         vht_cap.cap = ar->vht_cap_info;
>>
>> -       if (ar->vht_cap_info & (IEEE80211_VHT_CAP_SU_BEAMFORMEE_CAPABLE |
>> -                               IEEE80211_VHT_CAP_MU_BEAMFORMEE_CAPABLE)) {
>> -               val = ar->num_rf_chains - 1;
>> -               val <<= IEEE80211_VHT_CAP_BEAMFORMEE_STS_SHIFT;
>> -               val &= IEEE80211_VHT_CAP_BEAMFORMEE_STS_MASK;
>> -
>> -               vht_cap.cap |= val;
>> -       }
>> -
>> -       if (ar->vht_cap_info & (IEEE80211_VHT_CAP_SU_BEAMFORMER_CAPABLE |
>> -                               IEEE80211_VHT_CAP_MU_BEAMFORMER_CAPABLE)) {
>> -               val = ar->num_rf_chains - 1;
>> -               val <<= IEEE80211_VHT_CAP_SOUNDING_DIMENSIONS_SHIFT;
>> -               val &= IEEE80211_VHT_CAP_SOUNDING_DIMENSIONS_MASK;
>> -
>> -               vht_cap.cap |= val;
>> -       }
>> -
>>         mcs_map = 0;
>>         for (i = 0; i < 8; i++) {
>>                 if (i < ar->num_rf_chains)
>>
>>
>> Michał
>
> The firmware crash is gone now, thanks.

Awesome. Thanks for testing!


> Do you need any kind of
> additional tests on this hw I can do?

No, thanks.


Michał

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2015-08-26 10:12 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-13 10:31 ath10k: first qca6174 hw2.1 firmware released Kalle Valo
2015-08-13 14:00 ` Lapo Calamandrei
2015-08-17  5:52   ` Michal Kazior
2015-08-24 16:26     ` Lapo Calamandrei
2015-08-25  5:09       ` Michal Kazior
2015-08-25 14:04         ` Lapo Calamandrei
2015-08-26  5:01           ` Michal Kazior
2015-08-26 10:05             ` Lapo Calamandrei
2015-08-26 10:12               ` Michal Kazior

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox