* [PATCH] wifi: ath12k: drop NULL pointer check in ath12k_update_per_peer_tx_stats()
@ 2023-10-13 7:47 Ma Ke
2023-10-25 9:56 ` Kalle Valo
2023-10-31 7:45 ` Kalle Valo
0 siblings, 2 replies; 4+ messages in thread
From: Ma Ke @ 2023-10-13 7:47 UTC (permalink / raw)
To: kvalo, quic_jjohnson; +Cc: ath12k, linux-wireless, linux-kernel, Ma Ke
Since 'user_stats' is a fixed-size array of 'struct htt_ppdu_user_stats'
in 'struct htt_ppdu_stats', any of its member can't be NULL and so
relevant check may be dropped.
Signed-off-by: Ma Ke <make_ruc2021@163.com>
---
drivers/net/wireless/ath/ath12k/dp_rx.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/dp_rx.c b/drivers/net/wireless/ath/ath12k/dp_rx.c
index e6e64d437c47..a38a239669a8 100644
--- a/drivers/net/wireless/ath/ath12k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath12k/dp_rx.c
@@ -1339,9 +1339,6 @@ ath12k_update_per_peer_tx_stats(struct ath12k *ar,
u8 tid = HTT_PPDU_STATS_NON_QOS_TID;
bool is_ampdu = false;
- if (!usr_stats)
- return;
-
if (!(usr_stats->tlv_flags & BIT(HTT_PPDU_STATS_TAG_USR_RATE)))
return;
--
2.37.2
--
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] wifi: ath12k: drop NULL pointer check in ath12k_update_per_peer_tx_stats()
2023-10-13 7:47 [PATCH] wifi: ath12k: drop NULL pointer check in ath12k_update_per_peer_tx_stats() Ma Ke
@ 2023-10-25 9:56 ` Kalle Valo
2023-10-25 15:57 ` Jeff Johnson
2023-10-31 7:45 ` Kalle Valo
1 sibling, 1 reply; 4+ messages in thread
From: Kalle Valo @ 2023-10-25 9:56 UTC (permalink / raw)
To: Ma Ke; +Cc: quic_jjohnson, ath12k, linux-wireless, linux-kernel, Ma Ke
Ma Ke <make_ruc2021@163.com> wrote:
> Since 'user_stats' is a fixed-size array of 'struct htt_ppdu_user_stats'
> in 'struct htt_ppdu_stats', any of its member can't be NULL and so
> relevant check may be dropped.
>
> Signed-off-by: Ma Ke <make_ruc2021@163.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Jeff, what do you think?
--
https://patchwork.kernel.org/project/linux-wireless/patch/20231013074711.2202850-1-make_ruc2021@163.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] wifi: ath12k: drop NULL pointer check in ath12k_update_per_peer_tx_stats()
2023-10-25 9:56 ` Kalle Valo
@ 2023-10-25 15:57 ` Jeff Johnson
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Johnson @ 2023-10-25 15:57 UTC (permalink / raw)
To: Kalle Valo, Ma Ke; +Cc: ath12k, linux-wireless, linux-kernel
On 10/25/2023 2:56 AM, Kalle Valo wrote:
> Ma Ke <make_ruc2021@163.com> wrote:
>
>> Since 'user_stats' is a fixed-size array of 'struct htt_ppdu_user_stats'
>> in 'struct htt_ppdu_stats', any of its member can't be NULL and so
>> relevant check may be dropped.
>>
>> Signed-off-by: Ma Ke <make_ruc2021@163.com>
>> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
>
> Jeff, what do you think?
>
look correct,
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
--
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] wifi: ath12k: drop NULL pointer check in ath12k_update_per_peer_tx_stats()
2023-10-13 7:47 [PATCH] wifi: ath12k: drop NULL pointer check in ath12k_update_per_peer_tx_stats() Ma Ke
2023-10-25 9:56 ` Kalle Valo
@ 2023-10-31 7:45 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2023-10-31 7:45 UTC (permalink / raw)
To: Ma Ke; +Cc: quic_jjohnson, ath12k, linux-wireless, linux-kernel, Ma Ke
Ma Ke <make_ruc2021@163.com> wrote:
> Since 'user_stats' is a fixed-size array of 'struct htt_ppdu_user_stats'
> in 'struct htt_ppdu_stats', any of its member can't be NULL and so
> relevant check may be dropped.
>
> Signed-off-by: Ma Ke <make_ruc2021@163.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
56d9854bd7c6 wifi: ath12k: drop NULL pointer check in ath12k_update_per_peer_tx_stats()
--
https://patchwork.kernel.org/project/linux-wireless/patch/20231013074711.2202850-1-make_ruc2021@163.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-31 7:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-13 7:47 [PATCH] wifi: ath12k: drop NULL pointer check in ath12k_update_per_peer_tx_stats() Ma Ke
2023-10-25 9:56 ` Kalle Valo
2023-10-25 15:57 ` Jeff Johnson
2023-10-31 7:45 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox