[PATCH] wifi: ath12k: drop NULL pointer check in ath12k_update_per_peer_tx_stats()

[PATCH] wifi: ath12k: drop NULL pointer check in ath12k_update_per_peer_tx_stats()

[Ma Ke]

Since 'user_stats' is a fixed-size array of 'struct htt_ppdu_user_stats'
in 'struct htt_ppdu_stats', any of its member can't be NULL and so
relevant check may be dropped.

Signed-off-by: Ma Ke <make_ruc2021@163.com>
---
 drivers/net/wireless/ath/ath12k/dp_rx.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath12k/dp_rx.c b/drivers/net/wireless/ath/ath12k/dp_rx.c
index e6e64d437c47..a38a239669a8 100644
--- a/drivers/net/wireless/ath/ath12k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath12k/dp_rx.c
@@ -1339,9 +1339,6 @@ ath12k_update_per_peer_tx_stats(struct ath12k *ar,
 	u8 tid = HTT_PPDU_STATS_NON_QOS_TID;
 	bool is_ampdu = false;
 
-	if (!usr_stats)
-		return;
-
 	if (!(usr_stats->tlv_flags & BIT(HTT_PPDU_STATS_TAG_USR_RATE)))
 		return;
 
-- 
2.37.2


-- 
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k

Re: [PATCH] wifi: ath12k: drop NULL pointer check in ath12k_update_per_peer_tx_stats()

[Kalle Valo]

Ma Ke <make_ruc2021@163.com> wrote:

> Since 'user_stats' is a fixed-size array of 'struct htt_ppdu_user_stats'
> in 'struct htt_ppdu_stats', any of its member can't be NULL and so
> relevant check may be dropped.
> 
> Signed-off-by: Ma Ke <make_ruc2021@163.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Jeff, what do you think?

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20231013074711.2202850-1-make_ruc2021@163.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


-- 
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k

Re: [PATCH] wifi: ath12k: drop NULL pointer check in ath12k_update_per_peer_tx_stats()

[Jeff Johnson]

On 10/25/2023 2:56 AM, Kalle Valo wrote:
> Ma Ke <make_ruc2021@163.com> wrote:
> 
>> Since 'user_stats' is a fixed-size array of 'struct htt_ppdu_user_stats'
>> in 'struct htt_ppdu_stats', any of its member can't be NULL and so
>> relevant check may be dropped.
>>
>> Signed-off-by: Ma Ke <make_ruc2021@163.com>
>> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
> 
> Jeff, what do you think?
> 
look correct,
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>


-- 
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k

Re: [PATCH] wifi: ath12k: drop NULL pointer check in ath12k_update_per_peer_tx_stats()

[Kalle Valo]

Ma Ke <make_ruc2021@163.com> wrote:

> Since 'user_stats' is a fixed-size array of 'struct htt_ppdu_user_stats'
> in 'struct htt_ppdu_stats', any of its member can't be NULL and so
> relevant check may be dropped.
> 
> Signed-off-by: Ma Ke <make_ruc2021@163.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

56d9854bd7c6 wifi: ath12k: drop NULL pointer check in ath12k_update_per_peer_tx_stats()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20231013074711.2202850-1-make_ruc2021@163.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


-- 
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k