From: Andrew Lunn <andrew@lunn.ch>
To: Sven Eckelmann <sven@narfation.org>
Cc: b.a.t.m.a.n@lists.open-mesh.org,
Antonio Quartulli <a@unstable.cc>,
mareklindner@neomailbox.ch
Subject: Re: [B.A.T.M.A.N.] [PATCH v6 00/11] netns and netlink support
Date: Mon, 16 May 2016 22:06:37 +0200 [thread overview]
Message-ID: <20160516200637.GB3738@lunn.ch> (raw)
In-Reply-To: <33261549.crZoJBqqoP@sven-edge>
On Mon, May 16, 2016 at 08:58:13PM +0200, Sven Eckelmann wrote:
> On Monday 16 May 2016 19:27:58 Andrew Lunn wrote:
> > * No change to code indentation. I consider it a false positive. The
> > code is more readable the way it is, checkpatch is happy, and it
> > does not violate anything in CodingStyle, as far as i can see.
>
> @Antonio, @Marek, @Simon: Do you want to allow free-form alignments like this?
>
> if (batadv_iv_ogm_neigh_dump_hardif(
> msg, portid, cb->nlh->nlmsg_seq,
> bat_priv, hard_iface, &idx)) {
> i_hardif--;
> break;
> }
It is not fully free-form, however i cannot tell you exactly where it
comes from. If you have emacs do auto indent, using the linux kernel
indentation style, that is where emacs puts it.
Andrew
prev parent reply other threads:[~2016-05-16 20:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 17:27 [B.A.T.M.A.N.] [PATCH v6 00/11] netns and netlink support Andrew Lunn
2016-05-16 17:27 ` [B.A.T.M.A.N.] [PATCH v6 01/11] batman-adv: Handle parent interfaces in a different netns Andrew Lunn
2016-05-17 6:33 ` Sven Eckelmann
2016-05-17 12:18 ` Andrew Lunn
2016-05-17 12:22 ` Sven Eckelmann
2016-05-17 12:38 ` Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 02/11] batman-adv: Suppress debugfs entries for netns's Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 03/11] batman-adv: netlink: add routing_algo query Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 04/11] batman-adv: netlink: hardif query Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 05/11] batman-adv: netlink: add translation table query Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 06/11] batman-adv: netlink: add originator and neighbor table queries Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 07/11] batman-adv: add B.A.T.M.A.N. IV bat_{orig, neigh}_dump implementations Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 08/11] batman-adv: add B.A.T.M.A.N. V " Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 09/11] batman-adv: add B.A.T.M.A.N. Dump gateways via netlink Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 10/11] batman-adv: add B.A.T.M.A.N. Dump BLA claims " Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 11/11] batman-adv: Indicate netlink socket can be used with netns Andrew Lunn
2016-05-16 18:58 ` [B.A.T.M.A.N.] [PATCH v6 00/11] netns and netlink support Sven Eckelmann
2016-05-16 20:06 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160516200637.GB3738@lunn.ch \
--to=andrew@lunn.ch \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=mareklindner@neomailbox.ch \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox