From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Antonio Quartulli <a@unstable.cc>, mareklindner@neomailbox.ch
Subject: Re: [B.A.T.M.A.N.] [PATCH v6 00/11] netns and netlink support
Date: Mon, 16 May 2016 20:58:13 +0200 [thread overview]
Message-ID: <33261549.crZoJBqqoP@sven-edge> (raw)
In-Reply-To: <1463419689-3580-1-git-send-email-andrew@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]
On Monday 16 May 2016 19:27:58 Andrew Lunn wrote:
> * No change to code indentation. I consider it a false positive. The
> code is more readable the way it is, checkpatch is happy, and it
> does not violate anything in CodingStyle, as far as i can see.
@Antonio, @Marek, @Simon: Do you want to allow free-form alignments like this?
if (batadv_iv_ogm_neigh_dump_hardif(
msg, portid, cb->nlh->nlmsg_seq,
bat_priv, hard_iface, &idx)) {
i_hardif--;
break;
}
I just know that this strict form was requested [1] (enforced!!!) by the
Linux net maintainer David Miller (and some other people but I just link
this because the discussion got really "juicy").
And to your "no change to code indentation". There is definitely one in your
latest patchset. It introduces a new free-form alignment to
batadv_iv_ogm_neigh_dump
if (i_hardif_s == 0) {
if (batadv_iv_ogm_neigh_dump_hardif(
msg, portid, cb->nlh->nlmsg_seq,
bat_priv, single_hardif, &idx) == 0)
i_hardif++;
}
Kind regards,
Sven
[1] https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2011-December/005932.html
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-16 18:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 17:27 [B.A.T.M.A.N.] [PATCH v6 00/11] netns and netlink support Andrew Lunn
2016-05-16 17:27 ` [B.A.T.M.A.N.] [PATCH v6 01/11] batman-adv: Handle parent interfaces in a different netns Andrew Lunn
2016-05-17 6:33 ` Sven Eckelmann
2016-05-17 12:18 ` Andrew Lunn
2016-05-17 12:22 ` Sven Eckelmann
2016-05-17 12:38 ` Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 02/11] batman-adv: Suppress debugfs entries for netns's Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 03/11] batman-adv: netlink: add routing_algo query Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 04/11] batman-adv: netlink: hardif query Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 05/11] batman-adv: netlink: add translation table query Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 06/11] batman-adv: netlink: add originator and neighbor table queries Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 07/11] batman-adv: add B.A.T.M.A.N. IV bat_{orig, neigh}_dump implementations Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 08/11] batman-adv: add B.A.T.M.A.N. V " Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 09/11] batman-adv: add B.A.T.M.A.N. Dump gateways via netlink Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 10/11] batman-adv: add B.A.T.M.A.N. Dump BLA claims " Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 11/11] batman-adv: Indicate netlink socket can be used with netns Andrew Lunn
2016-05-16 18:58 ` Sven Eckelmann [this message]
2016-05-16 20:06 ` [B.A.T.M.A.N.] [PATCH v6 00/11] netns and netlink support Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33261549.crZoJBqqoP@sven-edge \
--to=sven@narfation.org \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=mareklindner@neomailbox.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox