From: Sven Eckelmann <sven@narfation.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "B.A.T.M.A.N" <b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH v6 01/11] batman-adv: Handle parent interfaces in a different netns
Date: Tue, 17 May 2016 08:33:06 +0200 [thread overview]
Message-ID: <2256828.JfWKWoeer9@sven-edge> (raw)
In-Reply-To: <1463419689-3580-2-git-send-email-andrew@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]
On Monday 16 May 2016 19:27:59 Andrew Lunn wrote:
> +#if LINUX_VERSION_CODE < KERNEL_VERSION(4, 0, 0)
> +
> +/* WARNING for batadv_getlink_net */
> +#define get_link_net get_xstats_size || 0 || netdev->rtnl_link_ops-
>get_xstats_size
> +
> +#endif /* < KERNEL_VERSION(4, 0, 0) */
This should be "|| 1 ||" to enforce the immediate return in the function
batadv_get_link_net. This was also the version submitted to gather some
comments [1] about the compat-hack.
* v2 had "|| 1 ||": https://patchwork.open-mesh.org/patch/16003/
* v3 had "|| 0 ||": https://patchwork.open-mesh.org/patch/16024/
I think I removed this multiple times but this misalignment seems to be
immortal:
> return (dev1_parent_iflink == dev2->ifindex) &&
> - (dev2_parent_iflink == dev1->ifindex);
> + (dev2_parent_iflink == dev1->ifindex) &&
> + net_eq(dev1_parent_net, net2) &&
> + net_eq(dev2_parent_net, net1);
Kind regards,
Sven
[1] https://patchwork.open-mesh.org/patch/15996/
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-17 6:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 17:27 [B.A.T.M.A.N.] [PATCH v6 00/11] netns and netlink support Andrew Lunn
2016-05-16 17:27 ` [B.A.T.M.A.N.] [PATCH v6 01/11] batman-adv: Handle parent interfaces in a different netns Andrew Lunn
2016-05-17 6:33 ` Sven Eckelmann [this message]
2016-05-17 12:18 ` Andrew Lunn
2016-05-17 12:22 ` Sven Eckelmann
2016-05-17 12:38 ` Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 02/11] batman-adv: Suppress debugfs entries for netns's Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 03/11] batman-adv: netlink: add routing_algo query Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 04/11] batman-adv: netlink: hardif query Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 05/11] batman-adv: netlink: add translation table query Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 06/11] batman-adv: netlink: add originator and neighbor table queries Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 07/11] batman-adv: add B.A.T.M.A.N. IV bat_{orig, neigh}_dump implementations Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 08/11] batman-adv: add B.A.T.M.A.N. V " Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 09/11] batman-adv: add B.A.T.M.A.N. Dump gateways via netlink Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 10/11] batman-adv: add B.A.T.M.A.N. Dump BLA claims " Andrew Lunn
2016-05-16 17:28 ` [B.A.T.M.A.N.] [PATCH v6 11/11] batman-adv: Indicate netlink socket can be used with netns Andrew Lunn
2016-05-16 18:58 ` [B.A.T.M.A.N.] [PATCH v6 00/11] netns and netlink support Sven Eckelmann
2016-05-16 20:06 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2256828.JfWKWoeer9@sven-edge \
--to=sven@narfation.org \
--cc=andrew@lunn.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox