From: Sven Eckelmann <sven@narfation.org>
To: Antonio Quartulli <a@unstable.cc>
Cc: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>,
Andre Kasper <Andre.Kasper@gmx.de>,
linus.luessing@c0d3.blue
Subject: Re: [B.A.T.M.A.N.] [PATCH] batctl: Validate translated mac addresses
Date: Sat, 14 Apr 2018 11:20:06 +0200 [thread overview]
Message-ID: <6325045.lEza1471pb@sven-edge> (raw)
In-Reply-To: <af29c3fe-d25e-51d2-7ca1-47738f25ab7a@unstable.cc>
[-- Attachment #1: Type: text/plain, Size: 756 bytes --]
On Samstag, 14. April 2018 10:11:28 CEST Antonio Quartulli wrote:
> An error message like like "returned invalid all-zero mac address" (or
> "multicast address") might help to distinguish similar "ambiguities" in
> the future. No?
The current interface for the translation is "give me a string and I return
NULL or a mac address". The resolving of the IPs for hostnames and the check
of the neighbor table are done on an "I take what I get first" approach. Your
suggestion would involve a change of this interface and parsing of additional
information and tracking of states to make sure that the "best" result is
returned (or a special error state). This is nothing which I will implement
now.
Should I drop the patch for now?
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-04-14 9:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 18:16 [B.A.T.M.A.N.] [PATCH] batctl: Validate translated mac addresses Sven Eckelmann
2018-04-14 2:34 ` Antonio Quartulli
2018-04-14 7:10 ` Sven Eckelmann
2018-04-14 8:11 ` Antonio Quartulli
2018-04-14 9:20 ` Sven Eckelmann [this message]
2018-04-14 9:35 ` Antonio Quartulli
2018-04-14 9:36 ` Antonio Quartulli
2018-04-17 8:35 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6325045.lEza1471pb@sven-edge \
--to=sven@narfation.org \
--cc=Andre.Kasper@gmx.de \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=linus.luessing@c0d3.blue \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox