[PATCH 0/1] Hob: bug-fixes

[PATCH 0/1] Hob: bug-fixes

[Liming An]

Due in my mistake there has a high level bug, so fixed it, please to review.
Thanks!

The following changes since commit 644ad4bf1e30fcee4b9d5abb819046d1f2193d27:

  documentation/bsp-guide/bsp.xml: Yocto term paring (2012-07-02 16:47:45 +0100)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib limx/hob-bug-fixes-continue
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=limx/hob-bug-fixes-continue

Liming An (1):
  Hob: fixed some variables not clean bug in detail page

 bitbake/lib/bb/ui/crumbs/imagedetailspage.py |   14 +++-----------
 1 files changed, 3 insertions(+), 11 deletions(-)

-- 
1.7.5.4

[PATCH 1/1] Hob: fixed some variables not clean bug in detail page

[Liming An]

[YOCTO #2679]

Signed-off-by: Liming An <limingx.l.an@intel.com>
---
 bitbake/lib/bb/ui/crumbs/imagedetailspage.py |   14 +++-----------
 1 files changed, 3 insertions(+), 11 deletions(-)

diff --git a/bitbake/lib/bb/ui/crumbs/imagedetailspage.py b/bitbake/lib/bb/ui/crumbs/imagedetailspage.py
index 07fc3a8..596fb85 100755
--- a/bitbake/lib/bb/ui/crumbs/imagedetailspage.py
+++ b/bitbake/lib/bb/ui/crumbs/imagedetailspage.py
@@ -232,7 +232,7 @@ class ImageDetailsPage (HobPage):
 
         is_runnable = self.create_bottom_buttons(self.buttonlist, self.toggled_image)
 
-        #if self.build_succeeded:
+        # Generated image files info
         varlist = ["Name: ", "FileCreated: ", "Directory: "]
         vallist = []
 
@@ -428,7 +428,7 @@ class ImageDetailsPage (HobPage):
             if fileitem['is_toggled']:
                 if fileitem['action_attr'] == 'run':
                     self.builder.runqemu_image(fileitem['name'], self.sel_kernel)
-                elif image_attr == 'deploy':
+                elif fileitem['action_attr'] == 'deploy':
                     self.builder.deploy_image(fileitem['name'])
 
     def table_selected_cb(self, tbutton, image):
@@ -445,14 +445,6 @@ class ImageDetailsPage (HobPage):
             label = ((self.kernel_detail.get_children()[0]).get_children()[0]).get_children()[0]
             label.set_markup(markup)
 
-    def row_activated_cb(self, table, model, path):
-        if not model:
-            return
-        iter = model.get_iter(path)
-        image_name = model[path][0]
-        if iter and model[path][2] == True:
-            self.builder.runqemu_image(image_name, self.sel_kernel)
-
     def create_bottom_buttons(self, buttonlist, image_name):
         # Create the buttons at the bottom
         created = False
@@ -536,7 +528,7 @@ class ImageDetailsPage (HobPage):
 
     def deploy_button_clicked_cb(self, button):
         if self.toggled_image:
-            if self.build_succeeded or self.num_toggled > 1:
+            if self.num_toggled > 1:
                 self.set_sensitive(False)
                 self.show_builded_images_dialog(None, "Deploy image")
                 self.set_sensitive(True)
-- 
1.7.5.4

Re: [PATCH 0/1] Hob: bug-fixes

[Richard Purdie]

On Tue, 2012-07-03 at 19:15 +0800, Liming An wrote:
> Due in my mistake there has a high level bug, so fixed it, please to review.
> Thanks!
> 
> The following changes since commit 644ad4bf1e30fcee4b9d5abb819046d1f2193d27:
> 
>   documentation/bsp-guide/bsp.xml: Yocto term paring (2012-07-02 16:47:45 +0100)
> 
> are available in the git repository at:
>   git://git.pokylinux.org/poky-contrib limx/hob-bug-fixes-continue
>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=limx/hob-bug-fixes-continue
> 
> Liming An (1):
>   Hob: fixed some variables not clean bug in detail page

Merged to master, thanks.

Richard

[PATCH 0/1] hob:bug-fixes

[Liming An]

The following changes since commit 85c005d71c30bc5de61f9a9eb9818f37183af54b:

  tzdata: Upgrade tzdata to upstream 2012d (2012-08-02 23:21:12 +0100)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib limx/hob-bug-fixes-continue
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=limx/hob-bug-fixes-continue

Liming An (1):
  Hob: fixed the build image failure scenario

 bitbake/lib/bb/ui/crumbs/builddetailspage.py |   14 ++++++--------
 bitbake/lib/bb/ui/crumbs/builder.py          |    3 ++-
 bitbake/lib/bb/ui/crumbs/hobwidget.py        |    2 +-
 3 files changed, 9 insertions(+), 10 deletions(-)

-- 
1.7.5.4

[PATCH 0/1] Hob: bug-fixes

[Liming An]

The following changes since commit bcc04b2880b44140176e1d2dcc955a3d3942c392:

  tiny-init: Basic init mechanism for poky-tiny (2012-06-26 15:34:40 +0100)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib limx/hob-bug-fixes-continue
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=limx/hob-bug-fixes-continue

Liming An (1):
  Hob: change 'run image' and 'deploy' Gui and work flow for building
    detail page

 bitbake/lib/bb/ui/crumbs/imagedetailspage.py |  212 ++++++++++++--------------
 1 files changed, 98 insertions(+), 114 deletions(-)

-- 
1.7.5.4

[PATCH 0/1] Hob: bug-fixes

[Liming An]

The following changes since commit 17f3435f68932056c44f4f8a2ba7838225eac396:

  Hob:fixed the issue of primary button is not an 'orange hob button' (2012-05-25 18:33:34 +0800)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib limx/hob-bug-fixes-continue
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=limx/hob-bug-fixes-continue

Liming An (1):
  Hob: Fixed a compatible issue for indicator icon view

 bitbake/lib/bb/ui/crumbs/hobwidget.py |   51 +++++---------------------------
 1 files changed, 8 insertions(+), 43 deletions(-)

-- 
1.7.5.4

[PATCH 0/1] Hob: bug-fixes

[Liming An]

The following changes since commit 6558abda67956e4fab1304b0cdf03c65f18fabd5:

  qemu: disable vnc-jpeg compression (2012-05-24 08:53:57 +0100)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib limx/hob-bug-fixes-continue
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=limx/hob-bug-fixes-continue

Liming An (1):
  Hob:fixed the issue of primary button is not an 'orange hob button'

 bitbake/lib/bb/ui/crumbs/imagedetailspage.py |   27 +++++++++++++++----------
 meta/conf/machine/include/qemu.inc           |    2 +-
 2 files changed, 17 insertions(+), 12 deletions(-)

-- 
1.7.5.4

Re: [PATCH 0/1] Hob: bug-fixes

[Richard Purdie]

On Thu, 2012-05-24 at 19:07 +0800, Liming An wrote:
> The following changes since commit 6558abda67956e4fab1304b0cdf03c65f18fabd5:
> 
>   qemu: disable vnc-jpeg compression (2012-05-24 08:53:57 +0100)
> 
> are available in the git repository at:
>   git://git.pokylinux.org/poky-contrib limx/hob-bug-fixes-continue
>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=limx/hob-bug-fixes-continue
> 
> Liming An (1):
>   Hob:fixed the issue of primary button is not an 'orange hob button'
> 
>  bitbake/lib/bb/ui/crumbs/imagedetailspage.py |   27 +++++++++++++++----------
>  meta/conf/machine/include/qemu.inc           |    2 +-
>  2 files changed, 17 insertions(+), 12 deletions(-)

Merged to master, thanks.

Richard

[PATCH 0/1] Hob: bug-fixes

[Liming An]

The following changes since commit 2ddf7d3e8326e8cb07101ddb2d6e5dc6866371e2:

  gcc-configure-common.inc: Stop gcc looking at build system paths (2012-04-15 18:09:57 +0100)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib limx/hob-bug-fixes-another
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=limx/hob-bug-fixes-another

Liming An (1):
  Hob: fixed a little view issue about package selection page

 bitbake/lib/bb/ui/crumbs/hobwidget.py |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

-- 
1.7.5.4

[PATCH 0/1] Hob: bug-fixes

[Liming An]

The following changes since commit 2ddf7d3e8326e8cb07101ddb2d6e5dc6866371e2:

  gcc-configure-common.inc: Stop gcc looking at build system paths (2012-04-15 18:09:57 +0100)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib limx/hob-bug-fixes-another
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=limx/hob-bug-fixes-another

Liming An (1):
  Hob: fixed a little view issue about package selection page

 bitbake/lib/bb/ui/crumbs/hobwidget.py |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

-- 
1.7.5.4