[PATCH 0/1] Hob: bug-fixes

[PATCH 0/1] Hob: bug-fixes

[Liming An]

The following changes since commit 17f3435f68932056c44f4f8a2ba7838225eac396:

  Hob:fixed the issue of primary button is not an 'orange hob button' (2012-05-25 18:33:34 +0800)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib limx/hob-bug-fixes-continue
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=limx/hob-bug-fixes-continue

Liming An (1):
  Hob: Fixed a compatible issue for indicator icon view

 bitbake/lib/bb/ui/crumbs/hobwidget.py |   51 +++++---------------------------
 1 files changed, 8 insertions(+), 43 deletions(-)

-- 
1.7.5.4

[PATCH 1/1] Hob: Fixed a compatible issue for indicator icon view

[Liming An]

Because some screen not support the alpha visual channel, so the function
'screen.get_rgba_colormap()' will return None, it's a compatible issue, so
change it by another way.

Signed-off-by: Liming An <limingx.l.an@intel.com>
---
 bitbake/lib/bb/ui/crumbs/hobwidget.py |   51 +++++---------------------------
 1 files changed, 8 insertions(+), 43 deletions(-)

diff --git a/bitbake/lib/bb/ui/crumbs/hobwidget.py b/bitbake/lib/bb/ui/crumbs/hobwidget.py
index f8e97ad..bd9e2e2 100644
--- a/bitbake/lib/bb/ui/crumbs/hobwidget.py
+++ b/bitbake/lib/bb/ui/crumbs/hobwidget.py
@@ -400,50 +400,33 @@ class HobInfoButton(gtk.EventBox):
 class HobIndicator(gtk.DrawingArea):
     def __init__(self, count):
         gtk.DrawingArea.__init__(self)
-
-        # We want to composite the transparent indicator onto the parent
-        # HBox
-        screen = self.get_screen()
-        rgba = screen.get_rgba_colormap()
-        self.set_colormap(rgba)
-        self.set_app_paintable(True)
+        # Set no window for transparent background
+        self.set_has_window(False)
         self.set_size_request(38,38)
         # We need to pass through button clicks
         self.add_events(gtk.gdk.BUTTON_PRESS_MASK | gtk.gdk.BUTTON_RELEASE_MASK)
 
         self.connect('expose-event', self.expose)
-        self.connect_after('realize', self.composite)
 
         self.count = count
         self.color = HobColors.GRAY
 
-    def composite(self, widget):
-        # This property must be set after the widget has been realised
-        self.window.set_composited(True)
-
     def expose(self, widget, event):
-        # Transparent background
-        ctx = widget.window.cairo_create()
-        ctx.set_operator(cairo.OPERATOR_CLEAR)
-        region = gtk.gdk.region_rectangle(event.area)
-
-        ctx.region(region)
-        ctx.fill()
-
         if self.count and self.count > 0:
-            w = self.allocation.width
-            h = self.allocation.height
+            ctx = widget.window.cairo_create()
+
+            x, y, w, h = self.allocation
 
             ctx.set_operator(cairo.OPERATOR_OVER)
             ctx.set_source_color(gtk.gdk.color_parse(self.color))
             ctx.translate(w/2, h/2)
-            ctx.arc(1, 1, min(w,h)/2 - 2, 0, 2*math.pi)
+            ctx.arc(x, y, min(w,h)/2 - 2, 0, 2*math.pi)
             ctx.fill_preserve()
 
             layout = self.create_pango_layout(str(self.count))
             textw, texth = layout.get_pixel_size()
-            x = (w/2)-(textw/2) + 1
-            y = (h/2) - (texth/2) + 1
+            x = (w/2)-(textw/2) + x
+            y = (h/2) - (texth/2) + y
             ctx.move_to(x, y)
             self.window.draw_layout(self.style.light_gc[gtk.STATE_NORMAL], int(x), int(y), layout)
 
@@ -466,24 +449,6 @@ class HobTabLabel(gtk.HBox):
         self.lbl.set_alignment(0.0, 0.5)
         self.lbl.show()
         self.pack_end(self.lbl, True, True, 6)
-        self.connect_after('expose-event', self.expose_event)
-
-    def expose_event(self, widget, event):
-        # Composite the child indicator onto the Box
-        child = self.indicator
-        ctx = widget.window.cairo_create()
-
-        ctx.set_source_pixmap(child.window, child.allocation.x, child.allocation.y)
-
-        region = gtk.gdk.region_rectangle(child.allocation)
-        r = gtk.gdk.region_rectangle(event.area)
-        region.intersect(r)
-        ctx.region(region)
-        ctx.clip()
-
-        ctx.paint()
-
-        return False
 
     def set_count(self, count):
         self.indicator.set_count(count)
-- 
1.7.5.4

Re: [PATCH 1/1] Hob: Fixed a compatible issue for indicator icon view

[Wang, Shane]

ACK, I am OK with that and have tested on Ubuntu 10.04. CC Josh.

But one more thing, can you test set_action_widget() mentioned by Josh to see how we can replace it with something else, Liming?
It seems that doesn't work on Ubuntu 10.04.

--
Shane

Liming An wrote on 2012-05-25:

> Because some screen not support the alpha visual channel, so the function
> 'screen.get_rgba_colormap()' will return None, it's a compatible issue, so
> change it by another way.
> 
> Signed-off-by: Liming An <limingx.l.an@intel.com>
> ---
>  bitbake/lib/bb/ui/crumbs/hobwidget.py |   51 +++++---------------------------
>  1 files changed, 8 insertions(+), 43 deletions(-)
> diff --git a/bitbake/lib/bb/ui/crumbs/hobwidget.py
> b/bitbake/lib/bb/ui/crumbs/hobwidget.py index f8e97ad..bd9e2e2 100644
> --- a/bitbake/lib/bb/ui/crumbs/hobwidget.py +++
> b/bitbake/lib/bb/ui/crumbs/hobwidget.py @@ -400,50 +400,33 @@ class
> HobInfoButton(gtk.EventBox):
>  class HobIndicator(gtk.DrawingArea):
>      def __init__(self, count):
>          gtk.DrawingArea.__init__(self)
> -
> -        # We want to composite the transparent indicator onto the parent
> -        # HBox
> -        screen = self.get_screen()
> -        rgba = screen.get_rgba_colormap()
> -        self.set_colormap(rgba)
> -        self.set_app_paintable(True)
> +        # Set no window for transparent background
> +        self.set_has_window(False)
>          self.set_size_request(38,38)
>          # We need to pass through button clicks
>          self.add_events(gtk.gdk.BUTTON_PRESS_MASK |
> gtk.gdk.BUTTON_RELEASE_MASK)
> 
>          self.connect('expose-event', self.expose)
> -        self.connect_after('realize', self.composite)
> 
>          self.count = count
>          self.color = HobColors.GRAY
> -    def composite(self, widget):
> -        # This property must be set after the widget has been realised
> -        self.window.set_composited(True)
> -
>      def expose(self, widget, event):
> -        # Transparent background
> -        ctx = widget.window.cairo_create()
> -        ctx.set_operator(cairo.OPERATOR_CLEAR)
> -        region = gtk.gdk.region_rectangle(event.area)
> -
> -        ctx.region(region)
> -        ctx.fill()
> -
>          if self.count and self.count > 0:
> -            w = self.allocation.width
> -            h = self.allocation.height
> +            ctx = widget.window.cairo_create()
> +
> +            x, y, w, h = self.allocation
> 
>              ctx.set_operator(cairo.OPERATOR_OVER)
>              ctx.set_source_color(gtk.gdk.color_parse(self.color))
>              ctx.translate(w/2, h/2)
> -            ctx.arc(1, 1, min(w,h)/2 - 2, 0, 2*math.pi)
> +            ctx.arc(x, y, min(w,h)/2 - 2, 0, 2*math.pi)
>              ctx.fill_preserve()
>              
>              layout = self.create_pango_layout(str(self.count))
>              textw, texth = layout.get_pixel_size()
> -            x = (w/2)-(textw/2) + 1
> -            y = (h/2) - (texth/2) + 1
> +            x = (w/2)-(textw/2) + x
> +            y = (h/2) - (texth/2) + y
>              ctx.move_to(x, y)
> self.window.draw_layout(self.style.light_gc[gtk.STATE_NORMAL], int(x),
> int(y), layout)
> 
> @@ -466,24 +449,6 @@ class HobTabLabel(gtk.HBox):
>          self.lbl.set_alignment(0.0, 0.5)
>          self.lbl.show()
>          self.pack_end(self.lbl, True, True, 6)
> -        self.connect_after('expose-event', self.expose_event) - -   
> def expose_event(self, widget, event): -        # Composite the child
> indicator onto the Box -        child = self.indicator -        ctx =
> widget.window.cairo_create() - -       
> ctx.set_source_pixmap(child.window, child.allocation.x,
> child.allocation.y) - -        region =
> gtk.gdk.region_rectangle(child.allocation) -        r =
> gtk.gdk.region_rectangle(event.area) -        region.intersect(r) -     
>   ctx.region(region) -        ctx.clip() - -        ctx.paint() - -     
>   return False
> 
>      def set_count(self, count):
>          self.indicator.set_count(count)

[PATCH 0/1] hob:bug-fixes

[Liming An]

The following changes since commit 85c005d71c30bc5de61f9a9eb9818f37183af54b:

  tzdata: Upgrade tzdata to upstream 2012d (2012-08-02 23:21:12 +0100)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib limx/hob-bug-fixes-continue
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=limx/hob-bug-fixes-continue

Liming An (1):
  Hob: fixed the build image failure scenario

 bitbake/lib/bb/ui/crumbs/builddetailspage.py |   14 ++++++--------
 bitbake/lib/bb/ui/crumbs/builder.py          |    3 ++-
 bitbake/lib/bb/ui/crumbs/hobwidget.py        |    2 +-
 3 files changed, 9 insertions(+), 10 deletions(-)

-- 
1.7.5.4

[PATCH 0/1] Hob: bug-fixes

[Liming An]

Due in my mistake there has a high level bug, so fixed it, please to review.
Thanks!

The following changes since commit 644ad4bf1e30fcee4b9d5abb819046d1f2193d27:

  documentation/bsp-guide/bsp.xml: Yocto term paring (2012-07-02 16:47:45 +0100)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib limx/hob-bug-fixes-continue
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=limx/hob-bug-fixes-continue

Liming An (1):
  Hob: fixed some variables not clean bug in detail page

 bitbake/lib/bb/ui/crumbs/imagedetailspage.py |   14 +++-----------
 1 files changed, 3 insertions(+), 11 deletions(-)

-- 
1.7.5.4

Re: [PATCH 0/1] Hob: bug-fixes

[Richard Purdie]

On Tue, 2012-07-03 at 19:15 +0800, Liming An wrote:
> Due in my mistake there has a high level bug, so fixed it, please to review.
> Thanks!
> 
> The following changes since commit 644ad4bf1e30fcee4b9d5abb819046d1f2193d27:
> 
>   documentation/bsp-guide/bsp.xml: Yocto term paring (2012-07-02 16:47:45 +0100)
> 
> are available in the git repository at:
>   git://git.pokylinux.org/poky-contrib limx/hob-bug-fixes-continue
>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=limx/hob-bug-fixes-continue
> 
> Liming An (1):
>   Hob: fixed some variables not clean bug in detail page

Merged to master, thanks.

Richard

[PATCH 0/1] Hob: bug-fixes

[Liming An]

The following changes since commit bcc04b2880b44140176e1d2dcc955a3d3942c392:

  tiny-init: Basic init mechanism for poky-tiny (2012-06-26 15:34:40 +0100)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib limx/hob-bug-fixes-continue
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=limx/hob-bug-fixes-continue

Liming An (1):
  Hob: change 'run image' and 'deploy' Gui and work flow for building
    detail page

 bitbake/lib/bb/ui/crumbs/imagedetailspage.py |  212 ++++++++++++--------------
 1 files changed, 98 insertions(+), 114 deletions(-)

-- 
1.7.5.4

[PATCH 0/1] Hob: bug-fixes

[Liming An]

The following changes since commit 6558abda67956e4fab1304b0cdf03c65f18fabd5:

  qemu: disable vnc-jpeg compression (2012-05-24 08:53:57 +0100)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib limx/hob-bug-fixes-continue
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=limx/hob-bug-fixes-continue

Liming An (1):
  Hob:fixed the issue of primary button is not an 'orange hob button'

 bitbake/lib/bb/ui/crumbs/imagedetailspage.py |   27 +++++++++++++++----------
 meta/conf/machine/include/qemu.inc           |    2 +-
 2 files changed, 17 insertions(+), 12 deletions(-)

-- 
1.7.5.4

Re: [PATCH 0/1] Hob: bug-fixes

[Richard Purdie]

On Thu, 2012-05-24 at 19:07 +0800, Liming An wrote:
> The following changes since commit 6558abda67956e4fab1304b0cdf03c65f18fabd5:
> 
>   qemu: disable vnc-jpeg compression (2012-05-24 08:53:57 +0100)
> 
> are available in the git repository at:
>   git://git.pokylinux.org/poky-contrib limx/hob-bug-fixes-continue
>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=limx/hob-bug-fixes-continue
> 
> Liming An (1):
>   Hob:fixed the issue of primary button is not an 'orange hob button'
> 
>  bitbake/lib/bb/ui/crumbs/imagedetailspage.py |   27 +++++++++++++++----------
>  meta/conf/machine/include/qemu.inc           |    2 +-
>  2 files changed, 17 insertions(+), 12 deletions(-)

Merged to master, thanks.

Richard

[PATCH 0/1] Hob: bug-fixes

[Liming An]

The following changes since commit 2ddf7d3e8326e8cb07101ddb2d6e5dc6866371e2:

  gcc-configure-common.inc: Stop gcc looking at build system paths (2012-04-15 18:09:57 +0100)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib limx/hob-bug-fixes-another
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=limx/hob-bug-fixes-another

Liming An (1):
  Hob: fixed a little view issue about package selection page

 bitbake/lib/bb/ui/crumbs/hobwidget.py |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

-- 
1.7.5.4

[PATCH 0/1] Hob: bug-fixes

[Liming An]

The following changes since commit 2ddf7d3e8326e8cb07101ddb2d6e5dc6866371e2:

  gcc-configure-common.inc: Stop gcc looking at build system paths (2012-04-15 18:09:57 +0100)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib limx/hob-bug-fixes-another
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=limx/hob-bug-fixes-another

Liming An (1):
  Hob: fixed a little view issue about package selection page

 bitbake/lib/bb/ui/crumbs/hobwidget.py |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

-- 
1.7.5.4