From: Anders Heimer <anders.heimer@est.tech>
To: bitbake-devel@lists.openembedded.org
Cc: Anders Heimer <anders.heimer@est.tech>
Subject: [PATCH 1/9] fetch2/az: fix wget command argument construction
Date: Thu, 25 Jun 2026 09:07:42 +0200 [thread overview]
Message-ID: <20260625070750.2757558-2-anders.heimer@est.tech> (raw)
In-Reply-To: <20260625070750.2757558-1-anders.heimer@est.tech>
Signed-off-by: Anders Heimer <anders.heimer@est.tech>
---
lib/bb/fetch2/az.py | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/bb/fetch2/az.py b/lib/bb/fetch2/az.py
index 1d3664f21..81fd14468 100644
--- a/lib/bb/fetch2/az.py
+++ b/lib/bb/fetch2/az.py
@@ -48,17 +48,17 @@ class Az(Wget):
# If were reaching the account transaction limit we might be refused a connection,
# retrying allows us to avoid false negatives since the limit changes over time
- fetchcmd = self.basecmd + ' --retry-connrefused --waitretry=5'
+ fetchcmd = self.basecmd + ['--retry-connrefused', '--waitretry=5']
# We need to provide a localpath to avoid wget using the SAS
# ud.localfile either has the downloadfilename or ud.path
localpath = os.path.join(d.getVar("DL_DIR"), ud.localfile)
bb.utils.mkdirhier(os.path.dirname(localpath))
- fetchcmd += " -O %s" % shlex.quote(localpath)
+ fetchcmd += ["-O", localpath]
if ud.user and ud.pswd:
- fetchcmd += " --user=%s --password=%s --auth-no-challenge" % (ud.user, ud.pswd)
+ fetchcmd += ["--user=%s" % ud.user, "--password=%s" % ud.pswd, "--auth-no-challenge"]
# Check if a Shared Access Signature was given and use it
az_sas = d.getVar('AZ_SAS')
@@ -73,9 +73,9 @@ class Az(Wget):
dldir = d.getVar("DL_DIR")
if os.path.exists(ud.localpath):
# file exists, but we didnt complete it.. trying again.
- fetchcmd += " -c -P %s '%s'" % (dldir, azuri)
+ fetchcmd += ["-c", "-P", dldir, azuri]
else:
- fetchcmd += " -P %s '%s'" % (dldir, azuri)
+ fetchcmd += ["-P", dldir, azuri]
try:
self._runwget(ud, d, fetchcmd, False)
next prev parent reply other threads:[~2026-06-25 7:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 7:07 [PATCH 0/9] Follow-up fixes for command argument conversions Anders Heimer
2026-06-25 7:07 ` Anders Heimer [this message]
2026-06-25 7:07 ` [PATCH 2/9] fetch2/git: avoid an empty argument to git lfs fetch Anders Heimer
2026-06-25 7:07 ` [PATCH 3/9] fetch2/git: do not shell-quote the shallow clone remote Anders Heimer
2026-06-25 7:07 ` [PATCH 4/9] fetch2/git: keep the gitpkgv commit count numeric Anders Heimer
2026-06-25 7:07 ` [PATCH 5/9] fetch2/gitannex: split the annex get arguments Anders Heimer
2026-06-25 7:07 ` [PATCH 6/9] fetch2/repo: fix mirror tar command arguments Anders Heimer
2026-06-25 7:07 ` [PATCH 7/9] fetch2/sftp: fix port and remote " Anders Heimer
2026-06-25 7:07 ` [PATCH 8/9] fetch2/svn: remove shell quotes from the tar exclusion Anders Heimer
2026-06-25 7:07 ` [PATCH 9/9] toaster: preserve shell execution for build launch commands Anders Heimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260625070750.2757558-2-anders.heimer@est.tech \
--to=anders.heimer@est.tech \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox