Openembedded Bitbake Development
 help / color / mirror / Atom feed
From: Anders Heimer <anders.heimer@est.tech>
To: bitbake-devel@lists.openembedded.org
Cc: Anders Heimer <anders.heimer@est.tech>
Subject: [PATCH 6/9] fetch2/repo: fix mirror tar command arguments
Date: Thu, 25 Jun 2026 09:07:47 +0200	[thread overview]
Message-ID: <20260625070750.2757558-7-anders.heimer@est.tech> (raw)
In-Reply-To: <20260625070750.2757558-1-anders.heimer@est.tech>

The direct tar invocation no longer has a shell to expand ./* or
strip quotes from exclude patterns. Build the path list explicitly and
pass tar exclude patterns without shell quote characters.

Signed-off-by: Anders Heimer <anders.heimer@est.tech>
---
 lib/bb/fetch2/repo.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lib/bb/fetch2/repo.py b/lib/bb/fetch2/repo.py
index 8543e3d59..9b96cd824 100644
--- a/lib/bb/fetch2/repo.py
+++ b/lib/bb/fetch2/repo.py
@@ -73,10 +73,13 @@ class Repo(FetchMethod):
         if scmdata == "keep":
             tar_flags = []
         else:
-            tar_flags = ["--exclude='.repo'", "--exclude='.git'"]
+            tar_flags = ["--exclude=.repo", "--exclude=.git"]
 
         # Create a cache
-        runfetchcmd(['tar'] + tar_flags + ['-czf', ud.localpath, os.path.join(".", "*")], d, workdir=codir)
+        tar_paths = [os.path.join(".", name)
+                     for name in sorted(os.listdir(codir))
+                     if not name.startswith(".")]
+        runfetchcmd(['tar'] + tar_flags + ['-czf', ud.localpath] + tar_paths, d, workdir=codir)
 
     def supports_srcrev(self):
         return False


  parent reply	other threads:[~2026-06-25  7:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-25  7:07 [PATCH 0/9] Follow-up fixes for command argument conversions Anders Heimer
2026-06-25  7:07 ` [PATCH 1/9] fetch2/az: fix wget command argument construction Anders Heimer
2026-06-25  7:07 ` [PATCH 2/9] fetch2/git: avoid an empty argument to git lfs fetch Anders Heimer
2026-06-25  7:07 ` [PATCH 3/9] fetch2/git: do not shell-quote the shallow clone remote Anders Heimer
2026-06-25  7:07 ` [PATCH 4/9] fetch2/git: keep the gitpkgv commit count numeric Anders Heimer
2026-06-25  7:07 ` [PATCH 5/9] fetch2/gitannex: split the annex get arguments Anders Heimer
2026-06-25  7:07 ` Anders Heimer [this message]
2026-06-25  7:07 ` [PATCH 7/9] fetch2/sftp: fix port and remote command arguments Anders Heimer
2026-06-25  7:07 ` [PATCH 8/9] fetch2/svn: remove shell quotes from the tar exclusion Anders Heimer
2026-06-25  7:07 ` [PATCH 9/9] toaster: preserve shell execution for build launch commands Anders Heimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260625070750.2757558-7-anders.heimer@est.tech \
    --to=anders.heimer@est.tech \
    --cc=bitbake-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox