From: Anders Heimer <anders.heimer@est.tech>
To: bitbake-devel@lists.openembedded.org
Cc: Anders Heimer <anders.heimer@est.tech>
Subject: [PATCH 4/9] fetch2/git: keep the gitpkgv commit count numeric
Date: Thu, 25 Jun 2026 09:07:45 +0200 [thread overview]
Message-ID: <20260625070750.2757558-5-anders.heimer@est.tech> (raw)
In-Reply-To: <20260625070750.2757558-1-anders.heimer@est.tech>
The cold-cache path used to keep the raw splitlines() list in
commits while only using len(commits) when writing the cache file.
That same commits value is formatted into the returned version string
below, so cold cache could return a Python list representation while
warm cache returned the numeric count. Store the numeric count in
commits before both writing the cache and building the return value.
Signed-off-by: Anders Heimer <anders.heimer@est.tech>
---
lib/bb/fetch2/git.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/bb/fetch2/git.py b/lib/bb/fetch2/git.py
index 00983b744..0bb2ea39a 100644
--- a/lib/bb/fetch2/git.py
+++ b/lib/bb/fetch2/git.py
@@ -1031,9 +1031,9 @@ class Git(FetchMethod):
commits = None
else:
if not os.path.exists(rev_file) or not os.path.getsize(rev_file):
- commits = bb.fetch2.runfetchcmd(['git', 'rev-list', rev, '--'], d).splitlines()
+ commits = len(bb.fetch2.runfetchcmd(['git', 'rev-list', rev, '--'], d).splitlines())
if commits:
- open(rev_file, "w").write("%d\n" % len(commits))
+ open(rev_file, "w").write("%d\n" % commits)
else:
commits = open(rev_file, "r").readline(128).strip()
if commits:
next prev parent reply other threads:[~2026-06-25 7:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 7:07 [PATCH 0/9] Follow-up fixes for command argument conversions Anders Heimer
2026-06-25 7:07 ` [PATCH 1/9] fetch2/az: fix wget command argument construction Anders Heimer
2026-06-25 7:07 ` [PATCH 2/9] fetch2/git: avoid an empty argument to git lfs fetch Anders Heimer
2026-06-25 7:07 ` [PATCH 3/9] fetch2/git: do not shell-quote the shallow clone remote Anders Heimer
2026-06-25 7:07 ` Anders Heimer [this message]
2026-06-25 7:07 ` [PATCH 5/9] fetch2/gitannex: split the annex get arguments Anders Heimer
2026-06-25 7:07 ` [PATCH 6/9] fetch2/repo: fix mirror tar command arguments Anders Heimer
2026-06-25 7:07 ` [PATCH 7/9] fetch2/sftp: fix port and remote " Anders Heimer
2026-06-25 7:07 ` [PATCH 8/9] fetch2/svn: remove shell quotes from the tar exclusion Anders Heimer
2026-06-25 7:07 ` [PATCH 9/9] toaster: preserve shell execution for build launch commands Anders Heimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260625070750.2757558-5-anders.heimer@est.tech \
--to=anders.heimer@est.tech \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox