From: Josh Poimboeuf <jpoimboe@kernel.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@kernel.org>,
Suleiman Souhlal <suleiman@google.com>, bpf <bpf@vger.kernel.org>,
linux-kernel@vger.kernel.org, Borislav Petkov <bp@suse.de>,
x86@kernel.org
Subject: Re: [PATCH v3 0/2] x86/kprobes: Fixes for CONFIG_RETHUNK
Date: Thu, 8 Sep 2022 12:31:47 -0700 [thread overview]
Message-ID: <20220908193147.mtfwh33q2cfbw52b@treble> (raw)
In-Reply-To: <166264927154.775585.16570756675363838701.stgit@devnote2>
On Fri, Sep 09, 2022 at 12:01:11AM +0900, Masami Hiramatsu (Google) wrote:
> Hi Peter and Josh,
>
> So here is 3rd version of the patches to fix kprobes and optprobe with
> CONFIG_RETHUNK and CONFIG_SLS.
> Previous version is here;
>
> https://lore.kernel.org/all/166260087224.759381.4170102827490658262.stgit@devnote2/
>
> In this version, I simplified all code and just checks the INT3 comes
> from kgdb or not. Other INT3 are treated as one-byte instruction.
Looks good to me.
I was confused by the naming of kgdb_has_hit_break(), because in this
case, with the function being called from outside the stopped kgdb
context, the breakpoint hasn't actually been hit. But it still seems to
do the right thing: it checks for BP_ACTIVE which means the breakpoint
has been written.
Reviewed-by: Josh Poimboeuf <jpoimboe@kernel.org>
--
Josh
next prev parent reply other threads:[~2022-09-08 19:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 1:34 [PATCH v2 0/2] x86/kprobes: Fixes for CONFIG_RETHUNK Masami Hiramatsu (Google)
2022-09-08 1:34 ` [PATCH v2 1/2] x86/kprobes: Fix kprobes instruction boudary check with CONFIG_RETHUNK Masami Hiramatsu (Google)
2022-09-08 5:08 ` Josh Poimboeuf
2022-09-08 9:30 ` Peter Zijlstra
2022-09-08 10:04 ` [PATCH] x86,retpoline: Be sure to emit INT3 after JMP *%\reg Peter Zijlstra
2022-09-08 14:01 ` Alexei Starovoitov
2022-09-09 8:16 ` Peter Zijlstra
2022-09-09 14:19 ` Alexei Starovoitov
2022-09-09 16:48 ` Josh Poimboeuf
2022-09-11 15:14 ` Peter Zijlstra
2022-09-08 10:08 ` [PATCH v2 1/2] x86/kprobes: Fix kprobes instruction boudary check with CONFIG_RETHUNK Peter Zijlstra
2022-09-08 13:03 ` Masami Hiramatsu
2022-09-08 15:01 ` [PATCH v3 0/2] x86/kprobes: Fixes for CONFIG_RETHUNK Masami Hiramatsu (Google)
2022-09-08 15:01 ` [PATCH v3 1/2] x86/kprobes: Fix kprobes instruction boudary check with CONFIG_RETHUNK Masami Hiramatsu (Google)
2022-09-08 15:01 ` [PATCH v3 2/2] x86/kprobes: Fix optprobe optimization " Masami Hiramatsu (Google)
2022-12-15 3:31 ` Nadav Amit
2022-12-18 14:28 ` Masami Hiramatsu
2022-09-08 19:31 ` Josh Poimboeuf [this message]
2022-09-08 1:34 ` [PATCH v2 " Masami Hiramatsu (Google)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220908193147.mtfwh33q2cfbw52b@treble \
--to=jpoimboe@kernel.org \
--cc=bp@suse.de \
--cc=bpf@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=suleiman@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox