BPF List
 help / color / mirror / Atom feed
* [PATCH bpf-next 0/4] selftests/bpf: Fix a couple of test failures with LTO kernel
@ 2024-03-02 16:20 Yonghong Song
  2024-03-02 16:49 ` Yonghong Song
  0 siblings, 1 reply; 3+ messages in thread
From: Yonghong Song @ 2024-03-02 16:20 UTC (permalink / raw)
  To: bpf
  Cc: Alexei Starovoitov, Andrii Nakryiko, Daniel Borkmann, kernel-team,
	Martin KaFai Lau

With a LTO kernel built with clang, I encountered two test failures,
ksyms and kprobe_multi_bench_attach/kernel. Both test failures are
due to static variable/function renaming due to cross-file inlining.
The solution is to either skip the test or filter out those renamed
functions. A helper function check_lto_kernel() is introduced to
identify whether the underlying kernel is built with LTO or not.
Please see each individual patches for details.

Yonghong Song (4):
  selftests/bpf: Replace CHECK with ASSERT macros for ksyms test
  selftests/bpf: Add check_lto_kernel() helper
  selftests/bpf: Fix possible ksyms test failure with LTO kernel
  selftests/bpf: Fix possible kprobe_multi_bench_attach test failure
    with LTO kernel

 .../bpf/prog_tests/kprobe_multi_test.c        |  7 +++
 .../testing/selftests/bpf/prog_tests/ksyms.c  | 42 +++++++++--------
 tools/testing/selftests/bpf/testing_helpers.c | 47 +++++++++++++++++++
 tools/testing/selftests/bpf/testing_helpers.h |  1 +
 4 files changed, 78 insertions(+), 19 deletions(-)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH bpf-next 0/4] selftests/bpf: Fix a couple of test failures with LTO kernel
  2024-03-02 16:20 [PATCH bpf-next 0/4] selftests/bpf: Fix a couple of test failures with LTO kernel Yonghong Song
@ 2024-03-02 16:49 ` Yonghong Song
  0 siblings, 0 replies; 3+ messages in thread
From: Yonghong Song @ 2024-03-02 16:49 UTC (permalink / raw)
  To: bpf
  Cc: Alexei Starovoitov, Andrii Nakryiko, Daniel Borkmann, kernel-team,
	Martin KaFai Lau


On 3/2/24 8:20 AM, Yonghong Song wrote:
> With a LTO kernel built with clang, I encountered two test failures,
> ksyms and kprobe_multi_bench_attach/kernel. Both test failures are
> due to static variable/function renaming due to cross-file inlining.
> The solution is to either skip the test or filter out those renamed
> functions. A helper function check_lto_kernel() is introduced to
> identify whether the underlying kernel is built with LTO or not.
> Please see each individual patches for details.
>
> Yonghong Song (4):
>    selftests/bpf: Replace CHECK with ASSERT macros for ksyms test
>    selftests/bpf: Add check_lto_kernel() helper
>    selftests/bpf: Fix possible ksyms test failure with LTO kernel
>    selftests/bpf: Fix possible kprobe_multi_bench_attach test failure
>      with LTO kernel
>
>   .../bpf/prog_tests/kprobe_multi_test.c        |  7 +++
>   .../testing/selftests/bpf/prog_tests/ksyms.c  | 42 +++++++++--------
>   tools/testing/selftests/bpf/testing_helpers.c | 47 +++++++++++++++++++
>   tools/testing/selftests/bpf/testing_helpers.h |  1 +
>   4 files changed, 78 insertions(+), 19 deletions(-)
>
Please ignore this one. It is my git send script issue with Message-Id vs. Message-ID.
Will post actual series soon.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH bpf-next 0/4] selftests/bpf: Fix a couple of test failures with LTO kernel
@ 2024-03-02 16:50 Yonghong Song
  0 siblings, 0 replies; 3+ messages in thread
From: Yonghong Song @ 2024-03-02 16:50 UTC (permalink / raw)
  To: bpf
  Cc: Alexei Starovoitov, Andrii Nakryiko, Daniel Borkmann, kernel-team,
	Martin KaFai Lau

With a LTO kernel built with clang, I encountered two test failures,
ksyms and kprobe_multi_bench_attach/kernel. Both test failures are
due to static variable/function renaming due to cross-file inlining.
The solution is to either skip the test or filter out those renamed
functions. A helper function check_lto_kernel() is introduced to
identify whether the underlying kernel is built with LTO or not.
Please see each individual patches for details.

Yonghong Song (4):
  selftests/bpf: Replace CHECK with ASSERT macros for ksyms test
  selftests/bpf: Add check_lto_kernel() helper
  selftests/bpf: Fix possible ksyms test failure with LTO kernel
  selftests/bpf: Fix possible kprobe_multi_bench_attach test failure
    with LTO kernel

 .../bpf/prog_tests/kprobe_multi_test.c        |  7 +++
 .../testing/selftests/bpf/prog_tests/ksyms.c  | 42 +++++++++--------
 tools/testing/selftests/bpf/testing_helpers.c | 47 +++++++++++++++++++
 tools/testing/selftests/bpf/testing_helpers.h |  1 +
 4 files changed, 78 insertions(+), 19 deletions(-)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-03-02 16:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-02 16:20 [PATCH bpf-next 0/4] selftests/bpf: Fix a couple of test failures with LTO kernel Yonghong Song
2024-03-02 16:49 ` Yonghong Song
  -- strict thread matches above, loose matches on Subject: below --
2024-03-02 16:50 Yonghong Song

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox