BPF List
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Daniel Borkmann <daniel@iogearbox.net>,
	Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	Christian Brauner <brauner@kernel.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>, bpf <bpf@vger.kernel.org>,
	Networking <netdev@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: build failure after merge of the bpf-next tree
Date: Wed, 14 Aug 2024 11:18:36 +1000	[thread overview]
Message-ID: <20240814111836.6368311a@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 2292 bytes --]

Hi all,

After merging the bpf-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

fs/namespace.c: In function 'grab_requested_mnt_ns':
fs/namespace.c:5295:23: error: 'class_fd_t' {aka 'struct fd'} has no member named 'file'
 5295 |                 if (!f.file)
      |                       ^
fs/namespace.c:5298:36: error: 'class_fd_t' {aka 'struct fd'} has no member named 'file'
 5298 |                 if (!proc_ns_file(f.file))
      |                                    ^
In file included from fs/namespace.c:25:
fs/namespace.c:5301:46: error: 'class_fd_t' {aka 'struct fd'} has no member named 'file'
 5301 |                 ns = get_proc_ns(file_inode(f.file));
      |                                              ^
include/linux/proc_ns.h:75:50: note: in definition of macro 'get_proc_ns'
   75 | #define get_proc_ns(inode) ((struct ns_common *)(inode)->i_private)
      |                                                  ^~~~~

Caused by commit

  1da91ea87aef ("introduce fd_file(), convert all accessors to it.")

interacting with commit

  7b9d14af8777 ("fs: allow mount namespace fd")

from the vfs-brauner tree.

I applied the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 14 Aug 2024 11:07:38 +1000
Subject: [PATCH] fixup for "introduce fd_file(), convert all accessors to it."

interacting with "fs: allow mount namespace fd" from hte vfs-brauner tree.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 fs/namespace.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/namespace.c b/fs/namespace.c
index 159be8ed9d24..7aed325c48ad 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -5292,13 +5292,13 @@ static struct mnt_namespace *grab_requested_mnt_ns(const struct mnt_id_req *kreq
 		struct ns_common *ns;
 
 		CLASS(fd, f)(kreq->spare);
-		if (!f.file)
+		if (!fd_file(f))
 			return ERR_PTR(-EBADF);
 
-		if (!proc_ns_file(f.file))
+		if (!proc_ns_file(fd_file(f)))
 			return ERR_PTR(-EINVAL);
 
-		ns = get_proc_ns(file_inode(f.file));
+		ns = get_proc_ns(file_inode(fd_file(f)));
 		if (ns->ops->type != CLONE_NEWNS)
 			return ERR_PTR(-EINVAL);
 
-- 
2.43.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2024-08-14  1:18 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-14  1:18 Stephen Rothwell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-04-27 13:26 linux-next: build failure after merge of the bpf-next tree Thierry Reding
2026-04-27 13:34 ` Thierry Reding
2026-04-27 13:43 ` Alan Maguire
2026-04-28 18:26 ` sashiko-bot
2025-03-19  2:33 Stephen Rothwell
2025-03-19  2:46 ` Alexei Starovoitov
2025-03-19  3:28   ` Stephen Rothwell
2025-03-19 13:37   ` Kumar Kartikeya Dwivedi
2025-03-19 13:43     ` Kumar Kartikeya Dwivedi
2025-03-19 14:36       ` Kumar Kartikeya Dwivedi
2025-03-19 14:55         ` Alexei Starovoitov
2025-03-19 15:11           ` Alexei Starovoitov
2025-03-19 16:06           ` Uros Bizjak
2025-03-19 18:56             ` Alexei Starovoitov
2025-03-19 19:43               ` Uros Bizjak
2025-03-19 23:16                 ` Alexei Starovoitov
2025-03-20  7:49                   ` Uros Bizjak
2025-03-20 23:17                     ` Alexei Starovoitov
2025-03-21  7:15                       ` Uros Bizjak
2025-03-19  5:03 ` Uros Bizjak
2025-03-12  3:52 Stephen Rothwell
2024-10-16  6:05 Stephen Rothwell
2024-10-16 16:25 ` Alexei Starovoitov
2024-10-16 18:35   ` Namhyung Kim
2024-10-16 19:32     ` Alexei Starovoitov
2024-09-13  3:55 Stephen Rothwell
2024-09-13  4:00 ` Al Viro
2024-09-13  4:26   ` Andrii Nakryiko
2024-09-13  4:43     ` Al Viro
2024-09-15 23:30 ` Stephen Rothwell
2024-09-13  3:45 Stephen Rothwell
2024-09-13  3:48 ` Stephen Rothwell
2024-09-15 23:27 ` Stephen Rothwell
2024-09-13  3:32 Stephen Rothwell
2024-09-15 23:26 ` Stephen Rothwell
2024-08-14  1:25 Stephen Rothwell
2024-08-14  1:41 ` Al Viro
2024-08-14  2:37   ` Stephen Rothwell
2024-08-14 14:50   ` Christian Brauner
2024-08-30  1:32 ` Stephen Rothwell
2024-06-17 18:15 Mark Brown
2024-06-22  8:17 ` kernel test robot
2024-06-22  8:28 ` kernel test robot
2024-06-25  1:22 ` Thinker Li
2024-06-25 15:54   ` Benjamin Tissoires
2024-06-25 16:03     ` Mark Brown
2024-06-25 17:14     ` Alexei Starovoitov
2024-06-27  7:14       ` Benjamin Tissoires
2024-07-09 23:13 ` Stephen Rothwell
2024-07-18  1:49   ` Stephen Rothwell
2024-07-18  7:42     ` Benjamin Tissoires
2023-03-19 23:26 Stephen Rothwell
2023-03-20 12:07 ` Alexander Lobakin
2023-03-21 22:35   ` Stephen Rothwell
2022-07-20  1:59 Stephen Rothwell
2022-07-20  3:42 ` Alexei Starovoitov
2022-07-20  3:44   ` Stanislav Fomichev
2022-04-19  1:56 Stephen Rothwell
2022-04-21  0:32 ` Stephen Rothwell
2022-04-21  9:45   ` Daniel Borkmann
2022-04-21 10:40     ` Maciej Fijalkowski
2022-02-09  0:21 Stephen Rothwell
     [not found] <20190418115748.0b0aefdc@canb.auug.org.au>
2019-04-18  5:55 ` Magnus Karlsson
2019-04-18  6:18   ` Alexei Starovoitov
2019-04-18  6:25     ` Magnus Karlsson
2019-04-18  6:51       ` Alexei Starovoitov
2019-04-18  7:12         ` Magnus Karlsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240814111836.6368311a@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=brauner@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox