BPF List
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Daniel Borkmann <daniel@iogearbox.net>,
	Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	David Chinner <david@fromorbit.com>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>, <linux-xfs@vger.kernel.org>,
	bpf <bpf@vger.kernel.org>, Networking <netdev@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: build failure after merge of the bpf-next tree
Date: Fri, 13 Sep 2024 13:55:51 +1000	[thread overview]
Message-ID: <20240913135551.4156251c@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 1645 bytes --]

Hi all,

After merging the bpf-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

fs/xfs/xfs_exchrange.c: In function 'xfs_ioc_commit_range':
fs/xfs/xfs_exchrange.c:938:19: error: 'struct fd' has no member named 'file'
  938 |         if (!file1.file)
      |                   ^
fs/xfs/xfs_exchrange.c:940:26: error: 'struct fd' has no member named 'file'
  940 |         fxr.file1 = file1.file;
      |                          ^

Caused by commit

  1da91ea87aef ("introduce fd_file(), convert all accessors to it.")

interacting with commit

  398597c3ef7f ("xfs: introduce new file range commit ioctls")

I have applied the following patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 13 Sep 2024 13:53:35 +1000
Subject: [PATCH] fix up 3 for "introduce fd_file(), convert all accessors to
 it."

interacting with commit "xfs: introduce new file range commit ioctls"
from the xfs tree.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 fs/xfs/xfs_exchrange.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/xfs/xfs_exchrange.c b/fs/xfs/xfs_exchrange.c
index 39fe02a8deac..75cb53f090d1 100644
--- a/fs/xfs/xfs_exchrange.c
+++ b/fs/xfs/xfs_exchrange.c
@@ -935,9 +935,9 @@ xfs_ioc_commit_range(
 	fxr.file2_ctime.tv_nsec	= kern_f->file2_ctime_nsec;
 
 	file1 = fdget(args.file1_fd);
-	if (!file1.file)
+	if (fd_empty(file1))
 		return -EBADF;
-	fxr.file1 = file1.file;
+	fxr.file1 = fd_file(file1);
 
 	error = xfs_exchange_range(&fxr);
 	fdput(file1);
-- 
2.45.2

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2024-09-13  3:55 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-13  3:55 Stephen Rothwell [this message]
2024-09-13  4:00 ` linux-next: build failure after merge of the bpf-next tree Al Viro
2024-09-13  4:26   ` Andrii Nakryiko
2024-09-13  4:43     ` Al Viro
2024-09-15 23:30 ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2026-04-27 13:26 Thierry Reding
2026-04-27 13:34 ` Thierry Reding
2026-04-27 13:43 ` Alan Maguire
2026-04-28 18:26 ` sashiko-bot
2025-03-19  2:33 Stephen Rothwell
2025-03-19  2:46 ` Alexei Starovoitov
2025-03-19  3:28   ` Stephen Rothwell
2025-03-19 13:37   ` Kumar Kartikeya Dwivedi
2025-03-19 13:43     ` Kumar Kartikeya Dwivedi
2025-03-19 14:36       ` Kumar Kartikeya Dwivedi
2025-03-19 14:55         ` Alexei Starovoitov
2025-03-19 15:11           ` Alexei Starovoitov
2025-03-19 16:06           ` Uros Bizjak
2025-03-19 18:56             ` Alexei Starovoitov
2025-03-19 19:43               ` Uros Bizjak
2025-03-19 23:16                 ` Alexei Starovoitov
2025-03-20  7:49                   ` Uros Bizjak
2025-03-20 23:17                     ` Alexei Starovoitov
2025-03-21  7:15                       ` Uros Bizjak
2025-03-19  5:03 ` Uros Bizjak
2025-03-12  3:52 Stephen Rothwell
2024-10-16  6:05 Stephen Rothwell
2024-10-16 16:25 ` Alexei Starovoitov
2024-10-16 18:35   ` Namhyung Kim
2024-10-16 19:32     ` Alexei Starovoitov
2024-09-13  3:45 Stephen Rothwell
2024-09-13  3:48 ` Stephen Rothwell
2024-09-15 23:27 ` Stephen Rothwell
2024-09-13  3:32 Stephen Rothwell
2024-09-15 23:26 ` Stephen Rothwell
2024-08-14  1:25 Stephen Rothwell
2024-08-14  1:41 ` Al Viro
2024-08-14  2:37   ` Stephen Rothwell
2024-08-14 14:50   ` Christian Brauner
2024-08-30  1:32 ` Stephen Rothwell
2024-08-14  1:18 Stephen Rothwell
2024-06-17 18:15 Mark Brown
2024-06-22  8:17 ` kernel test robot
2024-06-22  8:28 ` kernel test robot
2024-06-25  1:22 ` Thinker Li
2024-06-25 15:54   ` Benjamin Tissoires
2024-06-25 16:03     ` Mark Brown
2024-06-25 17:14     ` Alexei Starovoitov
2024-06-27  7:14       ` Benjamin Tissoires
2024-07-09 23:13 ` Stephen Rothwell
2024-07-18  1:49   ` Stephen Rothwell
2024-07-18  7:42     ` Benjamin Tissoires
2023-03-19 23:26 Stephen Rothwell
2023-03-20 12:07 ` Alexander Lobakin
2023-03-21 22:35   ` Stephen Rothwell
2022-07-20  1:59 Stephen Rothwell
2022-07-20  3:42 ` Alexei Starovoitov
2022-07-20  3:44   ` Stanislav Fomichev
2022-04-19  1:56 Stephen Rothwell
2022-04-21  0:32 ` Stephen Rothwell
2022-04-21  9:45   ` Daniel Borkmann
2022-04-21 10:40     ` Maciej Fijalkowski
2022-02-09  0:21 Stephen Rothwell
     [not found] <20190418115748.0b0aefdc@canb.auug.org.au>
2019-04-18  5:55 ` Magnus Karlsson
2019-04-18  6:18   ` Alexei Starovoitov
2019-04-18  6:25     ` Magnus Karlsson
2019-04-18  6:51       ` Alexei Starovoitov
2019-04-18  7:12         ` Magnus Karlsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240913135551.4156251c@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=david@fromorbit.com \
    --cc=djwong@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox