* [PATCH bpf] samples/bpf: pass TPROGS_USER_CFLAGS to libbpf makefile
@ 2024-12-04 17:34 Eduard Zingerman
2024-12-05 7:07 ` Viktor Malik
2024-12-05 18:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Eduard Zingerman @ 2024-12-04 17:34 UTC (permalink / raw)
To: bpf, ast
Cc: andrii, daniel, martin.lau, kernel-team, yonghong.song,
Eduard Zingerman, Viktor Malik
Before commit [1], the value of a variable TPROGS_USER_CFLAGS was
passed to libbpf make command as a part of EXTRA_CFLAGS.
This commit makes sure that the value of TPROGS_USER_CFLAGS is still
passed to libbpf make command, in order to maintain backwards build
scripts compatibility.
[1] commit 5a6ea7022ff4 ("samples/bpf: Remove unnecessary -I flags from libbpf EXTRA_CFLAGS")
Fixes: 5a6ea7022ff4 ("samples/bpf: Remove unnecessary -I flags from libbpf EXTRA_CFLAGS")
Suggested-by: Viktor Malik <vmalik@redhat.com>
Signed-off-by: Eduard Zingerman <eddyz87@gmail.com>
---
samples/bpf/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile
index 96a05e70ace3..dd9944a97b7e 100644
--- a/samples/bpf/Makefile
+++ b/samples/bpf/Makefile
@@ -123,7 +123,7 @@ always-y += ibumad_kern.o
always-y += hbm_out_kern.o
always-y += hbm_edt_kern.o
-TPROGS_CFLAGS = $(TPROGS_USER_CFLAGS)
+COMMON_CFLAGS = $(TPROGS_USER_CFLAGS)
TPROGS_LDFLAGS = $(TPROGS_USER_LDFLAGS)
ifeq ($(ARCH), arm)
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH bpf] samples/bpf: pass TPROGS_USER_CFLAGS to libbpf makefile
2024-12-04 17:34 [PATCH bpf] samples/bpf: pass TPROGS_USER_CFLAGS to libbpf makefile Eduard Zingerman
@ 2024-12-05 7:07 ` Viktor Malik
2024-12-05 18:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Viktor Malik @ 2024-12-05 7:07 UTC (permalink / raw)
To: Eduard Zingerman, bpf, ast
Cc: andrii, daniel, martin.lau, kernel-team, yonghong.song
On 12/4/24 18:34, Eduard Zingerman wrote:
> Before commit [1], the value of a variable TPROGS_USER_CFLAGS was
> passed to libbpf make command as a part of EXTRA_CFLAGS.
> This commit makes sure that the value of TPROGS_USER_CFLAGS is still
> passed to libbpf make command, in order to maintain backwards build
> scripts compatibility.
>
> [1] commit 5a6ea7022ff4 ("samples/bpf: Remove unnecessary -I flags from libbpf EXTRA_CFLAGS")
>
> Fixes: 5a6ea7022ff4 ("samples/bpf: Remove unnecessary -I flags from libbpf EXTRA_CFLAGS")
> Suggested-by: Viktor Malik <vmalik@redhat.com>
> Signed-off-by: Eduard Zingerman <eddyz87@gmail.com>
Thanks! Works as expected.
Acked-by: Viktor Malik <vmalik@redhat.com>
> ---
> samples/bpf/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile
> index 96a05e70ace3..dd9944a97b7e 100644
> --- a/samples/bpf/Makefile
> +++ b/samples/bpf/Makefile
> @@ -123,7 +123,7 @@ always-y += ibumad_kern.o
> always-y += hbm_out_kern.o
> always-y += hbm_edt_kern.o
>
> -TPROGS_CFLAGS = $(TPROGS_USER_CFLAGS)
> +COMMON_CFLAGS = $(TPROGS_USER_CFLAGS)
> TPROGS_LDFLAGS = $(TPROGS_USER_LDFLAGS)
>
> ifeq ($(ARCH), arm)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH bpf] samples/bpf: pass TPROGS_USER_CFLAGS to libbpf makefile
2024-12-04 17:34 [PATCH bpf] samples/bpf: pass TPROGS_USER_CFLAGS to libbpf makefile Eduard Zingerman
2024-12-05 7:07 ` Viktor Malik
@ 2024-12-05 18:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-12-05 18:40 UTC (permalink / raw)
To: Eduard Zingerman
Cc: bpf, ast, andrii, daniel, martin.lau, kernel-team, yonghong.song,
vmalik
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:
On Wed, 4 Dec 2024 09:34:16 -0800 you wrote:
> Before commit [1], the value of a variable TPROGS_USER_CFLAGS was
> passed to libbpf make command as a part of EXTRA_CFLAGS.
> This commit makes sure that the value of TPROGS_USER_CFLAGS is still
> passed to libbpf make command, in order to maintain backwards build
> scripts compatibility.
>
> [1] commit 5a6ea7022ff4 ("samples/bpf: Remove unnecessary -I flags from libbpf EXTRA_CFLAGS")
>
> [...]
Here is the summary with links:
- [bpf] samples/bpf: pass TPROGS_USER_CFLAGS to libbpf makefile
https://git.kernel.org/bpf/bpf-next/c/dff8470b99da
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-05 18:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-04 17:34 [PATCH bpf] samples/bpf: pass TPROGS_USER_CFLAGS to libbpf makefile Eduard Zingerman
2024-12-05 7:07 ` Viktor Malik
2024-12-05 18:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox