Re: [PATCHv2 bpf-next 5/6] selftests/bpf: Add uprobe_multi path_fd fail tests

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch references an undefined struct member `path_fd` and an undeclared macro `BPF_F_UPROBE_MULTI_PATH_FD`, which will cause compilation to fail.
--

commit 0e3f7d4f9ed46a64d02a1c29acb4f8e2215cb7c0
Author: Jiri Olsa <jolsa@kernel.org>

selftests/bpf: Add uprobe_multi path_fd fail tests

This commit adds tests to the attach_api_fails suite to verify that
invalid setups using the new path_fd feature in uprobe_multi fail as
expected.

> diff --git a/tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c b/tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c
> --- a/tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c
> +++ b/tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c
> @@ -536,7 +536,37 @@ static void test_attach_api_fails(void)

[ ... ]

> -	ASSERT_EQ(link_fd, -EINVAL, "pid_is_wrong");
> +	if (!ASSERT_EQ(link_fd, -EINVAL, "pid_is_wrong"))
> +		goto cleanup;
> +
> +	/* wrong path_fd */
> +	LIBBPF_OPTS_RESET(opts,
> +		.uprobe_multi.path = NULL,
> +		.uprobe_multi.path_fd = -1,
> +		.uprobe_multi.flags = BPF_F_UPROBE_MULTI_PATH_FD,

[Severity: Low]
Does this commit depend on a missing prerequisite patch? 

The path_fd member and BPF_F_UPROBE_MULTI_PATH_FD macro do not appear to be
defined in the current tree's bpf_link_create_opts struct or UAPI headers,
which will cause a compilation failure here.

> +		.uprobe_multi.offsets = (unsigned long *)&offset,
> +		.uprobe_multi.cnt = 1,
> +	);
> +
> +	link_fd = bpf_link_create(prog_fd, 0, BPF_TRACE_UPROBE_MULTI, &opts);
> +	if (!ASSERT_ERR(link_fd, "link_fd"))
> +		goto cleanup;
> +	if (!ASSERT_EQ(link_fd, -EBADF, "path_fd_is_wrong"))
> +		goto cleanup;
> +
> +	/* path and path_fd both set with BPF_F_UPROBE_MULTI_PATH_FD flag */
> +	LIBBPF_OPTS_RESET(opts,
> +		.uprobe_multi.path = path,
> +		.uprobe_multi.path_fd = 1,
> +		.uprobe_multi.flags = BPF_F_UPROBE_MULTI_PATH_FD,
> +		.uprobe_multi.offsets = (unsigned long *)&offset,
> +		.uprobe_multi.cnt = 1,
> +	);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260610143627.804790-6-jolsa@kernel.org?part=1