Re: [PATCHv2 bpf-next 4/6] selftests/bpf: Add uprobe_multi path_fd test

[Jiri Olsa <olsajiri@gmail.com>]

On Wed, Jun 10, 2026 at 02:50:45PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The selftest references a nonexistent struct member `path_fd` and an undeclared flag `BPF_F_UPROBE_MULTI_PATH_FD`, which will cause a compilation error.
> --
> 
> commit e5937d581d08ece9671b371d37fb6cd0d497b692
> Author: Jiri Olsa <jolsa@kernel.org>
> 
> selftests/bpf: Add uprobe_multi path_fd test
> 
> This commit adds a uprobe_multi link API selftest that opens /proc/self/exe
> and passes the resulting descriptor through opts.uprobe_multi.path_fd with
> BPF_F_UPROBE_MULTI_PATH_FD set.
> 
> > diff --git a/tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c b/tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c
> > index 56cbea280fbd2..ffcf3c92f0474 100644
> > --- a/tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c
> > +++ b/tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c
> 
> [ ... ]
> 
> > @@ -757,6 +758,65 @@ static void test_link_api(void)
> >  	__test_link_api(&child);
> >  }
> >  
> > +static void test_link_api_path_fd(void)
> > +{
> > +	LIBBPF_OPTS(bpf_link_create_opts, opts);
> > +	const char *resolve_path = "/proc/self/exe";
> > +	int prog_fd, link_fd = -1, path_fd = -1;
> 
> [ ... ]
> 
> > +	path_fd = open(resolve_path, O_RDONLY);
> > +	if (!ASSERT_GE(path_fd, 0, "path_fd"))
> > +		goto cleanup;
> > +
> > +	opts.uprobe_multi.path_fd = path_fd;
> > +	opts.uprobe_multi.offsets = offsets;
> > +	opts.uprobe_multi.cnt = ARRAY_SIZE(syms);
> > +	opts.uprobe_multi.flags = BPF_F_UPROBE_MULTI_PATH_FD;
> 
> [Severity: Low]
> Does this code reference an API that hasn't been introduced yet?
> 
> The struct field path_fd is not a valid member of uprobe_multi within
> struct bpf_link_create_opts in the libbpf headers, and the
> BPF_F_UPROBE_MULTI_PATH_FD macro is undeclared.
> 
> Because the patch doesn't include the corresponding kernel or libbpf
> changes, it looks like this will cause a compilation error.

compiles fine, it was introduced in:
  bpf: Add support to specify uprobe_multi target via file descriptor

jirka