Re: [PATCH bpf-next v4 6/6] selftests: drv-net: add XDP RX checksum metadata tests

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Multi-line comments in BPF code use the incorrect style (text on the same line as the opening `/*`).
--

--- Patch [6]: [PATCH bpf-next v4 6/6] selftests: drv-net: add XDP RX checksum metadata tests ---
commit 534009eb94d734041b26454f61107825d2b5f78e
Author: Vladimir Vdovin <deliran@verdict.gg>

selftests: drv-net: add XDP RX checksum metadata tests

This commit extends the xdp_metadata.py driver test with coverage for
bpf_xdp_metadata_rx_checksum(). It adds an xdp_rx_csum program to read
the RX checksum verdict and tests both valid and invalid RX checksum
scenarios on supported devices.

> diff --git a/tools/testing/selftests/net/lib/xdp_metadata.bpf.c b/tools/testing/selftests/net/lib/xdp_metadata.bpf.c
> index f71f59215239f..70decae0a6637 100644
> --- a/tools/testing/selftests/net/lib/xdp_metadata.bpf.c
> +++ b/tools/testing/selftests/net/lib/xdp_metadata.bpf.c
[ ... ]
> @@ -40,6 +41,24 @@ struct {
>  	__uint(max_entries, 4);
>  } map_rss SEC(".maps");
>  
> +/* RX checksum results: key 0 = ip_summed bitmask, key 1 = hw cksum value,
> + * key 2 = cksum level, key 3 = packet count, key 4 = error count.
> + */

[Severity: Low]
This isn't a bug, but the modern BPF multi-line comment style requires
the opening /* to be on its own line. Could this be updated so the text
starts on the next line?

> +enum {
> +	CSUM_KEY_IP_SUMMED = 0,
> +	CSUM_KEY_CKSUM = 1,
[ ... ]
> @@ -55,8 +74,20 @@ enum xdp_rss_hash_type {
>  	XDP_RSS_L4_ICMP = 1U << 8,
>  };
>  
> +/* Mirror of enum xdp_checksum from include/net/xdp.h.
> + * Needed because the enum is not part of UAPI headers.
> + */

[Severity: Low]
This isn't a bug, but this multi-line comment also has text on the same
line as the opening /*. Could this follow the preferred BPF multi-line
comment style?

> +enum xdp_checksum {
> +	XDP_CHECKSUM_NONE = 1U << 0,
> +	XDP_CHECKSUM_UNNECESSARY = 1U << 1,
[ ... ]
> @@ -78,41 +109,39 @@ static __always_inline __u16 get_dest_port(void *l4, void *data_end,
>  	return 0;
>  }
>  
> -SEC("xdp")
> -int xdp_rss_hash(struct xdp_md *ctx)
> +/* Return true when the packet matches the L4 protocol and destination
> + * port configured in map_xdp_setup (zero/unset filters match anything).
> + */

[Severity: Low]
This isn't a bug, but the opening /* should be on its own line here as well
to match the preferred BPF comment style.

> +static __always_inline bool xdp_match_setup(struct xdp_md *ctx)
>  {
>  	void *data_end = (void *)(long)ctx->data_end;
>  	void *data = (void *)(long)ctx->data;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708203410.45121-1-deliran@verdict.gg?part=6