Re: [PATCH bpf-next v4 1/6] netlink: specs: Add XDP RX checksum capability to XDP metadata specs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added multi-line comment for `enum xdp_checksum` violates the strict BPF subsystem multi-line comment style.
--

--- Patch [1]: [PATCH bpf-next v4 1/6] netlink: specs: Add XDP RX checksum capability to XDP metadata specs ---
commit bd15750c5adb8990bb2bd31725238a0442a743f1
Author: Lorenzo Bianconi <lorenzo@kernel.org>

netlink: specs: Add XDP RX checksum capability to XDP metadata specs

Introduce XDP RX checksum capability to XDP metadata specs. It adds
the xmo_rx_checksum netdev callback to allow eBPF programs to retrieve
the RX checksum result computed by the hw NIC.

> diff --git a/include/net/xdp.h b/include/net/xdp.h
> index aa742f413c358..e255ff7861310 100644
> --- a/include/net/xdp.h
> +++ b/include/net/xdp.h
[ ... ]
> @@ -643,12 +647,26 @@ enum xdp_rss_hash_type {
>  	XDP_RSS_TYPE_L4_IPV6_SCTP_EX = XDP_RSS_TYPE_L4_IPV6_SCTP | XDP_RSS_L3_DYNHDR,
>  };
>  
> +/* Please note the driver is required to invalidate the checksum if the NIC
> + * reports CHECKSUM_UNNECESSARY or CHECKSUM_COMPLETE and the eBPF program
> + * modifies the packet since it can change some fields validated by the
> + * checksum.
> + */

[Severity: Low]
This isn't a bug, but does this multi-line comment for enum xdp_checksum
violate the BPF subsystem comment style? The preferred kernel style for
multi-line comments has the opening /* on its own line:

/*
 * Please note the driver is required to invalidate the checksum if the NIC
 * reports CHECKSUM_UNNECESSARY...
 */

> +enum xdp_checksum {
> +	XDP_CHECKSUM_NONE		= BIT(CHECKSUM_NONE),
> +	XDP_CHECKSUM_UNNECESSARY	= BIT(CHECKSUM_UNNECESSARY),
> +	XDP_CHECKSUM_COMPLETE		= BIT(CHECKSUM_COMPLETE),
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708203410.45121-1-deliran@verdict.gg?part=1