Re: [PATCH bpf-next v3 01/17] bpf: Add verifier diagnostics report helpers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The static functions `diag_report_reason` and `diag_report_suggestion` (and their dependent static functions like `diag_report_section`, `diag_vprint_indented`, etc.) are defined but never used in `kernel/bpf/diagnostics.c`. Additionally, several `CATEGORY_*` macros are defined locally in the `.c` file instead of the header, making them inaccessible to external callers.
--

--- Patch [1]: [PATCH bpf-next v3 01/17] bpf: Add verifier diagnostics report helpers ---
commit 1babdf2fc54b5272d1520095320e5a3cddaa9347
Author: Kumar Kartikeya Dwivedi <memxor@gmail.com>

bpf: Add verifier diagnostics report helpers
    
Add a small diagnostics renderer for verifier reports and wire it into
the BPF build. The initial helpers emit the common text structure: a
failure header plus reusable report sections.

> diff --git a/kernel/bpf/diagnostics.c b/kernel/bpf/diagnostics.c
> new file mode 100644
> index 0000000000000..6d28a3481cfa5
> --- /dev/null
> +++ b/kernel/bpf/diagnostics.c
> @@ -0,0 +1,157 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +// Copyright (c) 2026 Meta Platforms, Inc. and affiliates.
> +
> +#include <linux/bpf_verifier.h>
> +#include <linux/ctype.h>
> +#include <linux/slab.h>
> +#include <linux/stdarg.h>
> +#include <linux/string.h>
> +
> +#include "diagnostics.h"
> +
> +#define CATEGORY_MEMORY_SAFETY "Memory Safety"
> +#define CATEGORY_REGISTER_TYPE_SAFETY "Register Type Safety"
> +#define CATEGORY_CALL_TYPE_SAFETY "Call Type Safety"
> +#define CATEGORY_RESOURCE_LIFETIME_SAFETY "Resource Lifetime Safety"
> +#define CATEGORY_EXECUTION_CONTEXT_SAFETY "Execution Context Safety"
> +#define CATEGORY_PROGRAM_STRUCTURE "Program Structure"
> +#define CATEGORY_POLICY "Policy"
> +#define CATEGORY_VERIFIER_LIMIT "Verifier Limit"
> +#define CATEGORY_VERIFIER_INTERNAL_ERROR "Verifier Internal Error"

[Severity: Low]
Should these CATEGORY_* macros be exported in the diagnostics.h header? Since
they define the expected categories for bpf_diag_report_header(), keeping
them local to this .c file prevents other subsystems from accessing them
when calling the API.

[ ... ]

> +static void diag_report_reason(struct bpf_verifier_env *env, const char *fmt, ...)
> +{
> +	va_list args;
> +
> +	if (!bpf_diag_enabled(env))
> +		return;
> +
> +	diag_report_section(env, "Reason");
> +
> +	va_start(args, fmt);
> +	diag_vprint_indented(env, fmt, args);
> +	va_end(args);
> +}
> +
> +static void diag_report_suggestion(struct bpf_verifier_env *env, const char *fmt, ...)
> +{
> +	va_list args;
> +
> +	if (!bpf_diag_enabled(env))
> +		return;
> +
> +	diag_report_section(env, "Suggestion");
> +
> +	va_start(args, fmt);
> +	diag_vprint_indented(env, fmt, args);
> +	va_end(args);
> +	diag_log(env, "\n");
> +}

[Severity: Low]
Will these static functions trigger -Wunused-function compiler warnings?
Since diag_report_reason() and diag_report_suggestion() are defined but
never called or exported in this patch, they could break the build when
CONFIG_WERROR=y is enabled.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713153910.2556007-1-memxor@gmail.com?part=1