* [PATCH bpf-next] kbuild, bpf: Correct pahole version that supports distilled base btf feature @ 2025-02-19 6:31 Pu Lehui 2025-02-21 0:30 ` Andrii Nakryiko 2025-02-24 22:20 ` patchwork-bot+netdevbpf 0 siblings, 2 replies; 6+ messages in thread From: Pu Lehui @ 2025-02-19 6:31 UTC (permalink / raw) To: bpf Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, Martin KaFai Lau, Eduard Zingerman, Song Liu, Yonghong Song, John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa, Alan Maguire, Pu Lehui, Pu Lehui From: Pu Lehui <pulehui@huawei.com> pahole commit [0] of supporting distilled base btf feature released on pahole v1.28 rather than v1.26. So let's correct this. Link: https://git.kernel.org/pub/scm/devel/pahole/pahole.git/commit/?id=c7b1f6a29ba1 [0] Signed-off-by: Pu Lehui <pulehui@huawei.com> --- scripts/Makefile.btf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.btf b/scripts/Makefile.btf index c3cbeb13de50..fbaaec2187e5 100644 --- a/scripts/Makefile.btf +++ b/scripts/Makefile.btf @@ -24,7 +24,7 @@ else pahole-flags-$(call test-ge, $(pahole-ver), 126) = -j$(JOBS) --btf_features=encode_force,var,float,enum64,decl_tag,type_tag,optimized_func,consistent_func,decl_tag_kfuncs ifneq ($(KBUILD_EXTMOD),) -module-pahole-flags-$(call test-ge, $(pahole-ver), 126) += --btf_features=distilled_base +module-pahole-flags-$(call test-ge, $(pahole-ver), 128) += --btf_features=distilled_base endif endif -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH bpf-next] kbuild, bpf: Correct pahole version that supports distilled base btf feature 2025-02-19 6:31 [PATCH bpf-next] kbuild, bpf: Correct pahole version that supports distilled base btf feature Pu Lehui @ 2025-02-21 0:30 ` Andrii Nakryiko 2025-02-24 12:16 ` Pu Lehui 2025-02-24 22:20 ` patchwork-bot+netdevbpf 1 sibling, 1 reply; 6+ messages in thread From: Andrii Nakryiko @ 2025-02-21 0:30 UTC (permalink / raw) To: Pu Lehui, Alan Maguire Cc: bpf, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, Martin KaFai Lau, Eduard Zingerman, Song Liu, Yonghong Song, John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa, Pu Lehui On Tue, Feb 18, 2025 at 10:29 PM Pu Lehui <pulehui@huaweicloud.com> wrote: > > From: Pu Lehui <pulehui@huawei.com> > > pahole commit [0] of supporting distilled base btf feature released on > pahole v1.28 rather than v1.26. So let's correct this. > > Link: https://git.kernel.org/pub/scm/devel/pahole/pahole.git/commit/?id=c7b1f6a29ba1 [0] > Signed-off-by: Pu Lehui <pulehui@huawei.com> > --- > scripts/Makefile.btf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/Makefile.btf b/scripts/Makefile.btf > index c3cbeb13de50..fbaaec2187e5 100644 > --- a/scripts/Makefile.btf > +++ b/scripts/Makefile.btf > @@ -24,7 +24,7 @@ else > pahole-flags-$(call test-ge, $(pahole-ver), 126) = -j$(JOBS) --btf_features=encode_force,var,float,enum64,decl_tag,type_tag,optimized_func,consistent_func,decl_tag_kfuncs > > ifneq ($(KBUILD_EXTMOD),) > -module-pahole-flags-$(call test-ge, $(pahole-ver), 126) += --btf_features=distilled_base > +module-pahole-flags-$(call test-ge, $(pahole-ver), 128) += --btf_features=distilled_base > endif Alan, Is this correct? Can you please check and ack? Thanks! > > endif > -- > 2.34.1 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH bpf-next] kbuild, bpf: Correct pahole version that supports distilled base btf feature 2025-02-21 0:30 ` Andrii Nakryiko @ 2025-02-24 12:16 ` Pu Lehui 2025-02-24 22:24 ` Andrii Nakryiko 0 siblings, 1 reply; 6+ messages in thread From: Pu Lehui @ 2025-02-24 12:16 UTC (permalink / raw) To: Andrii Nakryiko, Pu Lehui, Alan Maguire Cc: bpf, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, Martin KaFai Lau, Eduard Zingerman, Song Liu, Yonghong Song, John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa On 2025/2/21 8:30, Andrii Nakryiko wrote: > On Tue, Feb 18, 2025 at 10:29 PM Pu Lehui <pulehui@huaweicloud.com> wrote: >> >> From: Pu Lehui <pulehui@huawei.com> >> >> pahole commit [0] of supporting distilled base btf feature released on >> pahole v1.28 rather than v1.26. So let's correct this. >> >> Link: https://git.kernel.org/pub/scm/devel/pahole/pahole.git/commit/?id=c7b1f6a29ba1 [0] >> Signed-off-by: Pu Lehui <pulehui@huawei.com> >> --- >> scripts/Makefile.btf | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/scripts/Makefile.btf b/scripts/Makefile.btf >> index c3cbeb13de50..fbaaec2187e5 100644 >> --- a/scripts/Makefile.btf >> +++ b/scripts/Makefile.btf >> @@ -24,7 +24,7 @@ else >> pahole-flags-$(call test-ge, $(pahole-ver), 126) = -j$(JOBS) --btf_features=encode_force,var,float,enum64,decl_tag,type_tag,optimized_func,consistent_func,decl_tag_kfuncs >> >> ifneq ($(KBUILD_EXTMOD),) >> -module-pahole-flags-$(call test-ge, $(pahole-ver), 126) += --btf_features=distilled_base >> +module-pahole-flags-$(call test-ge, $(pahole-ver), 128) += --btf_features=distilled_base >> endif > > Alan, > > Is this correct? Can you please check and ack? Thanks! Maybe Alan doesn't have time to reply at the moment. We can use the following command to check that in pahole.git: $ git name-rev c7b1f6a29ba1 c7b1f6a29ba1 tags/v1.28~73 > >> >> endif >> -- >> 2.34.1 >> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH bpf-next] kbuild, bpf: Correct pahole version that supports distilled base btf feature 2025-02-24 12:16 ` Pu Lehui @ 2025-02-24 22:24 ` Andrii Nakryiko 2025-02-25 9:32 ` Alan Maguire 0 siblings, 1 reply; 6+ messages in thread From: Andrii Nakryiko @ 2025-02-24 22:24 UTC (permalink / raw) To: Pu Lehui Cc: Pu Lehui, Alan Maguire, bpf, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, Martin KaFai Lau, Eduard Zingerman, Song Liu, Yonghong Song, John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa On Mon, Feb 24, 2025 at 4:16 AM Pu Lehui <pulehui@huawei.com> wrote: > > > > On 2025/2/21 8:30, Andrii Nakryiko wrote: > > On Tue, Feb 18, 2025 at 10:29 PM Pu Lehui <pulehui@huaweicloud.com> wrote: > >> > >> From: Pu Lehui <pulehui@huawei.com> > >> > >> pahole commit [0] of supporting distilled base btf feature released on > >> pahole v1.28 rather than v1.26. So let's correct this. > >> > >> Link: https://git.kernel.org/pub/scm/devel/pahole/pahole.git/commit/?id=c7b1f6a29ba1 [0] > >> Signed-off-by: Pu Lehui <pulehui@huawei.com> > >> --- > >> scripts/Makefile.btf | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/scripts/Makefile.btf b/scripts/Makefile.btf > >> index c3cbeb13de50..fbaaec2187e5 100644 > >> --- a/scripts/Makefile.btf > >> +++ b/scripts/Makefile.btf > >> @@ -24,7 +24,7 @@ else > >> pahole-flags-$(call test-ge, $(pahole-ver), 126) = -j$(JOBS) --btf_features=encode_force,var,float,enum64,decl_tag,type_tag,optimized_func,consistent_func,decl_tag_kfuncs > >> > >> ifneq ($(KBUILD_EXTMOD),) > >> -module-pahole-flags-$(call test-ge, $(pahole-ver), 126) += --btf_features=distilled_base > >> +module-pahole-flags-$(call test-ge, $(pahole-ver), 128) += --btf_features=distilled_base > >> endif > > > > Alan, > > > > Is this correct? Can you please check and ack? Thanks! > > Maybe Alan doesn't have time to reply at the moment. We can use the > following command to check that in pahole.git: > > $ git name-rev c7b1f6a29ba1 > c7b1f6a29ba1 tags/v1.28~73 yep, I was a bit lazy to search for specific commit ;) I like this command, though: $ git tag --contains c7b1f6a29ba1 v1.28 v1.29 regardless, applied to bpf-next, thanks > > > > >> > >> endif > >> -- > >> 2.34.1 > >> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH bpf-next] kbuild, bpf: Correct pahole version that supports distilled base btf feature 2025-02-24 22:24 ` Andrii Nakryiko @ 2025-02-25 9:32 ` Alan Maguire 0 siblings, 0 replies; 6+ messages in thread From: Alan Maguire @ 2025-02-25 9:32 UTC (permalink / raw) To: Andrii Nakryiko, Pu Lehui Cc: Pu Lehui, bpf, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, Martin KaFai Lau, Eduard Zingerman, Song Liu, Yonghong Song, John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa On 24/02/2025 22:24, Andrii Nakryiko wrote: > On Mon, Feb 24, 2025 at 4:16 AM Pu Lehui <pulehui@huawei.com> wrote: >> >> >> >> On 2025/2/21 8:30, Andrii Nakryiko wrote: >>> On Tue, Feb 18, 2025 at 10:29 PM Pu Lehui <pulehui@huaweicloud.com> wrote: >>>> >>>> From: Pu Lehui <pulehui@huawei.com> >>>> >>>> pahole commit [0] of supporting distilled base btf feature released on >>>> pahole v1.28 rather than v1.26. So let's correct this. >>>> >>>> Link: https://git.kernel.org/pub/scm/devel/pahole/pahole.git/commit/?id=c7b1f6a29ba1 [0] >>>> Signed-off-by: Pu Lehui <pulehui@huawei.com> >>>> --- >>>> scripts/Makefile.btf | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/scripts/Makefile.btf b/scripts/Makefile.btf >>>> index c3cbeb13de50..fbaaec2187e5 100644 >>>> --- a/scripts/Makefile.btf >>>> +++ b/scripts/Makefile.btf >>>> @@ -24,7 +24,7 @@ else >>>> pahole-flags-$(call test-ge, $(pahole-ver), 126) = -j$(JOBS) --btf_features=encode_force,var,float,enum64,decl_tag,type_tag,optimized_func,consistent_func,decl_tag_kfuncs >>>> >>>> ifneq ($(KBUILD_EXTMOD),) >>>> -module-pahole-flags-$(call test-ge, $(pahole-ver), 126) += --btf_features=distilled_base >>>> +module-pahole-flags-$(call test-ge, $(pahole-ver), 128) += --btf_features=distilled_base >>>> endif >>> >>> Alan, >>> >>> Is this correct? Can you please check and ack? Thanks! >> >> Maybe Alan doesn't have time to reply at the moment. We can use the >> following command to check that in pahole.git: >> >> $ git name-rev c7b1f6a29ba1 >> c7b1f6a29ba1 tags/v1.28~73 > > > yep, I was a bit lazy to search for specific commit ;) > > I like this command, though: > > $ git tag --contains c7b1f6a29ba1 > v1.28 > v1.29 > > regardless, applied to bpf-next, thanks > Apologies I missed this. The change is perfect - while 1.26 will not error out for unrecognized features like this, it's better to reflect that the feature landed in pahole 1.28. Again, thanks for the fix! Alan ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH bpf-next] kbuild, bpf: Correct pahole version that supports distilled base btf feature 2025-02-19 6:31 [PATCH bpf-next] kbuild, bpf: Correct pahole version that supports distilled base btf feature Pu Lehui 2025-02-21 0:30 ` Andrii Nakryiko @ 2025-02-24 22:20 ` patchwork-bot+netdevbpf 1 sibling, 0 replies; 6+ messages in thread From: patchwork-bot+netdevbpf @ 2025-02-24 22:20 UTC (permalink / raw) To: Pu Lehui Cc: bpf, ast, daniel, andrii, martin.lau, eddyz87, song, yonghong.song, john.fastabend, kpsingh, sdf, haoluo, jolsa, alan.maguire, pulehui Hello: This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <andrii@kernel.org>: On Wed, 19 Feb 2025 06:31:13 +0000 you wrote: > From: Pu Lehui <pulehui@huawei.com> > > pahole commit [0] of supporting distilled base btf feature released on > pahole v1.28 rather than v1.26. So let's correct this. > > Link: https://git.kernel.org/pub/scm/devel/pahole/pahole.git/commit/?id=c7b1f6a29ba1 [0] > Signed-off-by: Pu Lehui <pulehui@huawei.com> > > [...] Here is the summary with links: - [bpf-next] kbuild, bpf: Correct pahole version that supports distilled base btf feature https://git.kernel.org/bpf/bpf-next/c/1ffe30efd2f2 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-02-25 9:32 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-02-19 6:31 [PATCH bpf-next] kbuild, bpf: Correct pahole version that supports distilled base btf feature Pu Lehui 2025-02-21 0:30 ` Andrii Nakryiko 2025-02-24 12:16 ` Pu Lehui 2025-02-24 22:24 ` Andrii Nakryiko 2025-02-25 9:32 ` Alan Maguire 2025-02-24 22:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox